From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 3788543709; Sat, 16 Dec 2023 10:47:55 +0100 (CET) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id B4B3D40691; Sat, 16 Dec 2023 10:47:54 +0100 (CET) Received: from shelob.oktetlabs.ru (shelob.oktetlabs.ru [91.220.146.113]) by mails.dpdk.org (Postfix) with ESMTP id C9CB4402AA; Sat, 16 Dec 2023 10:47:52 +0100 (CET) Received: from [192.168.38.17] (aros.oktetlabs.ru [192.168.38.17]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by shelob.oktetlabs.ru (Postfix) with ESMTPSA id 345F066; Sat, 16 Dec 2023 12:47:52 +0300 (MSK) DKIM-Filter: OpenDKIM Filter v2.11.0 shelob.oktetlabs.ru 345F066 DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple; d=oktetlabs.ru; s=default; t=1702720072; bh=S36wf27qu4HREZgzu7Hs7f6R6RorVEkwL3BFA/X84vw=; h=Date:Subject:To:Cc:References:From:In-Reply-To:From; b=h1l5GlfEn9JgqnNtfsIXtbKM3X/VBpgOdY30ZnPBt0mAGH4lclSCskKV3B/pJej/v 2lhWWZed8BNVtIauiCfAqgWdHdEcix66quN0Aflua+iJDSzHogWp2Lrc+Xu8hjeve+ ODa3AqWYIkQ5JuTIq4xO+uFQntT+eqb+XsTonJhg= Message-ID: <7bc8281e-a663-40ae-81f6-a66f024d0bb5@oktetlabs.ru> Date: Sat, 16 Dec 2023 12:47:51 +0300 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [RFC v2 03/14] lib: use dedicated logtypes Content-Language: en-US To: David Marchand , dev@dpdk.org Cc: thomas@monjalon.net, ferruh.yigit@amd.com, bruce.richardson@intel.com, stephen@networkplumber.org, mb@smartsharesystems.com, stable@dpdk.org, Akhil Goyal , Fan Zhang , Amit Prakash Shukla , Jerin Jacob , Naga Harish K S V References: <20231117131824.1977792-1-david.marchand@redhat.com> <20231208145950.2184940-1-david.marchand@redhat.com> <20231208145950.2184940-4-david.marchand@redhat.com> From: Andrew Rybchenko Organization: OKTET Labs In-Reply-To: <20231208145950.2184940-4-david.marchand@redhat.com> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org On 12/8/23 17:59, David Marchand wrote: > No printf! > When a dedicated log helper exists, use it. > And no usurpation please: a library should log under its logtype > (see the eventdev rx adapter update for example). > > Note: the RTE_ETH_VALID_PORTID_OR_GOTO_ERR_RET macro is renamed for > consistency with the rest of eventdev (private) macros. > > Cc: stable@dpdk.org > > Signed-off-by: David Marchand Reviewed-by: Andrew Rybchenko