From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-wm0-f44.google.com (mail-wm0-f44.google.com [74.125.82.44]) by dpdk.org (Postfix) with ESMTP id 013AF58FA for ; Mon, 24 Apr 2017 17:53:20 +0200 (CEST) Received: by mail-wm0-f44.google.com with SMTP id u65so395626wmu.1 for ; Mon, 24 Apr 2017 08:53:20 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=6wind-com.20150623.gappssmtp.com; s=20150623; h=from:to:cc:subject:date:message-id:in-reply-to:references; bh=/fmGpiGKruXs7n2baFZnNFjhmQrvRe9gAJWb15AmN60=; b=CzaX54l6WQR/5Uf+E1xDyhoyzGfkmo1+L2FL6QRKDAtu/JpjNdjO2DBrPMCZRhkuWo 6b4CGLvYYF+CsmvRo7CZP4aVm8QNW3c+JByDhiELpqlgjsBVOazRXSTLf0x2X+23zvtF Ca3CaWX8XITKCCJ47Z+FvBbgwnV0oK5ADQgUaORYdsG1J1FEArTwcZSXHJqWTrcitA7q HYdYDDz9cP7V1H60c4nRdzBL2h7cdi0zV19lr52DPWO9ZJTXkOJ8rrOjPvDk/PfUrEwl XtWPRv6x/k9wCMzggb4Zbg1JNlInsJE8E1EPfEZxv0U9ZonApfzBRs9j0oluP1gr00Q1 +Wiw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references; bh=/fmGpiGKruXs7n2baFZnNFjhmQrvRe9gAJWb15AmN60=; b=dPHVts3jFM++IDyVPhlq1TlVNfZG2m2rD7XZNaajnSpfwlhos/9DmXeCxNMXODYf06 +CJv8myLtXq39wf7lE6v/zrxHbtUfi94lCoPb4wLgWngRcEJkKiLCs0wv06BxX4fkMhy JpZa5xHWG48mkwmER3la64qFv9z6/C2KIiVYFVHttmhJF2GjQ5mnA/SaH8NhN4WsBcVI bgRhj2Hd+tVjswn//fBgc0J5AbdpQOLHbuLmQsS/hlmJUgF9NwrMdmiAaC92wyj6q69Q 8PSJPGAezotvylnlOrFSWZubpkPvhRQabSKsCUzyDLVXPpNvcK6i5DpJlwBvppffcqPU he0g== X-Gm-Message-State: AN3rC/58CwvloZMJ6zrJyQfMG2bCEVWiV6zk9ZPA7JhMaP86WpVTEbEu Kb3nsRt/mHL/rNny X-Received: by 10.28.148.3 with SMTP id w3mr10441203wmd.8.1493049200723; Mon, 24 Apr 2017 08:53:20 -0700 (PDT) Received: from 6wind.com (host.78.145.23.62.rev.coltfrance.com. [62.23.145.78]) by smtp.gmail.com with ESMTPSA id h199sm936182wme.4.2017.04.24.08.53.19 (version=TLS1_2 cipher=AES128-SHA bits=128/128); Mon, 24 Apr 2017 08:53:20 -0700 (PDT) From: Adrien Mazarguil To: dev@dpdk.org Cc: Jerin Jacob Date: Mon, 24 Apr 2017 17:52:56 +0200 Message-Id: <7bcd5fdf2d7cbf7b13909748b8ed56aefa986a53.1493048352.git.adrien.mazarguil@6wind.com> X-Mailer: git-send-email 2.1.4 In-Reply-To: References: Subject: [dpdk-dev] [PATCH 02/13] eventdev: fix errors with strict compilation flags X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 24 Apr 2017 15:53:21 -0000 Exported headers must allow compilation with the strictest flags. This commit addresses the following errors: In file included from build/include/rte_eventdev_pmd.h:55:0, from /tmp/check-includes.sh.25816.c:1: build/include/rte_eventdev.h:908:8: error: struct has no named members [-Werror=pedantic] [...] In file included from /tmp/check-includes.sh.25816.c:1:0: build/include/rte_eventdev_pmd.h:65:35: error: ISO C does not permit named variadic macros [-Werror=variadic-macros] [...] Fixes: 71f238432865 ("eventdev: introduce event driven programming model") Fixes: 4f0804bbdfb9 ("eventdev: implement the northbound APIs") Cc: Jerin Jacob Signed-off-by: Adrien Mazarguil --- lib/librte_eventdev/rte_eventdev.h | 3 +-- lib/librte_eventdev/rte_eventdev_pmd.h | 16 +++++++++------- 2 files changed, 10 insertions(+), 9 deletions(-) diff --git a/lib/librte_eventdev/rte_eventdev.h b/lib/librte_eventdev/rte_eventdev.h index b8ed6ef..20e7293 100644 --- a/lib/librte_eventdev/rte_eventdev.h +++ b/lib/librte_eventdev/rte_eventdev.h @@ -905,9 +905,9 @@ rte_event_dev_close(uint8_t dev_id); * The generic *rte_event* structure to hold the event attributes * for dequeue and enqueue operation */ +RTE_STD_C11 struct rte_event { /** WORD0 */ - RTE_STD_C11 union { uint64_t event; /** Event attributes for dequeue or enqueue operation */ @@ -967,7 +967,6 @@ struct rte_event { }; }; /** WORD1 */ - RTE_STD_C11 union { uint64_t u64; /**< Opaque 64-bit value */ diff --git a/lib/librte_eventdev/rte_eventdev_pmd.h b/lib/librte_eventdev/rte_eventdev_pmd.h index a73dc91..988018f 100644 --- a/lib/librte_eventdev/rte_eventdev_pmd.h +++ b/lib/librte_eventdev/rte_eventdev_pmd.h @@ -62,16 +62,18 @@ extern "C" { #endif /* Logging Macros */ -#define RTE_EDEV_LOG_ERR(fmt, args...) \ - RTE_LOG(ERR, EVENTDEV, "%s() line %u: " fmt "\n", \ - __func__, __LINE__, ## args) +#define RTE_EDEV_LOG_ERR(...) \ + RTE_LOG(ERR, EVENTDEV, \ + RTE_FMT("%s() line %u: " RTE_FMT_HEAD(__VA_ARGS__,) "\n", \ + __func__, __LINE__, RTE_FMT_TAIL(__VA_ARGS__,))) #ifdef RTE_LIBRTE_EVENTDEV_DEBUG -#define RTE_EDEV_LOG_DEBUG(fmt, args...) \ - RTE_LOG(DEBUG, EVENTDEV, "%s() line %u: " fmt "\n", \ - __func__, __LINE__, ## args) +#define RTE_EDEV_LOG_DEBUG(...) \ + RTE_LOG(DEBUG, EVENTDEV, \ + RTE_FMT("%s() line %u: " RTE_FMT_HEAD(__VA_ARGS__,) "\n", \ + __func__, __LINE__, RTE_FMT_TAIL(__VA_ARGS__,))) #else -#define RTE_EDEV_LOG_DEBUG(fmt, args...) (void)0 +#define RTE_EDEV_LOG_DEBUG(...) (void)0 #endif /* Macros to check for valid device */ -- 2.1.4