From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id BC777A0A02; Tue, 27 Apr 2021 15:39:29 +0200 (CEST) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 677F940150; Tue, 27 Apr 2021 15:39:29 +0200 (CEST) Received: from mga11.intel.com (mga11.intel.com [192.55.52.93]) by mails.dpdk.org (Postfix) with ESMTP id B290B4014E for ; Tue, 27 Apr 2021 15:39:27 +0200 (CEST) IronPort-SDR: QeMG457Ly54OIYf2q6ydyC8N7WcuJPdaYBvpmD+Cf41A7oPP9Sx66HIbQQQ31cUJY/NtATdw99 /xyZFo33TJBw== X-IronPort-AV: E=McAfee;i="6200,9189,9966"; a="193323548" X-IronPort-AV: E=Sophos;i="5.82,254,1613462400"; d="scan'208";a="193323548" Received: from fmsmga002.fm.intel.com ([10.253.24.26]) by fmsmga102.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 27 Apr 2021 06:39:26 -0700 IronPort-SDR: zhNyejQ267R5ypJUxIDZo9dqiB818uKDlSkZGx2DBJwAWDbqQ/EZzsZFABlH2IlJDwMxtFP3+U nyhIrOLbUR9g== X-IronPort-AV: E=Sophos;i="5.82,254,1613462400"; d="scan'208";a="457648263" Received: from fyigit-mobl1.ger.corp.intel.com (HELO [10.213.221.231]) ([10.213.221.231]) by fmsmga002-auth.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 27 Apr 2021 06:39:26 -0700 To: "Min Hu (Connor)" , dev@dpdk.org References: <1619408092-54050-1-git-send-email-humin29@huawei.com> <1619408092-54050-6-git-send-email-humin29@huawei.com> From: Ferruh Yigit X-User: ferruhy Message-ID: <7bd1346a-99ef-b3a3-49d6-8f914a103c3b@intel.com> Date: Tue, 27 Apr 2021 14:39:24 +0100 MIME-Version: 1.0 In-Reply-To: <1619408092-54050-6-git-send-email-humin29@huawei.com> Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 7bit Subject: Re: [dpdk-dev] [PATCH 5/6] net/hns3: log fdir configuration X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" On 4/26/2021 4:34 AM, Min Hu (Connor) wrote: > From: Chengwen Feng > > The rte flow interface does not support the API of the capability > set. Therefore, fdir configuration logs are added to facilitate > debugging. > > Signed-off-by: Chengwen Feng > Signed-off-by: Min Hu (Connor) > --- > drivers/net/hns3/hns3_fdir.c | 13 +++++++++++++ > 1 file changed, 13 insertions(+) > > diff --git a/drivers/net/hns3/hns3_fdir.c b/drivers/net/hns3/hns3_fdir.c > index 87c1aef..8b14219 100644 > --- a/drivers/net/hns3/hns3_fdir.c > +++ b/drivers/net/hns3/hns3_fdir.c > @@ -336,6 +336,8 @@ int hns3_init_fd_config(struct hns3_adapter *hns) > BIT(INNER_IP_PROTO) | BIT(INNER_IP_TOS) | > BIT(INNER_SRC_IP) | BIT(INNER_DST_IP) | > BIT(INNER_SRC_PORT) | BIT(INNER_DST_PORT); > + hns3_info(hw, "fdir tuple: inner + "ip_proto ip_tos l4_src_port l4_dst_port>"); If the messages are for debugging, what do you think about add them as 'hns3_dbg'? Isn't info level too verbose for debugging?