From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id CA234A0C55; Wed, 13 Oct 2021 23:08:11 +0200 (CEST) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 8CA13410E2; Wed, 13 Oct 2021 23:08:11 +0200 (CEST) Received: from mga01.intel.com (mga01.intel.com [192.55.52.88]) by mails.dpdk.org (Postfix) with ESMTP id C7F1A410DB for ; Wed, 13 Oct 2021 23:08:09 +0200 (CEST) X-IronPort-AV: E=McAfee;i="6200,9189,10136"; a="250966489" X-IronPort-AV: E=Sophos;i="5.85,371,1624345200"; d="scan'208";a="250966489" Received: from fmsmga005.fm.intel.com ([10.253.24.32]) by fmsmga101.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 13 Oct 2021 14:08:08 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.85,371,1624345200"; d="scan'208";a="717488923" Received: from orsmsx606.amr.corp.intel.com ([10.22.229.19]) by fmsmga005.fm.intel.com with ESMTP; 13 Oct 2021 14:08:08 -0700 Received: from orsmsx604.amr.corp.intel.com (10.22.229.17) by ORSMSX606.amr.corp.intel.com (10.22.229.19) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2242.12; Wed, 13 Oct 2021 14:08:08 -0700 Received: from ORSEDG601.ED.cps.intel.com (10.7.248.6) by orsmsx604.amr.corp.intel.com (10.22.229.17) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2242.12 via Frontend Transport; Wed, 13 Oct 2021 14:08:08 -0700 Received: from NAM10-MW2-obe.outbound.protection.outlook.com (104.47.55.106) by edgegateway.intel.com (134.134.137.102) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.1.2242.12; Wed, 13 Oct 2021 14:08:08 -0700 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=PKIaYeyxDIU3oy2rRAKtDwJ5uWm0GEEVo65/mWYDpa1GNURZK0y5DWyAwwzkml1m6zE8riizNb1b6rywX/WxnpzhIoC8czd9jM7j+JQp8jO1LelYTzWYMBvVl0vdHs8Vjg7S/9QMtf9S3TAYVNaKqIjCT/hW2wmxq46TuJOUTHdPjIdQUH6xFcuA1IMtQPkMPLt53YqFhrX280SSWfjDHjmTClDEt/eYr5ZYR7d3pmwXGYfTnBe8DlbaLLC2/n79jsJ4Y4zQzs6BhD4ncYsVwf4TLBcLrvR6JEXF7bcQ08P5Gnf4iEs6NREcLS5IIaeGXKLMOZ5ni6kjpfOmvCz9+w== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=xcR8tSzi8HD+ryj6OILdCgjKc4nzg5Q6s/oYe+hS+Wc=; b=PIptypf2uEiacXpV9BwuxhwUMY7k9eIQBum8zsiOOABOQmxe6EmdZFCs6eOO3FOL66wcgvExOeYhNocnWiHMiZAyLxmqhsJt7wMlp675BusMFUPXps52BiJgoe5VKJXLIAD2b/etxD+ql0qV03wtbC8suWRTTYzXpXEkP+CFoYjJZvNOnW0f6sYy8bwOx9/sIKKU3os7lky1oCtI2K2nAek9MLGrLL8tnUjfI5OtNtp4ElAQHg2EW3+062mld5nsYK9VuLlLBJqjqM7fUDo8Gokr50taVsGKH8SEJdUeNnDoLtTq6liLgoHxBBmldzN4M94snyhLbMuF/JQXn1G4Wg== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=intel.com; dmarc=pass action=none header.from=intel.com; dkim=pass header.d=intel.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=intel.onmicrosoft.com; s=selector2-intel-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=xcR8tSzi8HD+ryj6OILdCgjKc4nzg5Q6s/oYe+hS+Wc=; b=A6Lc8qhLXmqb+U6Kq09KbanXbD5On1uKwmfYws68ET5SAkkgcJ7oXTRQ4bS4jojDZuiiXZ5Yc/GozYDChLbEbCdAEJlnK3WVJfuaeIA/C550F0kbora2hq38xvsXqX1WGbUsfla78wDPlDr2sBsz6P8zJ4/ZmkK1nQ9NWmnA01k= Authentication-Results: oktetlabs.ru; dkim=none (message not signed) header.d=none;oktetlabs.ru; dmarc=none action=none header.from=intel.com; Received: from PH0PR11MB5000.namprd11.prod.outlook.com (2603:10b6:510:41::19) by PH0PR11MB5208.namprd11.prod.outlook.com (2603:10b6:510:3b::16) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4608.16; Wed, 13 Oct 2021 21:08:07 +0000 Received: from PH0PR11MB5000.namprd11.prod.outlook.com ([fe80::bd7d:29be:3342:632c]) by PH0PR11MB5000.namprd11.prod.outlook.com ([fe80::bd7d:29be:3342:632c%5]) with mapi id 15.20.4608.016; Wed, 13 Oct 2021 21:08:07 +0000 Message-ID: <7bd57873-c64f-540c-59ca-b20783e86e50@intel.com> Date: Wed, 13 Oct 2021 22:08:00 +0100 Content-Language: en-US To: Ivan Malov , CC: Thomas Monjalon , Ori Kam References: <20211001134716.1608857-1-andrew.rybchenko@oktetlabs.ru> <20211013173448.28621-1-ivan.malov@oktetlabs.ru> From: Ferruh Yigit X-User: ferruhy In-Reply-To: <20211013173448.28621-1-ivan.malov@oktetlabs.ru> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-ClientProxiedBy: DB6PR0501CA0017.eurprd05.prod.outlook.com (2603:10a6:4:8f::27) To PH0PR11MB5000.namprd11.prod.outlook.com (2603:10b6:510:41::19) MIME-Version: 1.0 Received: from [192.168.0.206] (37.228.236.146) by DB6PR0501CA0017.eurprd05.prod.outlook.com (2603:10a6:4:8f::27) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4608.15 via Frontend Transport; Wed, 13 Oct 2021 21:08:05 +0000 X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: c584536c-12fc-4d9b-7bb7-08d98e8d8dd0 X-MS-TrafficTypeDiagnostic: PH0PR11MB5208: X-Microsoft-Antispam-PRVS: X-MS-Oob-TLC-OOBClassifiers: OLM:9508; X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: 4Me4frZN/jbmKuF7VKYCVre5sTIY4Xoc+TvqEbdgABodYFZFKxLxesyvsHwe9wCz7SFwx/3YCjY0fvIkSb9eB/5j6qpaIdV9sZSttYOoTEnciQPQeskq/x5zBGZKpdPoSoQeY3GvFewwMa0QuBExsDZwuqDc7FYA1rt+HV8kmgXshTmCbsMD4KcOyVi/gVvCXt1yiu7iYC6PPYr8+EEHLII0mqMBPndU0MCaHUPmriCTA/RJK4IRbb3T8fTuDoDV+Y7YLweZaQiUgJxlTLhYsrx1vKERYyVfXfpwfJdii632vGDWA4HtupEjCVaoaP6vYeQe9chQvDs8ANaHP3MVY22813ljCwj7Ze3uLl0ym/ulIr5hU97elCCViBar9wX/HI9HTppK39QHKk52+1DvvXmZ42CTv3BN8qhAemcwlZn6gWKeZrD6pHdCf1iFUOAtLpTMPgh2/d4u0uJXrI+qRp01iWkPQf8sNjtCR65wkDJvbdMvLTt/uJmXGKAqdGuP0IiLZw5YhmkGXJ+xmDMarolrasypCwQrDz4sTfzjq32cfHv6TxkQl81+tQ1g86I/Zra6eXjm7sU3U6kmJh0lJAoASMXmJgAfmWZVNjvQol+xqUE4KRkT4s7oFePMExPU0ClMElSyT8KK1lHclDW8b04UFKqDDxgGaSNzaN251/QcKFpBbb4I2mn7/HrGqAhxRxBl2tWOkL3kEfhtDUGIeA== X-Forefront-Antispam-Report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:PH0PR11MB5000.namprd11.prod.outlook.com; PTR:; CAT:NONE; SFS:(366004)(2616005)(53546011)(44832011)(4326008)(26005)(956004)(83380400001)(38100700002)(508600001)(8936002)(31696002)(66476007)(66556008)(66946007)(36756003)(8676002)(6666004)(316002)(2906002)(54906003)(186003)(86362001)(6486002)(5660300002)(16576012)(31686004)(82960400001)(45980500001); DIR:OUT; SFP:1102; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?VGhqN1U5WjVDR1N6RGxzQlM2ajhSeThtR0ZGUXlJOW41aGpROEJzYm1jTFIz?= =?utf-8?B?ZnVhQ2tYZnUrUFl3MTYrd0pEMlYxV2haSG1SU1VGYndqaHNqaHVjZDQ1aFY2?= =?utf-8?B?UXJKREVlRlN4Y1UrOURYLzlFWDY5cUh2NGIvcTh2YkN5WnVyMmtieWFLUWx5?= =?utf-8?B?STFsQUtjOEovZmZLaVozVXU5K0YyM1J1YVNCTFpYekRyUVRWSDZhaWVwek5Y?= =?utf-8?B?M0VJWFpSZzBZU01TRlJ5Uyt2cW5SbDZpbTJza3dSZzlKT1o5VGlGcHl5VzFh?= =?utf-8?B?YXdtdVJQc1h2Q3g0KzVPTHpreXFNeTY2VDdDeURpaHVHMlEzU2tNeWFBekJr?= =?utf-8?B?dThHb1lHYWlKOXVzNnpLNzgyWmFYNkNxaEdMbGIzMGVKRFB2Nk9abGFqQVIx?= =?utf-8?B?VmVGcEZrbU5hd21XYTlMSEFEc3NuNUM0WkJVUCt4TzlTYlFWSnJwekhxU1N3?= =?utf-8?B?RVpBRFQ5Kys3ZEZyZThVMGtsZThDYzZDeERkbTRVSEh1bTRzMEJnZG05Y3JB?= =?utf-8?B?WlprN0cwWTRsOS9EVit5VXBBVmlDUUJHTHpDdGZtOWVVTXNpZzdwalNjbDZo?= =?utf-8?B?cWgrcXhZUFJJRmlQTWZHd3JFSUJLYTNpT2dsREorQnVwdmY1V1RHMlRERkVM?= =?utf-8?B?SDJkcUNmN2YzSjBBYmRjMmhFZWViZWpCL2ZoeXJ1eWUydTRkWDZ3ZjM4QVlU?= =?utf-8?B?ZFRaZEg5cENZdjYxSU5BRVRENG94cHdrcWpjV2dLZUNnL3Y2d08xTmlKV3Fh?= =?utf-8?B?bVRXa2VrdXJHTjIzME5FdjRsS3IvcyswT3BuSGJUcFJNcnhtS0dmVmh3NXNM?= =?utf-8?B?TjJZYzdkWWdIN2c0THY4cDc5NGtKdVRTTThISmxtZEZoOVpRb3dZV0F4Mm5a?= =?utf-8?B?RXc2S3pGWmN3dXMwSmxyeWhTd0NOdGtGaldZTHcwVmJ3Zk95TURZNVlodnpj?= =?utf-8?B?SklvYVFTY2s2Ymhqd0xUb2pIb1k1bSsxMjcvSTdJNkZCQU5tZ2EvSTRRRWVQ?= =?utf-8?B?VmNObnFBbHdwVzFnakkwM2I3L3RCd0hyenJMcG5vMG1ZMnJWZmt6VFh0eE00?= =?utf-8?B?akJjWUNrZlAvekRsZmlEd3VIeVYyejY4SSsrYUNnT2NHM0xQVURBa2ZRZS9H?= =?utf-8?B?YlNkZDkyK0t4M04vY3VMVFp3VEwrSkNmUXBGVGdXcHpBWXRaTm9pZHVFYXQ0?= =?utf-8?B?bjhEUldCb0h4ZnRtSWtCWjZVMW4zc21HaWt5MEk1SGZBcG5aem1wM0VERlUv?= =?utf-8?B?dDhZUWcxNlRyaEF5REJDSjFoaGNFUzVxVWdxZ3lyRjd4VFY5Lzl1Tm9SV0RE?= =?utf-8?B?S1JDRnRwTW5nbVRFQ0YvMTdrUlhXY2pPOUZXeWZ4R002NXh5NEd2NEwxSk1G?= =?utf-8?B?QU4zcThqd294L1RzbDVlcWxqMUxxN05hUnQzbVpVNTZwY1djWlVsckJtN0U2?= =?utf-8?B?YURHWkNqaXNFc1I4WFI2bWhJa1BBenZ1ViszVUxrOUIwU0cxRVlwK3lzdWxX?= =?utf-8?B?YklvOWhsdmhkR2ZjWFRGVU9hZnljWGQ4bUYxSngxRjFoQS9qOStya0NTZ3B0?= =?utf-8?B?ZlR6ZkV1dGd6clZMdE00VGxvcHl4NFgzbnFmNFdoU3VaZE4yRDRhazZaU1JD?= =?utf-8?B?Q3BMVndjUGhZMmUwSWNwZW9adGZqMERZZzNtSGdYZUEyRlRsTHViUXg4RW9X?= =?utf-8?B?ZVo0YmxTNWdnSndrZEloR09MRVpJQXUyVUdFck5zNnB0TTdBVUd0bjhJMmpF?= =?utf-8?Q?HSB3+XWUZQLOHfQn3TX4KF/+bpBFvM7R2Sa3TPF?= X-MS-Exchange-CrossTenant-Network-Message-Id: c584536c-12fc-4d9b-7bb7-08d98e8d8dd0 X-MS-Exchange-CrossTenant-AuthSource: PH0PR11MB5000.namprd11.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 13 Oct 2021 21:08:07.3077 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 46c98d88-e344-4ed4-8496-4ed7712e255d X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: eJ1Qg4F5E702pZWH416D9C0iUn1hJuW8iOCg4bufh5QZkG249dhXPV0NHwUvrlxBCoKmGCD3XikA0gGCqGMxrg== X-MS-Exchange-Transport-CrossTenantHeadersStamped: PH0PR11MB5208 X-OriginatorOrg: intel.com Subject: Re: [dpdk-dev] [PATCH v7 00/12] ethdev: rework transfer flow API X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" On 10/13/2021 6:34 PM, Ivan Malov wrote: > As per RFC [1], action PORT_ID appears to be ambiguous. Its name suggests > that matching traffic be sent to the ethdev with the specified ID, that > is, to the application. However, in Open vSwitch, the action is used to > send traffic to a remote entity represented by the given port, that is, > in the opposite direction. Its interpretation across PMDs also varies. > > RFC [2] attempted to define action PORT_ID semantics in vSwitch sense. > However, this solution would completely abandon the opposite meaning. > > One more effort, RFC [3], was meant to declare that the use of direction > attributes in "transfer" flows assumed implicit filtering by the port ID > appearing as the first argument in rte_flow_create(). However, not all > PMDs require such filtering, so the RFC turned out rather disputable. > > > Since then, all of that has been given more thought: > > 1. One should not attempt to fix action PORT_ID. Instead, two new actions > should be introduced. The first one should send traffic to the given > ethdev. The second one should send it to the represented entity. > > 2. Similar to (1), two new items should be defined. The first one should > match traffic going down from the given ethdev. The second one should > match traffic going up from the entity represented by that ethdev. > > 3. The application always knows which packets come through which ethdevs. > So, as per (2), the application can use the new item to match traffic > arriving from precise entities represented by the relevant ethdev IDs. > > 4. New items suggested in (2) do not require the use of direction > attributes. These items define precise directions on their own. > > 5. As a consequence of (3) and (4), the problem of implicit filtering > by rte_flow_create() port ID argument and direction attributes is > no longer a blocker. The new items allow to dispose of it. > > > The new items appear to be symmetrical to each other. So do the new > actions. This requires that their names reflect the symmetry. Also, > the names should respect the existing concept of port representors. > By the looks of it, terms "PORT_REPRESENTOR" and "REPRESENTED_PORT" > satisfy these requirements. However, currently, ethdevs associated > with network ports are not considered as their representors. Such > understanding is mentioned in the documentation, but it's not > expressed in the code (see enum rte_eth_representor_type). > > > The short of it, this patch series follows points (1-5) to rework > support for "transfer" flows accordingly. On the way, a string of > ambiguous pattern items (PF, VF, PHY_PORT) is deprecated. > > The patch series also updates PMDs which support item and action PORT_ID > to add support for replacements (1-2). However, there're some exceptions: > > - Support for traffic source items in the case of net/mlx5 is really > complicated. This series does not rework it. The PMD maintainer > can do the job much better and test the new code accordingly; > > - Support for item REPRESENTED_PORT and both actions is not added > to net/sfc. This will be done later on, in a separate series. > > > Changes in v2: > * New naming and reworked comments > * New diagrams > > Changes in v3: > * Diagram improvements > * Spelling fixes > > Changes in v4: > * Minor adjustments as per request by Ferruh Yigit > > Changes in v5: > * Extra documentation updates in patches [01/12] through [04/12] > > Changes in v6: > * Cover letter fix > > Changes in v7: > * Order fixes in INI documentation updates > > Andrew Rybchenko (6): > net/bnxt: support meta flow items to match on traffic source > net/bnxt: support meta flow actions to overrule destinations > net/enic: support meta flow actions to overrule destinations > net/mlx5: support represented port flow action > net/octeontx2: support port representor flow action > net/sfc: support port representor flow item > > Ivan Malov (6): > ethdev: add port representor item to flow API > ethdev: add represented port item to flow API > ethdev: add port representor action to flow API > ethdev: add represented port action to flow API > ethdev: deprecate hard-to-use or ambiguous items and actions > ethdev: deprecate direction attributes in transfer flows > Series applied to dpdk-next-net/main, thanks.