From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <david.hunt@intel.com>
Received: from mga07.intel.com (mga07.intel.com [134.134.136.100])
 by dpdk.org (Postfix) with ESMTP id D23CD1B202
 for <dev@dpdk.org>; Thu, 19 Oct 2017 14:27:14 +0200 (CEST)
Received: from fmsmga005.fm.intel.com ([10.253.24.32])
 by orsmga105.jf.intel.com with ESMTP; 19 Oct 2017 05:27:13 -0700
X-ExtLoop1: 1
X-IronPort-AV: E=Sophos;i="5.43,401,1503385200"; d="scan'208";a="164499209"
Received: from dhunt5-mobl1.ger.corp.intel.com (HELO [10.237.220.44])
 ([10.237.220.44])
 by fmsmga005.fm.intel.com with ESMTP; 19 Oct 2017 05:27:12 -0700
To: Marko Kovacevic <marko.kovacevic@intel.com>, dev@dpdk.org
References: <1508405665-232195-1-git-send-email-marko.kovacevic@intel.com>
From: "Hunt, David" <david.hunt@intel.com>
Message-ID: <7bfbbc7e-20c5-c17c-d410-c176ff76e21d@intel.com>
Date: Thu, 19 Oct 2017 13:27:11 +0100
User-Agent: Mozilla/5.0 (Windows NT 10.0; WOW64; rv:52.0) Gecko/20100101
 Thunderbird/52.2.1
MIME-Version: 1.0
In-Reply-To: <1508405665-232195-1-git-send-email-marko.kovacevic@intel.com>
Content-Type: text/plain; charset=utf-8; format=flowed
Content-Transfer-Encoding: 7bit
Content-Language: en-US
Subject: Re: [dpdk-dev] [PATCH] examples/power: add turbo commands to help
	text
X-BeenThere: dev@dpdk.org
X-Mailman-Version: 2.1.15
Precedence: list
List-Id: DPDK patches and discussions <dev.dpdk.org>
List-Unsubscribe: <http://dpdk.org/ml/options/dev>,
 <mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://dpdk.org/ml/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <http://dpdk.org/ml/listinfo/dev>,
 <mailto:dev-request@dpdk.org?subject=subscribe>
X-List-Received-Date: Thu, 19 Oct 2017 12:27:16 -0000

Hi Marko,

On 19/10/2017 10:34 AM, Marko Kovacevic wrote:
> From: David Hunt <david.hunt@intel.com>
>
> Fixes: d191f0853378 ("examples/vm_power_manager: add per-core turbo CLI")
>
> Signed-off-by: Marko Kovacevic <marko.kovacevic@intel.com>
> ---
>   examples/vm_power_manager/guest_cli/vm_power_cli_guest.c | 5 +++--
>   1 file changed, 3 insertions(+), 2 deletions(-)
>
> diff --git a/examples/vm_power_manager/guest_cli/vm_power_cli_guest.c b/examples/vm_power_manager/guest_cli/vm_power_cli_guest.c
> index dc9efc2..63f711e 100644
> --- a/examples/vm_power_manager/guest_cli/vm_power_cli_guest.c
> +++ b/examples/vm_power_manager/guest_cli/vm_power_cli_guest.c
> @@ -131,8 +131,9 @@ cmdline_parse_token_string_t cmd_set_cpu_freq_cmd_cmd =
>   cmdline_parse_inst_t cmd_set_cpu_freq_set = {
>   	.f = cmd_set_cpu_freq_parsed,
>   	.data = NULL,
> -	.help_str = "set_cpu_freq <core_num> <up|down|min|max>, Set the current "
> -			"frequency for the specified core by scaling up/down/min/max",
> +	.help_str = "set_cpu_freq <core_num> "
> +			"<up|down|min|max|enable_turbo|disable_turbo>, "
> +			"adjust the frequency for the specified core.",
>   	.tokens = {
>   		(void *)&cmd_set_cpu_freq,
>   		(void *)&cmd_set_cpu_freq_core_num,

Thanks for the patch. Looks good to me.

Acked-by: David Hunt <david.hunt@intel.com>