From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id 8AD79A052B; Wed, 29 Jul 2020 16:33:34 +0200 (CEST) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id 8D6BF1BFF5; Wed, 29 Jul 2020 16:33:33 +0200 (CEST) Received: from us-smtp-delivery-1.mimecast.com (us-smtp-2.mimecast.com [205.139.110.61]) by dpdk.org (Postfix) with ESMTP id B911537B7 for ; Wed, 29 Jul 2020 16:33:31 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1596033211; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=Oq8arze99pLeYDbi2ZCKi28LHafWH7bPD/l/91vaFDI=; b=dvAHOn83RtUA+mHtpxV0ZLuOZRy5+EZR8mk7oWgJEBsmhzD99UcnrYCqH3Hg/RTTQeWf0t gqqwnF7PGag64L85/NDsMWKMG3rLWidAvuZxPPxQHR7lKkpf7Gr91cCF9O6pZfgFxC/Uoj qYgy211LdO2R2lPF6sZ8yHT6UnawKnk= Received: from mimecast-mx01.redhat.com (mimecast-mx01.redhat.com [209.132.183.4]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-114-84cZExmtM6mTnh6KLPwc4g-1; Wed, 29 Jul 2020 10:33:18 -0400 X-MC-Unique: 84cZExmtM6mTnh6KLPwc4g-1 Received: from smtp.corp.redhat.com (int-mx01.intmail.prod.int.phx2.redhat.com [10.5.11.11]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx01.redhat.com (Postfix) with ESMTPS id BA811801504; Wed, 29 Jul 2020 14:33:16 +0000 (UTC) Received: from [10.33.36.208] (unknown [10.33.36.208]) by smtp.corp.redhat.com (Postfix) with ESMTP id E1B6587B05; Wed, 29 Jul 2020 14:33:11 +0000 (UTC) To: Hemant Agrawal , David Marchand Cc: Thomas Monjalon , Sachin Saxena , "dev@dpdk.org" , Ferruh Yigit , "techboard@dpdk.org" References: <20200710171946.23246-1-hemant.agrawal@nxp.com> <20200711081716.25173-1-hemant.agrawal@nxp.com> <69e3b354-ca32-e109-8385-ffc6b973f0cc@intel.com> <11996214.pnvohz1kia@thomas> From: Kevin Traynor X-Pep-Version: 2.0 Message-ID: <7c065e8d-749f-443c-acf5-5752053209a5@redhat.com> Date: Wed, 29 Jul 2020 15:33:10 +0100 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101 Thunderbird/68.10.0 MIME-Version: 1.0 In-Reply-To: Content-Language: en-US X-Scanned-By: MIMEDefang 2.79 on 10.5.11.11 Authentication-Results: relay.mimecast.com; auth=pass smtp.auth=CUSA124A263 smtp.mailfrom=ktraynor@redhat.com X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-Content-Filtered-By: Mailman/MimeDel 2.1.15 Subject: Re: [dpdk-dev] [PATCH v3 1/8] net/dpaa: add support for fmlib in dpdk X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" Hi Hemant, On 29/07/2020 07:39, Hemant Agrawal wrote: > Hi David >=20 >> -----Original Message----- >> From: David Marchand >> Sent: Tuesday, July 28, 2020 7:12 PM >> To: Hemant Agrawal >> Cc: Thomas Monjalon ; Sachin Saxena >> ; dev@dpdk.org; Ferruh Yigit >> ; techboard@dpdk.org >> Subject: Re: [dpdk-dev] [PATCH v3 1/8] net/dpaa: add support for fmlib i= n >> dpdk >> Importance: High >> >> Hello Hemant, >> >> On Mon, Jul 20, 2020 at 6:50 AM Hemant Agrawal >> wrote: >>>> Why dropping this codebase in DPDK instead of pulling it as a >> dependency? >>> [Hemant] >I don't like seeing DPDK becoming a pile of code duplicated >> from somewhere else. >>> [Hemant] We are not using the library as it is and making some serious >> changes in the generic library to suit the DPDK use-case. >>> So, it is not possible for us to use the *original* code of fmlib, whic= h is >> public. >> >> Looking at >> https://eur01.safelinks.protection.outlook.com/?url=3Dhttps%3A%2F%2Fgith= u >> b.com%2Fqoriq-open- >> source%2Ffmlib&data=3D02%7C01%7Chemant.agrawal%40nxp.com%7Ce >> b9167f8bbd64a6234dd08d832fc01cb%7C686ea1d3bc2b4c6fa92cd99c5c301635 >> %7C0%7C0%7C637315405224811211&sdata=3D%2B65hKHyXFlWgXYq7yzZb >> lEYlI%2FyKb8OINXRuGqX8dOM%3D&reserved=3D0 which I think is the >> original code for this library (?). >> I didn't see an answer to this question - is this (https://github.com/qoriq-open-source/fmlib) the source library you are referring to below? >> Some symbols from the original code were dropped in the dpdk copy of the >> file. >> Part of the API changed, with a param pointer now being passed. >=20 > [Hemant] In DPAA1 is NXP's legacy architecture. > =20 > In the DPDK on ARM-DPAA1 (MAC is called FMAN) platforms, we have been su= pporting static FMAN configuration utility (fmc) to pre-configure the queue= s, RSS and classification rules before starting the application. This confi= g has several limitations, e.g. max DPAA_NUM_RX_QUEUES via env variable, et= c. In last few years, several customers are using it in production.=20 >=20 > The legacy Fmlib supports dynamic FMAN configuration and it removes curre= nt limitation in DPAA PMD. In order to support both modes where we can supp= ort new dynamic configuration with fmlib and static fmc mode (with parsing = facility to avoid env variables). We have done this modification in fmlib s= tructures to support both fmc parser and flow API on fmlib mode. > This param change is part of that.=20 >=20 >=20 >> The VSP symbols are in the fm_lib.c file from the original code while th= ey >> have been separated in a fm_vsp.c file in the dpdk copy. >> Some logs / comments have changed. >> > [Hemant] Yes, there is code structuring and removal of code, which we don= 't need for DPDK and ARM platforms. There are several small changes in VSP = as well as PCD (Parse Classify Distribute) configuration.=20 >=20 >> For the sake of understanding: >> - can you point at the problems with reusing this externally maintained >> library? >=20 > [Hemant] The original library was designed to work with our legacy Usersp= ace offering (USDPAA) and Bare metal offerings on PowerPC. We did tested it= initially on ARM but now largely it is only for supporting legacy custome= rs. This library is in maintenance mode.=20 >=20 > NXP don=E2=80=99t want to add any new feature in this legacy standalone l= ibrary - as it is difficult to test them on PowerPC and they can break the= legacy customers code.=20 > On ARM, we are now only offering DPDK as the Userspace solution. So, we h= ave done a branch out of the code for DPDK. > Some changes you are already seeing and there are more in development to = support DPDK style flow classification.=20 > Since DPDK is only consumer for this new base code, there is no reason fo= r creating external dependency for the DPAA PMD.=20 >=20 >> - this library is tightly linked to the fm kmod drivers I guess, how is = maintained >> the compatibility? >=20 > [Hemant] kernel module is already inbuilt in NXP Linux kernel for this pl= atform.=20 >=20 >> >> >> Thanks. >> >> -- >> David Marchand >=20