Re: [PATCH v5 0/5] add semicolon when export any symbol

[fengchengwen <fengchengwen@huawei.com>]

Hello,

On 9/8/2025 3:54 PM, David Marchand wrote:
> Hello,
> 
> On Thu, 4 Sept 2025 at 02:24, fengchengwen <fengchengwen@huawei.com> wrote:
>> On 9/3/2025 3:04 PM, David Marchand wrote:
>>> The current positionning should be seen as an additional info on the
>>> return type, in the definition of the symbol.
>>> Does it mean that this IDE would fail if we add any kind of
>>> macros/attribute involving the symbol name?
>>
>> I tried vscode and SI (source insight), and found user could use "token macro" in SI
>> to make the IDE skip such symbol (so use ctrl+ will quick jump to definition), but
>> I can't find such setting for vscode.
> 
> I asked someone who is more familiar with vscode than me (though she
> is not used to C language).
> Out of the box, this IDE could not understand C language, so she
> installed the C/C++ extension pack (version 1.3.1, on some Ubuntu).
> 
> And it seems the symbols are correctly found with current main branch.
> For example, opening only testpmd.c, rte_eal_init() mouse over shows
> the header content.
> In the same context, ctrl+clicking on rte_eal_init() in testpmd.c
> proposes to open lib/eal/linux/eal.c, with the focus on the symbol
> itself (and the RTE_EXPORT_SYMBOL macro is skipped).
> 
> Are you trying something different?

Thanks, I will check my IDE configuration.

This patchset could close I think, I will do it at patchwork later.

> 
> 
>>>
>>> Afaics, ctags can be taught to skip those macros and just behaves
>>> correctly by adding in its config file:
>>> -DRTE_EXPORT_EXPERIMENTAL_SYMBOL(a)=
>>> -DRTE_EXPORT_INTERNAL_SYMBOL(a)=
>>> -DRTE_EXPORT_SYMBOL(a)=
>>
>> How about add note in DPDK document if don't apply this commit?
> 
> We can add a generic mention that it might be necessary to configure
> the IDE, and give an example for ctags.

It could be better if have.

> 
>