From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id EF13B433F0; Tue, 28 Nov 2023 11:09:45 +0100 (CET) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id D006B40E54; Tue, 28 Nov 2023 11:09:45 +0100 (CET) Received: from NAM12-MW2-obe.outbound.protection.outlook.com (mail-mw2nam12on2074.outbound.protection.outlook.com [40.107.244.74]) by mails.dpdk.org (Postfix) with ESMTP id 1A025402C2 for ; Tue, 28 Nov 2023 11:09:44 +0100 (CET) ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=Zjl3YnS0/vQrqWCfoFCqGEhHtQisuNcuLn4kC07pD4Lhu69awdWMalK3RgL09y5vPtTTLU0OWGqneiAHDH/QdVfbJIxBGWzgtBCUhmQLdtXSJmPEUHbPWnR2ZFtXxt+aSaLg0R/s5Pb/jx0Va0iQoQUM8/kj0bS7YraTSVi6BvazQL2zcUpkEFyL+09hn+/6D33OKib6y7IaYPkeULboTheSFykx5ci5A7HWSERMMDEcOU/4bGjEL940NI/MXa4klD8OYTfrkb5gcjTxY6R5eALuqelOdhmNhsCBPbQmD8/Yeuzm6VL9FJbsZikMLaKvn/AhCi9IyDgItsFlIsM16Q== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=x2UyWH4n6ilW4ET0dIV/Vm61LSkywfCSwKiyw4k6cuk=; b=b13wIzgYSGYQQHdZmx4GjMhq88IdvPqVnlp1mEITZjAh8M2lZUbW1FfVasyNUrPuxcYzJNZXyARYnU4gvfG0txePOqZEsP2lxuJAeUU9zjm35HLtw1hTYNoZriJCj5mRlNH0m+qc0/aAOY+kmBdmEt4TMcP7p2yh3zy0JvU48i+u/aSAlwSQh7mouHv5bEnjVyUkRZf0uMTk9tc7nNZMfj2Dpe5e9p7+ZsgyluuU+vz7oNnYoPKZbJs/e5FTuEe2BGwd6TuP2vuBxdve5Tg2aS5GBJ5T0phSCeuh0zXkZ3DivB+8/JVFkwXawt2aXQu/y2b6qP8dTis7uhBMaKjUKg== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=amd.com; dmarc=pass action=none header.from=amd.com; dkim=pass header.d=amd.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=amd.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=x2UyWH4n6ilW4ET0dIV/Vm61LSkywfCSwKiyw4k6cuk=; b=GDKUySCsM+Mp6igoephiyNjQ50+cmIRUevxJMp+7qhpXHTpIH7Ak3uCC3gYeeyaGmityiOTvAJ4EJaYEISbmII/1RLYY2ZLRde0J4er3P1mESkZuDHb6nLtUoV7KmfzFc90ApZYX/fDKJPdqSX67nYGUc4wHRwYknRKFxmpuyB4= Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=amd.com; Received: from CH2PR12MB4294.namprd12.prod.outlook.com (2603:10b6:610:a9::11) by DM6PR12MB4354.namprd12.prod.outlook.com (2603:10b6:5:28f::22) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.7025.29; Tue, 28 Nov 2023 10:09:40 +0000 Received: from CH2PR12MB4294.namprd12.prod.outlook.com ([fe80::2569:edb2:670f:816f]) by CH2PR12MB4294.namprd12.prod.outlook.com ([fe80::2569:edb2:670f:816f%6]) with mapi id 15.20.7025.022; Tue, 28 Nov 2023 10:09:40 +0000 Message-ID: <7c165606-8064-41c0-82c2-51453f545577@amd.com> Date: Tue, 28 Nov 2023 10:09:34 +0000 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v3 1/6] doc: add RSS hash algorithm feature Content-Language: en-US To: "lihuisong (C)" , dev@dpdk.org Cc: liuyonglong@huawei.com, thomas@monjalon.net, Chengwen Feng , Dongdong Liu , Jie Hai References: <20231123135916.33315-1-lihuisong@huawei.com> <20231125014745.61348-1-lihuisong@huawei.com> <20231125014745.61348-2-lihuisong@huawei.com> <89b73632-8a7a-e54c-2957-04c347027c2e@huawei.com> <8968ac41-bf19-40ac-a057-aad7b46b7ca8@amd.com> <93239148-8a4d-7b3a-9e39-6659566c64dc@huawei.com> From: Ferruh Yigit Autocrypt: addr=ferruh.yigit@amd.com; keydata= xsFNBGJDD3EBEAC/M7Tk/DfQSmP1K96vyzdhfSBzlCaGtcxNXorq4fALruqVsD3oi0yfyEz9 4YN8x7py0o9EL8ZdpOX0skc0AMCDAaw033uWhCn0GLMeGRKUbfOAPvL6ecSDvGD7CJIO9j0J eZUvasBgPdM/435PEr9DmC6Ggzdzt8IuG4PoLi5jpFSfcqxZFCCxLUDEo/w0nuguk2FTuYJg B2zEZ4JTBZrw7hIHiFh8D8hr6YA6a5uTofq1tr+l048lbtdFUl8TR0aIExVzE4Z8qKZlcE+9 RQaewjK5Al1jLE4sHdmd3GN+IvgDF3D/fLsi25SKJDeGSdeHkOmaX0qGeM4WKIfU6iARRCiQ N3AmBIxZ/A7UXBKLaOyZ+/i3sE6Wb53nrO4i8+0K2Qwyh6LjTeiJAIjYKN43ppxz3DaI+QwQ vI+uyHr4Gg0Da9EPPz/YyKauSeOZCfCB5gIfICO0j6x0SCl8uQ2nLpjxcZkf0gjcwUzP3h+S 3x6NfDji9YEij0zczW/dcSpGgZ6vsFpPrtnP9ZXy6J53yp0kJtOJoOlkEFFdU2yCZnCDseum CoudmGLZVvS0/DzHDJejq+3kK3FDGktZBOxZIIpal+nFqS7lVgOZc4+huVv3jyhzoAUOEyXA XK5j6o7g8STUY+z33QNnHpdLvecMwuzmvqy0jR54yAbZ64mB9QARAQABzSNGZXJydWggWWln aXQgPGZlcnJ1aC55aWdpdEBhbWQuY29tPsLBlwQTAQgAQQIbAwULCQgHAgYVCgkICwIEFgID AQIeAQIXgAIZARYhBEm7aYjps5XGsPHCElRTPtCKKm/6BQJkdyEEBQkE3meNAAoJEFRTPtCK Km/6UdcP/0/kEp49aIUhkRnQfmKmNVpcBEs4NqceNCWTQlaXdEwL1lxf1L49dsF5Jz1yvWi3 tMtq0Mk1o68mQ7q8iZAzIeLxGQAlievMNE0BzLWPFmuX+ac98ITBqKdnUAn6ig5ezR+jxrAU 58utUszDl16eMabtCu76sINL5izB8zCWcDEUB4UqM8iBSQZ7/a7TSBVS0jVBldAORg1qfFIs cGMPQn/skhy3QqbK3u3Rhc44zRxvzrQJmhY6T1rpeniHSyGOeIYqjpbpnMU5n1VWzQ4NXvAD VDkZ4NDw6CpvF4S2h2Ds7w7GKvT6RRTddrl672IaLcaWRiqBNCPm+eKh4q5/XkOXTgUqYBVg Ors8uS9EbQC/SAcp9VHF9fB+3nadxZm4CLPe5ZDJnSmgu/ea7xjWQYR8ouo2THxqNZtkercc GOxGFxIaLcJIR/XChh9d0LKgc1FfVARTMW8UrPgINVEmVSFmAVSgVfsWIV+NSpG9/e90E4SV gMLPABn1YpJ8ca/IwqovctqDDXfxZOvCPOVWTzQe/ut767W+ctGR1kRkxWcz470SycOcY+PW VRPJd91Af0GdLFkwzZgNzkd6Gyc9XXcv4lwwqBLhWrBhqPYB0aZXIG1E/cVTiRp4dWpFHAFD DcuLldjIw93lCDsIeEDM9rBizGVMWEoeFmqSe7pzGTPXzsFNBGJDD3EBEAC8fBFQHej8qgIG CBzoIEd1cZgPIARlIhRudODXoNDbwA+zJMKtOVwol3Hh1qJ2/yZP11nZsqrP4fyUvMxrwhDe WBWFVDbWHLnqXMnKuUU1vQMujbzgq/4Rb9wSMW5vBL6YxhZng+h71JgS/9nVtzyaTtsOTrJi 6nzFSDx6Wbza2jYvL9rlK0yxJcMEiKwZQ/if4KcOesD0rtxomU/iSEv6DATcJbGXP6T93nPl 90XksijRKAmOwvdu3A8IIlxiSSVRP0lxiHOeR35y6PjHY2usfEDZZOVOfDfhlCVAIBZUZALv VmFOVSTYXeKgYa6Ooaf72+cHM3SgJIbYnevJfFv8YQW0MEAJ/IXE7B1Lk+pHNxwU3VBCrKnA fd/PTvviesuYRkrRD6qqZnINeu3b2DouVGGt2fVcGA38BujCd3p8i7azoGc7A6cgF7z9ETnr ANrbg1/dJyDmkDxOxVrVquTBbxJbDy2HaIe9wyJTEK2Sznpy62DaHVY+gfDQzexBXM10geHC IIUhEnOUYVaq65X3ZDjyAQnNDBQ4uMqSHZk8DpJ22X+T+IMzWzWl+VyU4UZXjkLKPvlqPjJk 1RbKScek5L2GhxHQbPaD76Hx4Jiel0vm2G+4wei8Ay1+0YRFkhySxogU/uQVXHTv63KzQMak oIfnN/V2R0ucarsvMBW+gwARAQABwsF8BBgBCAAmAhsMFiEESbtpiOmzlcaw8cISVFM+0Ioq b/oFAmR3IPsFCQTeZ44ACgkQVFM+0Ioqb/qINhAAtcor9bevHy22HvJvXX17IOpPSklZJAeQ Az43ZEo5kRlJ8mElc2g3RzYCvL/V3fSiIATxIsLq/MDtYhO8AAvklxND/u2zeBd7BkRZTZZX W1V1cM3oTvfx3LOhDu4f2ExQzCGdkzbXTRswSJIe1W0qwsDp+YPekbrsKp1maZArGeu+6FuW honeosIrWS98QJmscEhP8ooyJkLDCCOgEk+mJ/JBjzcJGuYn6+Iy/ApMw/vqiLGL1UWekcTA g18mREHqIR+A3ZvypIufSFB52oIs1zD/uh/MgmL62bY/Cw6M2SxiVxLRsav9TNkF6ZaNQCgn GqifliCEMvEuLZRBOZSYH2A/PfwjYW0Ss0Gyfywmb2IA990gcQsXxuCLG7pAbWaeYazoYYEQ NYmWatZNMAs68ERI2zvrVxdJ/fBWAllIEd0uQ4P05GtAHPdTIDQYp545+TPV7oyF0LfXcsQs SFVZE6igdvkjfYmh+QOrHGZvpWXLTmffVf/AQ81wspzbfxJ7sYM4P8Mg5kKOsaoUdyA/2qVe cMh1CLUHXF1GlofpGbe1lj4KUJVse5g3qwV7i9VrseA8c4VIZewdIjkzAhmmbxl+8rM/LKBH dZUMTzME5PFCXJIZ83qkZQ795MTe2YScp9dIV7fsS5tpDwIs7BZNVM1l3NAdK+DLHqNxKuyO 8Zk= In-Reply-To: <93239148-8a4d-7b3a-9e39-6659566c64dc@huawei.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit X-ClientProxiedBy: FR4P281CA0080.DEUP281.PROD.OUTLOOK.COM (2603:10a6:d10:cd::15) To CH2PR12MB4294.namprd12.prod.outlook.com (2603:10b6:610:a9::11) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: CH2PR12MB4294:EE_|DM6PR12MB4354:EE_ X-MS-Office365-Filtering-Correlation-Id: bc99e76a-c978-4d7f-6168-08dbeffa21fe X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: wt5xPYtcQfSIPlu15t67qhfHTJbFHGc1v1WECZO9uk7mFUxZTvivDRqQLvukWb6wlSh0mDBw6rojUH0P7Otdji1Klg0uRBzrORqk40Cm27laVfaiiYd8KOpZ4jrEaI/pdiMedxuirryG6Nml/Lt6bPT9HPQJwycPgup4LbZ1FM8D+8x9uSrjhSiklyhH4hvUMaLmleHTAcuF7RCMQcxk8+F1ABHPQvcj15uFghIBRX94XrGjLRdXd8T4/ubIbPoCHRFd55Da9AxWwlh8tQ5rn+QL3/hG2mtkPmNRPpQ1e6nwD2JIClei3e2iXMwrbHvQq2uJJLIgZ0ITOn7AT2cRTrrNiiBvNAdC0vlu1i+AwGtc0imo+krg3W7EYc/ZRXFqa6USTjw8sD/VY8XXKa5bBQdcFck/N7w/AmNOx2Dl3DKQSmZQFmAdRqAHNHovBhE+ib0z11n38tInX5ChAXFbNJghLHD0ssURzoxzDfD6i5FWj7SQCX03AIB7wPBBdbRJS7jm0TlGtsZuUfLRBHrvVrZvloTvH0IGJtXzkvC6491gBOnuI9LrkoQtjr8SoNDal1hjor/WvA4Okn0Gx9NgN8x6QsCGIULjiCu+09ie1J/bXtWMLMmd+IDv7q40knSrrL7cl1wpBYJBQ3NUydqsEg== X-Forefront-Antispam-Report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:CH2PR12MB4294.namprd12.prod.outlook.com; PTR:; CAT:NONE; SFS:(13230031)(396003)(376002)(136003)(346002)(366004)(39860400002)(230922051799003)(64100799003)(451199024)(186009)(1800799012)(6486002)(38100700002)(478600001)(41300700001)(8676002)(4326008)(36756003)(8936002)(54906003)(31696002)(316002)(86362001)(66476007)(66556008)(66946007)(26005)(2616005)(83380400001)(6506007)(53546011)(6666004)(6512007)(44832011)(31686004)(2906002)(5660300002)(45980500001)(43740500002); DIR:OUT; SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?anpydGZqVllSWms3UUJxY3hmZGxmZG9pQ3hCSFM4TURUNjJVdEFSMy9jZy9z?= =?utf-8?B?Tkc1NmlqVTlBVmRWQ0JhUk5ZTC9QeFBiblE3M2xUWlV0bklzZVQ2WG56N0t5?= =?utf-8?B?cjNRNUh0YkJnTXF3R1BBSWRGRUNFUjR4eXAzM3locGVrTlppQTBpakk4Z0pa?= =?utf-8?B?ZXR3a3JBYVFxR0dUYkJFenpZSFBxeW5SZ3d6UFk4ckJNN1ovdnd0RktXTkVk?= =?utf-8?B?YmlzSGI4Q2tUUWdCVTRXb25lYVBqMnZ2U0h6QVk0TExnenQ2Y3hDcTREc2ln?= =?utf-8?B?Yy9HSjl5K3dja1ZoNzdjeGNRQVNyOTlwM1NPT0hHcFFpaGhCZDNDOTBXODJi?= =?utf-8?B?RXdmSnN3dU5nUkN0Sy92ZnpTRWUvN3FseWsyUWlyczJYQVF3WGtpV2NZMitk?= =?utf-8?B?ZngzY2lhN2kwS0FWalZadWVlb2QxZldkc1pKT0lseUZYQVZZS0JPeDZkTGZV?= =?utf-8?B?cHgrUU5hWFFlemt5dHN6bXZNRGZsOG5LajhqZDlsMEN1MDBTSVpTT095ZmZ0?= =?utf-8?B?eW9kc20zdWxpU0EwWnVaZ2RrSFptZnhuY0kzemlJVkRzRnFkajBsMERXVkw3?= =?utf-8?B?Qjh6SlVsYlEzS0ZKNTZjNTNpbjB1b3V4aWE4cmo3TjBOOXNPOWdLTGdvVXFh?= =?utf-8?B?Rmc0ak9mVlpqY082b1M1UWJ3VVRSY1MwVno1VGw3Qk5HdW0yY0JDWjRPVFlK?= =?utf-8?B?Y0hCUmpxMEZ0dXlYNGt3cTh4aFc1L3NRRFVkQlBlemZGVTV6bUI1TUd6eTdM?= =?utf-8?B?S2trU2V0TkNtaXJuS3M4bkJ6aWVnbFdoUlJteWo3UTdXbHFOQk1pTEIyNmZU?= =?utf-8?B?ZEtNWEZGVDRIek5xTUxldmVWcjNRTDd6Nm1nVUU2Q05PWHpaUzF3amlSODBL?= =?utf-8?B?TXorSmlLUTNEendvTDBDY3ZaZDl5YUpUMmFuVnErd1U3dGtZMlhteU04NjVo?= =?utf-8?B?d0UwRWdTNXB2ZmN6TVV6VTZUdW5PWVBRYkllREpkQ1pQdUVHZHE0YmVZLzlU?= =?utf-8?B?TmZCdHFRMEVuU25IZjRsZG9sSUpEdGg5SElJSGpTa01QVlhzRXVsUFRqY0VS?= =?utf-8?B?eXdnM1UvZ0tYSEUzWmc0OHBHbG9xZXJTSXh2VHVOZVpiL1pCa2pkU2VBWG5W?= =?utf-8?B?YUZzQk9xam5uT1ZnWEFucVoydkRDVmZnVy8zWVppSkdndUNOd3Y1OGZFT25R?= =?utf-8?B?c3V0NElMY2k3TTRJRFBtYTB2R0hoUUlPOWpLdm53eXgrVlN5cXR5YVE0WmQ3?= =?utf-8?B?MXNCL0hHV3NoaHMyajNZWnhsbHMwRnNLVHpCU0NSa0FMREwwOTFnRXRlcWJR?= =?utf-8?B?S2Zib0RVUmdyakh6bzhraU5NTTV4Nkp4SHVFdm9pU1ROdXVsTjhJbStmRWRN?= =?utf-8?B?MXpQZ1VCbTNPR2JDRVRsWklvbENXdy9WUlBXTTByTzdtOEdQdHhianlqdmc2?= =?utf-8?B?dDlidkkyNEVSR3FPNUgyTlVCWm5pYndNcEtLM1hqNkQ5Wi96T25vTzRDTU4z?= =?utf-8?B?RGZncW5qWUVvZlNMd3pyanltZFlPbUNFUVVwMC9nUjJxU2VCRWpSNUdoNnF5?= =?utf-8?B?MkU1YWhuYVdYQ09FZUdNYVJjTThxaGRZZFVLdGZEUkhyV01NM0M4MlZJSU5W?= =?utf-8?B?d0Y4NmxMMUN2cG03eEczUnQrOElvM01kQnhVMW1TUmtQa0tnNkM1bmkvRzhu?= =?utf-8?B?dUFjZU93dTBYdGI3ajZqSzUxSUo1WER5dGZTSjNTa3Vrc1RNTUtCUzFKNEJ5?= =?utf-8?B?V3ZwaSt0bmRDeFZ3bXFMeExNMEg2dTlpMDEyVjVsVlhSRTF6d28yS05aWjdW?= =?utf-8?B?bFVEYytpakhLbFFkU3NSbVJraDJydjk5UGN5cVk0YXNTYkl2ZTRGbDc3Um9Z?= =?utf-8?B?cHpDeFZxcHA1UGUvY2dyMFNNYW1IakoxbDFFcldrRkttN3J3bnpRWWJqcEly?= =?utf-8?B?UkJFU09tYUpETnRxcDlLWTVLTnk1REo4ZUpCeVFEaExIQTVzWWpZWkhPTXE3?= =?utf-8?B?Z3dBaXFDemh3ZDE5R0U2U3ZCVW8zcjNSN3k2aldVUGZMRTdMbE1qWk9VNVlt?= =?utf-8?B?Mnl5ekQwMXZDTXZRUDJUWUo1aTIzZk85S0ZNZzhHN2RKWjhLWDlHWk1BVlA0?= =?utf-8?Q?iAdt2V2xfn3HEpoGxHRu9qve5?= X-OriginatorOrg: amd.com X-MS-Exchange-CrossTenant-Network-Message-Id: bc99e76a-c978-4d7f-6168-08dbeffa21fe X-MS-Exchange-CrossTenant-AuthSource: CH2PR12MB4294.namprd12.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 28 Nov 2023 10:09:39.8694 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 3dd8961f-e488-4e60-8e11-a82d994e183d X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: i9nTnBc3S7hHL3zGu7s+JgTfGZdXa9Mv1qYLHGN8IhosW8+1ng09COoG8W+330On X-MS-Exchange-Transport-CrossTenantHeadersStamped: DM6PR12MB4354 X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org On 11/28/2023 1:21 AM, lihuisong (C) wrote: > > 在 2023/11/27 23:43, Ferruh Yigit 写道: >> On 11/27/2023 1:12 PM, lihuisong (C) wrote: >>> 在 2023/11/27 20:19, Ferruh Yigit 写道: >>>> On 11/25/2023 1:47 AM, Huisong Li wrote: >>>>> Add hash algorithm feature introduced by 23.11 and fix some RSS >>>>> features >>>>> description. >>>>> >>>>> Fixes: 34ff088cc241 ("ethdev: set and query RSS hash algorithm") >>>>> >>>>> Signed-off-by: Huisong Li >>>>> Acked-by: Chengwen Feng >>>>> --- >>>>>    doc/guides/nics/features.rst | 26 ++++++++++++++++++++++---- >>>>>    1 file changed, 22 insertions(+), 4 deletions(-) >>>>> >>>>> diff --git a/doc/guides/nics/features.rst >>>>> b/doc/guides/nics/features.rst >>>>> index 1a1dc16c1e..0d38c5c525 100644 >>>>> --- a/doc/guides/nics/features.rst >>>>> +++ b/doc/guides/nics/features.rst >>>>> @@ -277,10 +277,12 @@ RSS hash >>>>>    Supports RSS hashing on RX. >>>>>      * **[uses]     user config**: ``dev_conf.rxmode.mq_mode`` = >>>>> ``RTE_ETH_MQ_RX_RSS_FLAG``. >>>>> -* **[uses]     user config**: ``dev_conf.rx_adv_conf.rss_conf``. >>>>> +* **[uses]     user config**: ``rss_conf.rss_hf``. >>>>> >>>> Feature title is "RSS hash", it can be two things, >>>> 1. "Receive Side Scaling" support >>>> 2. Provide RSS hash to application >>>> >>>> When this document first prepared RSS hash value was always provided to >>>> the application when RSS enabled. >>>> So intention with this feature was "Receive Side Scaling" support, >>>> hence >>>> 'RTE_ETH_MQ_RX_RSS_FLAG' added. >>>> >>>> Later providing RSS has to the application separated as optimization, >>>> 'RTE_ETH_RX_OFFLOAD_RSS_HASH' & 'RTE_MBUF_F_RX_RSS_HASH' added for this >>>> support. >>> What should I do for above two comments？ >>> To tell application how to use it? >>> >> Just tried to give some context. > got it. >>   >> >>>> As the intention of this feature is "Receive Side Scaling" support, we >>>> shouldn't reduce configuration struct to 'rss_conf.rss_hf'. >>>> >>>> Instead perhaps can expand to: >>>> 'rte_eth_conf.rx_adv_conf.rss_conf', 'rte_eth_rss_conf' >>>   I just pick their common part.😁 >>> >>> ok, will fix it. >>> >>>> >>>>>    * **[uses]     rte_eth_rxconf,rte_eth_rxmode**: >>>>> ``offloads:RTE_ETH_RX_OFFLOAD_RSS_HASH``. >>>>>    * **[provides] rte_eth_dev_info**: ``flow_type_rss_offloads``. >>>>>    * **[provides] mbuf**: ``mbuf.ol_flags:RTE_MBUF_F_RX_RSS_HASH``, >>>>> ``mbuf.rss``. >>>>> +* **[related]  API**: ``rte_eth_dev_configure``, >>>>> ``rte_eth_dev_rss_hash_update`` >>>>> +  ``rte_eth_dev_rss_hash_conf_get()``. >>>>>    >>>> ack >>>> >>>>>      .. _nic_features_inner_rss: >>>>> @@ -288,7 +290,7 @@ Supports RSS hashing on RX. >>>>>    Inner RSS >>>>>    --------- >>>>>    -Supports RX RSS hashing on Inner headers. >>>>> +Supports RX RSS hashing on Inner headers by rte_flow API. >>>>>    >>>> This should be clarified with details below, not sure if it required to >>>> limit description to rte_flow. >>> But this block like rte_flow_action_rss is from rte_flow. >>> And ethdev ops doesn't support inner RSS. >>> So I think it is ok. >>> >> Yes it is supported by rte_flow, and '[uses]' information should already >> clarify it. > Should we remove the 'rte_flow API' wrods I added in above description? > I think it can be removed. >> >>>> >>>> And I guess similar confusion exist with the providing hash to user. >>>> Need to check if rte_flow implementation puts hash to mbuf along with >>>> doing the RSS, or if it checks 'RTE_ETH_RX_OFFLOAD_RSS_HASH' offload, >>>> and update below items accordingly. >>> Do we need to tell user how to use it here? >>> I feel this document is a little simple and main to list interface for >>> user. >>> In addition, it is better that the more detail about RSS should be >>> presented  in rte_flow features. >>> >> No, I am not suggesting to add more detail. >> >> My concern is 'RTE_ETH_RX_OFFLOAD_RSS_HASH' information may not be >> correct, ethdev APIs checks offload flags, but does rte_flow >> implementation check it? > As far as I know, It is possibly verified in PMD if have or required. >> >> My suggestion is double check that piece of information and fix it if >> required. >> >> >>>> >>>>>    * **[uses]    rte_flow_action_rss**: ``level``. >>>>>    * **[uses]    rte_eth_rxconf,rte_eth_rxmode**: >>>>> ``offloads:RTE_ETH_RX_OFFLOAD_RSS_HASH``. >>>>> @@ -303,9 +305,25 @@ RSS key update >>>>>    Supports configuration of Receive Side Scaling (RSS) hash >>>>> computation. Updating >>>>>    Receive Side Scaling (RSS) hash key. >>>>>    -* **[implements] eth_dev_ops**: ``rss_hash_update``, >>>>> ``rss_hash_conf_get``. >>>>> +* **[implements] eth_dev_ops**: ``dev_configure``, >>>>> ``rss_hash_update``, ``rss_hash_conf_get``. >>>>> +* **[uses]     user config**: ``rss_conf.rss_key``, >>>>> ``rss_conf.rss_key_len`` >>>>>    * **[provides]   rte_eth_dev_info**: ``hash_key_size``. >>>>> -* **[related]    API**: ``rte_eth_dev_rss_hash_update()``, >>>>> +* **[related]    API**: ``rte_eth_dev_configure``, >>>>> ``rte_eth_dev_rss_hash_update()``, >>>>> +  ``rte_eth_dev_rss_hash_conf_get()``. >>>>> + >>>> ack >>>> >>>> There is an inconsistency in the documentation but I think it is >>>> good to >>>> use '()' when documenting API, like: 'rte_eth_dev_configure()' >>> +1 will fix it. >>>> >>>>> + >>>>> +.. _nic_features_rss_hash_algo_update: >>>>> + >>>>> +RSS hash algorithm update >>>>> +------------------------- >>>>> + >>>>> +Supports configuration of Receive Side Scaling (RSS) hash algorithm. >>>>> Updating >>>>> +RSS hash algorithm. >>>>> + >>>>> +* **[implements] eth_dev_ops**: ``dev_configure``, >>>>> ``rss_hash_update``, ``rss_hash_conf_get``. >>>>> +* **[uses]     user config**: ``rss_conf.algorithm`` >>>>> +* **[provides]   rte_eth_dev_info**: ``rss_algo_capa``. >>>>> +* **[related]    API**: ``rte_eth_dev_configure``, >>>>> ``rte_eth_dev_rss_hash_update()``, >>>>>      ``rte_eth_dev_rss_hash_conf_get()``. >>>>>      >>>> This document describes features listed in the 'default.ini', so we >>>> shouldn't have above. >>>> >>>> And I don't think RSS hash algorithm update is a big enough feature to >>>> list in the feature list, perhaps it can be embedded in the RSS support >>>> block, what do you think? >>> Yes it is not a bit feature. >>> so put it to RSS hash, right? >>> >> Yes please. >> >> .