From: 王志克 <wangzhike@jd.com>
To: 王志克 <wangzhike@jd.com>, "dev@dpdk.org" <dev@dpdk.org>
Cc: "beilei.xing@intel.com" <beilei.xing@intel.com>,
"qi.z.zhang@intel.com" <qi.z.zhang@intel.com>,
"stable@dpdk.org" <stable@dpdk.org>
Subject: Re: [dpdk-dev] [PATCH] net/i40e: fix X722 judgement when disable adminq operation
Date: Thu, 12 Mar 2020 09:13:15 +0000 [thread overview]
Message-ID: <7c1f099d2e23491fbfab751f0c392ce4@jd.com> (raw)
In-Reply-To: <1579137597-14076-1-git-send-email-wangzhike@jd.com>
Hi,
Any one to review it? I saw there is a build error on 0-day robert, but it seems environment issue (apt get failed).
Br,
Zhike Wang
JDCloud, Product Development, IaaS
------------------------------------------------------------------------------------------------
Mobile／+86 13466719566
E- mail／wangzhike@jd.com
Address／5F Building A,North-Star Century Center,8 Beichen West Street,Chaoyang District Beijing
Https://JDCloud.com
------------------------------------------------------------------------------------------------
-----Original Message-----
From: wangzk320@163.com [mailto:wangzk320@163.com] On Behalf Of Zhike Wang
Sent: Thursday, January 16, 2020 9:20 AM
To: dev@dpdk.org
Cc: beilei.xing@intel.com; qi.z.zhang@intel.com; stable@dpdk.org; 王志克
Subject: [PATCH] net/i40e: fix X722 judgement when disable adminq operation
X722 SFPs have different flavors, eg I40E_DEV_ID_SFP_X722
/I40E_DEV_ID_SFP_I_X722. So instead we use mac.type to judge
whether it is X722 or not.
Fixes: 9efa8d28b ("net/i40e: fix SFP X722 with FW4.16")
Signed-off-by: Zhike Wang <wangzhike@jd.com>
---
drivers/net/i40e/i40e_ethdev.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/net/i40e/i40e_ethdev.c b/drivers/net/i40e/i40e_ethdev.c
index 5999c96..85ccb76 100644
--- a/drivers/net/i40e/i40e_ethdev.c
+++ b/drivers/net/i40e/i40e_ethdev.c
@@ -1443,7 +1443,7 @@ static inline void i40e_config_automask(struct i40e_pf *pf)
return -EIO;
}
/* Firmware of SFP x722 does not support adminq option */
- if (hw->device_id == I40E_DEV_ID_SFP_X722)
+ if (hw->mac.type == I40E_MAC_X722)
hw->flags &= ~I40E_HW_FLAG_802_1AD_CAPABLE;
PMD_INIT_LOG(INFO, "FW %d.%d API %d.%d NVM %02d.%02d.%02d eetrack %04x",
--
1.8.3.1
next prev parent reply other threads:[~2020-03-12 9:13 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-01-16 1:19 Zhike Wang
2020-03-12 9:13 ` 王志克 [this message]
2020-03-13 4:40 ` [dpdk-dev] [dpdk-stable] " Li, Xiaoyun
2020-03-13 5:22 ` Ye Xiaolong
2020-03-13 5:57 ` Li, Xiaoyun
2020-03-13 19:16 ` Kevin Traynor
2020-03-16 2:02 ` Li, Xiaoyun
2020-03-16 10:15 ` Kevin Traynor
2020-03-17 1:35 ` Li, Xiaoyun
2020-03-18 3:25 ` 王志克
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=7c1f099d2e23491fbfab751f0c392ce4@jd.com \
--to=wangzhike@jd.com \
--cc=beilei.xing@intel.com \
--cc=dev@dpdk.org \
--cc=qi.z.zhang@intel.com \
--cc=stable@dpdk.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).