From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mx1.redhat.com (mx1.redhat.com [209.132.183.28]) by dpdk.org (Postfix) with ESMTP id 23CFD1B563 for ; Thu, 13 Dec 2018 17:42:11 +0100 (CET) Received: from smtp.corp.redhat.com (int-mx07.intmail.prod.int.phx2.redhat.com [10.5.11.22]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mx1.redhat.com (Postfix) with ESMTPS id 6CF09637FB; Thu, 13 Dec 2018 16:42:10 +0000 (UTC) Received: from [10.36.112.32] (ovpn-112-32.ams2.redhat.com [10.36.112.32]) by smtp.corp.redhat.com (Postfix) with ESMTPS id 230A61054FAE; Thu, 13 Dec 2018 16:42:04 +0000 (UTC) To: Jens Freimann , dev@dpdk.org Cc: tiwei.bie@intel.com, Gavin.Hu@arm.com References: <20181213123453.15035-1-jfreimann@redhat.com> <20181213123453.15035-10-jfreimann@redhat.com> From: Maxime Coquelin Message-ID: <7c5564bb-1a8b-73d6-54cb-a2069b97b615@redhat.com> Date: Thu, 13 Dec 2018 17:42:02 +0100 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:60.0) Gecko/20100101 Thunderbird/60.2.1 MIME-Version: 1.0 In-Reply-To: <20181213123453.15035-10-jfreimann@redhat.com> Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: 7bit X-Scanned-By: MIMEDefang 2.84 on 10.5.11.22 X-Greylist: Sender IP whitelisted, not delayed by milter-greylist-4.5.16 (mx1.redhat.com [10.5.110.28]); Thu, 13 Dec 2018 16:42:10 +0000 (UTC) Subject: Re: [dpdk-dev] [PATCH v12 09/10] net/virtio-user: ctrl virtqueue not supported with packed vqs X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 13 Dec 2018 16:42:11 -0000 It seems check-git-log.sh returns an error for this one. On 12/13/18 1:34 PM, Jens Freimann wrote: > Until we have support for ctrl virtqueues let's disable it and > exit if specified as a parameter. > > Signed-off-by: Jens Freimann > --- > drivers/net/virtio/virtio_user/virtio_user_dev.c | 8 ++++++-- > 1 file changed, 6 insertions(+), 2 deletions(-) > > diff --git a/drivers/net/virtio/virtio_user/virtio_user_dev.c b/drivers/net/virtio/virtio_user/virtio_user_dev.c > index 697ba4ae8..f9b83c423 100644 > --- a/drivers/net/virtio/virtio_user/virtio_user_dev.c > +++ b/drivers/net/virtio/virtio_user/virtio_user_dev.c > @@ -467,10 +467,14 @@ virtio_user_dev_init(struct virtio_user_dev *dev, char *path, int queues, > if (!in_order) > dev->unsupported_features |= (1ull << VIRTIO_F_IN_ORDER); > > - if (packed_vq) > + if (packed_vq) { > + if (cq) > + rte_exit(EXIT_FAILURE, > + "control vq not supported with packed virtqueues\n"); Sorry if I wasn't clear, but you should return -1 and not exit the application using the DPDK lib. > dev->device_features |= (1ull << VIRTIO_F_RING_PACKED); > - else > + } else { > dev->device_features &= ~(1ull << VIRTIO_F_RING_PACKED); > + } > > if (dev->mac_specified) { > dev->device_features |= (1ull << VIRTIO_NET_F_MAC); >