From: "lihuisong (C)" <lihuisong@huawei.com>
To: Kamil Vojanec <vojanec@cesnet.cz>
Cc: <dev@dpdk.org>, Chas Williams <chas3@att.com>,
"Min Hu (Connor)" <humin29@huawei.com>,
Stephen Hemminger <stephen@networkplumber.org>
Subject: Re: [PATCH v2 1/2] net/bonding: introduce direct link bonding mode
Date: Fri, 13 Dec 2024 10:37:17 +0800 [thread overview]
Message-ID: <7c639448-5fe7-2d22-143d-1d8da497c46d@huawei.com> (raw)
In-Reply-To: <20241212100750.53d62777@hermes.local>
在 2024/12/13 2:07, Stephen Hemminger 写道:
> On Fri, 12 Apr 2024 14:27:39 +0200
> Kamil Vojanec <vojanec@cesnet.cz> wrote:
>
>> This patch adds a new bonding mode: 'direct'. The purpose of this mode
>> is to redirect output packets to the same member port on which they were
>> received. In case the requested port is not among the member ports,
>> round robin TX mode is used as a fallback.
>>
>> Signed-off-by: Kamil Vojanec <vojanec@cesnet.cz>
>> ---
> This patch appears stuck. It is introducing a special new mode which really
> doesn't exactly fit the normal use of a bonding type device.
I also reviewed this patch before.
The 'direct' mode is just to let the packets from one port send out at
the same port.
It doesn't seem to have anything to do with bonding, because application
also can do it.
In addition, it is not a well-known bonding mode and has no plan on
Linux kernel.
If it is needed, I agree with Stephen's proposal that using transmit
policy callback.
>
> Could the bonding maintainers review please.
> .
prev parent reply other threads:[~2024-12-13 2:37 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-04-12 12:27 Kamil Vojanec
2024-04-12 12:27 ` [PATCH v2 2/2] doc/prog_guide: document " Kamil Vojanec
2024-07-05 11:27 ` [PATCH v2 1/2] net/bonding: introduce " Ferruh Yigit
2024-12-04 22:21 ` Stephen Hemminger
2024-07-10 3:49 ` lihuisong (C)
2024-07-10 5:16 ` Kamil Vojanec
2024-12-03 18:18 ` Stephen Hemminger
2024-12-12 18:07 ` Stephen Hemminger
2024-12-13 2:37 ` lihuisong (C) [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=7c639448-5fe7-2d22-143d-1d8da497c46d@huawei.com \
--to=lihuisong@huawei.com \
--cc=chas3@att.com \
--cc=dev@dpdk.org \
--cc=humin29@huawei.com \
--cc=stephen@networkplumber.org \
--cc=vojanec@cesnet.cz \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).