From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id A35FA45E48; Fri, 13 Dec 2024 03:37:27 +0100 (CET) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 360F240263; Fri, 13 Dec 2024 03:37:27 +0100 (CET) Received: from szxga05-in.huawei.com (szxga05-in.huawei.com [45.249.212.191]) by mails.dpdk.org (Postfix) with ESMTP id 7865A4003C for ; Fri, 13 Dec 2024 03:37:25 +0100 (CET) Received: from mail.maildlp.com (unknown [172.19.163.17]) by szxga05-in.huawei.com (SkyGuard) with ESMTP id 4Y8YQ5381vz1JFBR; Fri, 13 Dec 2024 10:37:01 +0800 (CST) Received: from dggemv703-chm.china.huawei.com (unknown [10.3.19.46]) by mail.maildlp.com (Postfix) with ESMTPS id 620A01A0188; Fri, 13 Dec 2024 10:37:18 +0800 (CST) Received: from kwepemn100009.china.huawei.com (7.202.194.112) by dggemv703-chm.china.huawei.com (10.3.19.46) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.1.2507.39; Fri, 13 Dec 2024 10:37:18 +0800 Received: from [10.67.121.59] (10.67.121.59) by kwepemn100009.china.huawei.com (7.202.194.112) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.2.1544.11; Fri, 13 Dec 2024 10:37:17 +0800 Message-ID: <7c639448-5fe7-2d22-143d-1d8da497c46d@huawei.com> Date: Fri, 13 Dec 2024 10:37:17 +0800 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:91.0) Gecko/20100101 Thunderbird/91.2.0 Subject: Re: [PATCH v2 1/2] net/bonding: introduce direct link bonding mode To: Kamil Vojanec CC: , Chas Williams , "Min Hu (Connor)" , Stephen Hemminger References: <20240412122740.104121-1-vojanec@cesnet.cz> <20241212100750.53d62777@hermes.local> From: "lihuisong (C)" In-Reply-To: <20241212100750.53d62777@hermes.local> Content-Type: text/plain; charset="UTF-8"; format=flowed Content-Transfer-Encoding: 8bit X-Originating-IP: [10.67.121.59] X-ClientProxiedBy: dggems703-chm.china.huawei.com (10.3.19.180) To kwepemn100009.china.huawei.com (7.202.194.112) X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org 在 2024/12/13 2:07, Stephen Hemminger 写道: > On Fri, 12 Apr 2024 14:27:39 +0200 > Kamil Vojanec wrote: > >> This patch adds a new bonding mode: 'direct'. The purpose of this mode >> is to redirect output packets to the same member port on which they were >> received. In case the requested port is not among the member ports, >> round robin TX mode is used as a fallback. >> >> Signed-off-by: Kamil Vojanec >> --- > This patch appears stuck. It is introducing a special new mode which really > doesn't exactly fit the normal use of a bonding type device. I also reviewed this patch before. The 'direct' mode is just to let the packets from one port send out at the same port. It doesn't seem to have anything to do with bonding, because application also can do it. In addition, it is not a well-known bonding mode and has no plan on Linux kernel. If it is needed, I agree with Stephen's proposal that using transmit policy callback. > > Could the bonding maintainers review please. > .