From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id C50DCA00C5; Thu, 15 Sep 2022 12:02:05 +0200 (CEST) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 6692F4021D; Thu, 15 Sep 2022 12:02:05 +0200 (CEST) Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) by mails.dpdk.org (Postfix) with ESMTP id D45CE40156 for ; Thu, 15 Sep 2022 12:02:03 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1663236123; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=0ew82F8i10JHhSGT8/H1fLPoIuobyBJhWcCVRMvGSwI=; b=Xv1ylZ8Ng5xxlRiPutyoBQk4OejnG9qdRns5rj2Vj6lTMIrfA/75mGDJ6MJS3tUAji+uHZ 2pUxiO1Y0bK6GEsNTebLHtrc2JSTR3xdOvPX1NG2qK0BaAKUKGqYCR8aW69Xoccdhlr5ZS kjfxHH9NIWevdg4YBGjr+Sa5g8uL0Fc= Received: from mimecast-mx02.redhat.com (mimecast-mx02.redhat.com [66.187.233.88]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id us-mta-650-TBboR1GpMP6WFCH9dxB3ow-1; Thu, 15 Sep 2022 06:02:00 -0400 X-MC-Unique: TBboR1GpMP6WFCH9dxB3ow-1 Received: from smtp.corp.redhat.com (int-mx03.intmail.prod.int.rdu2.redhat.com [10.11.54.3]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx02.redhat.com (Postfix) with ESMTPS id B87AB8027F5; Thu, 15 Sep 2022 10:01:59 +0000 (UTC) Received: from [10.39.208.12] (unknown [10.39.208.12]) by smtp.corp.redhat.com (Postfix) with ESMTPS id 7BB691121314; Thu, 15 Sep 2022 10:01:58 +0000 (UTC) Message-ID: <7c63b3ff-3dda-e005-764e-6b0731075083@redhat.com> Date: Thu, 15 Sep 2022 12:01:57 +0200 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101 Thunderbird/91.12.0 Subject: Re: [PATCH v2 20/37] baseband/acc100: check turbo dec/enc input To: Hernan Vargas , dev@dpdk.org, gakhil@marvell.com, trix@redhat.com Cc: nicolas.chautru@intel.com, qi.z.zhang@intel.com References: <20220820023157.189047-1-hernan.vargas@intel.com> <20220820023157.189047-21-hernan.vargas@intel.com> From: Maxime Coquelin In-Reply-To: <20220820023157.189047-21-hernan.vargas@intel.com> X-Scanned-By: MIMEDefang 3.1 on 10.11.54.3 X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Language: en-US Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org On 8/20/22 04:31, Hernan Vargas wrote: > Add NULL check for the turbo decoder and encoder input length. > Looks like a fix, please add Fixes tag and cc stable. > Signed-off-by: Hernan Vargas > --- > drivers/baseband/acc100/rte_acc100_pmd.c | 23 ++++++++++++++++++----- > 1 file changed, 18 insertions(+), 5 deletions(-) > > diff --git a/drivers/baseband/acc100/rte_acc100_pmd.c b/drivers/baseband/acc100/rte_acc100_pmd.c > index deb2cb6d36..70a29f92a1 100644 > --- a/drivers/baseband/acc100/rte_acc100_pmd.c > +++ b/drivers/baseband/acc100/rte_acc100_pmd.c > @@ -2398,6 +2398,11 @@ validate_enc_op(struct rte_bbdev_enc_op *op, struct acc100_queue *q) > return -1; > } > > + if (turbo_enc->input.length == 0) { > + rte_bbdev_log(ERR, "input length null"); > + return -1; > + } > + > if (turbo_enc->code_block_mode == RTE_BBDEV_TRANSPORT_BLOCK) { > tb = &turbo_enc->tb_params; > if ((tb->k_neg < RTE_BBDEV_TURBO_MIN_CB_SIZE > @@ -2417,11 +2422,12 @@ validate_enc_op(struct rte_bbdev_enc_op *op, struct acc100_queue *q) > RTE_BBDEV_TURBO_MAX_CB_SIZE); > return -1; > } > - if (tb->c_neg > (RTE_BBDEV_TURBO_MAX_CODE_BLOCKS - 1)) > + if (tb->c_neg > 0) { > rte_bbdev_log(ERR, > - "c_neg (%u) is out of range 0 <= value <= %u", > - tb->c_neg, > - RTE_BBDEV_TURBO_MAX_CODE_BLOCKS - 1); > + "c_neg (%u) expected to be null", > + tb->c_neg); > + return -1; > + } > if (tb->c < 1 || tb->c > RTE_BBDEV_TURBO_MAX_CODE_BLOCKS) { > rte_bbdev_log(ERR, > "c (%u) is out of range 1 <= value <= %u", > @@ -3320,6 +3326,11 @@ validate_dec_op(struct rte_bbdev_dec_op *op, struct acc100_queue *q) > return -1; > } > > + if (turbo_dec->input.length == 0) { > + rte_bbdev_log(ERR, "input length null"); > + return -1; > + } > + > if (turbo_dec->code_block_mode == RTE_BBDEV_TRANSPORT_BLOCK) { > tb = &turbo_dec->tb_params; > if ((tb->k_neg < RTE_BBDEV_TURBO_MIN_CB_SIZE > @@ -3340,11 +3351,13 @@ validate_dec_op(struct rte_bbdev_dec_op *op, struct acc100_queue *q) > RTE_BBDEV_TURBO_MAX_CB_SIZE); > return -1; > } > - if (tb->c_neg > (RTE_BBDEV_TURBO_MAX_CODE_BLOCKS - 1)) > + if (tb->c_neg > (RTE_BBDEV_TURBO_MAX_CODE_BLOCKS - 1)) { > rte_bbdev_log(ERR, > "c_neg (%u) is out of range 0 <= value <= %u", > tb->c_neg, > RTE_BBDEV_TURBO_MAX_CODE_BLOCKS - 1); > + return -1; > + } > if (tb->c < 1 || tb->c > RTE_BBDEV_TURBO_MAX_CODE_BLOCKS) { > rte_bbdev_log(ERR, > "c (%u) is out of range 1 <= value <= %u", With Fixes tag: Reviewed-by: Maxime Coquelin Thanks, Maxime