From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id B29FE45697; Tue, 23 Jul 2024 18:04:48 +0200 (CEST) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 5B32E42EAA; Tue, 23 Jul 2024 18:04:46 +0200 (CEST) Received: from mgamail.intel.com (mgamail.intel.com [198.175.65.16]) by mails.dpdk.org (Postfix) with ESMTP id 7364142E36; Tue, 23 Jul 2024 18:04:44 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1721750684; x=1753286684; h=message-id:date:subject:to:cc:references:from: in-reply-to:mime-version; bh=hepXjT26IAZJg516JE1ZwQQYBCkkal2/OTOf874Uq2M=; b=Og/EDuT40VenRf1MrEffdVfY8Ucd0hIbJJy9imN6kFwgg61JQvlatjDo FwDd0F2yGBOaILS0AVkyWgsNtIbaginiU+OpqYmMN+fnr5ByJZoA7BjsJ G8LibxowTbQuN1IsE99Hd89qyIsmzJDEFY+U9Si9Xy78MFC3k5Z875nYx KeLLavYXZPj3JgC+NiVXMIbNECaPLf8TppvRDrY4Xc0CkOXPKb4stp/Le cY2tXGhbBXs8p6VVoeOxBaIvlNpnbTe22yGwTJFqVwtoZ2qZgvGQPsa+e LMSvclAP+aPI1chO51xPRtsgqkck7axwKEk7pV3AW4UhXjVUWsWWilmr8 w==; X-CSE-ConnectionGUID: KQ0stZAJTLqwIctd+mM41g== X-CSE-MsgGUID: NfR7va29RXikfJQxHGMIig== X-IronPort-AV: E=McAfee;i="6700,10204,11142"; a="19521877" X-IronPort-AV: E=Sophos;i="6.09,230,1716274800"; d="scan'208,217";a="19521877" Received: from orviesa005.jf.intel.com ([10.64.159.145]) by orvoesa108.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 23 Jul 2024 09:04:43 -0700 X-CSE-ConnectionGUID: mmU2aug9SjiUiYF8UCTJ1w== X-CSE-MsgGUID: U8tN2v2gS0OkYByijDQ8kA== X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="6.09,230,1716274800"; d="scan'208,217";a="57118972" Received: from orsmsx603.amr.corp.intel.com ([10.22.229.16]) by orviesa005.jf.intel.com with ESMTP/TLS/AES256-GCM-SHA384; 23 Jul 2024 09:04:43 -0700 Received: from orsmsx611.amr.corp.intel.com (10.22.229.24) by ORSMSX603.amr.corp.intel.com (10.22.229.16) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.39; Tue, 23 Jul 2024 09:04:42 -0700 Received: from orsmsx601.amr.corp.intel.com (10.22.229.14) by ORSMSX611.amr.corp.intel.com (10.22.229.24) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.39; Tue, 23 Jul 2024 09:04:42 -0700 Received: from orsedg603.ED.cps.intel.com (10.7.248.4) by orsmsx601.amr.corp.intel.com (10.22.229.14) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.39 via Frontend Transport; Tue, 23 Jul 2024 09:04:42 -0700 Received: from NAM11-BN8-obe.outbound.protection.outlook.com (104.47.58.169) by edgegateway.intel.com (134.134.137.100) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.1.2507.39; Tue, 23 Jul 2024 09:04:31 -0700 ARC-Seal: i=1; a=rsa-sha256; s=arcselector10001; d=microsoft.com; cv=none; b=wQcwhBwdnG9kpcQokk4nu5DVmea3nruopNFiEZ9cCU52RV4xgnIgjl3rPO04TROYFe5ng3UmQ7kjmgHe5zBdtDKIK5Tb5Z3lh6WJ4Q83CIPekQCVWM7XVVv6SnAKurSgtMADCZu3/Mfn39a9ENtZ37067Hwq3snYXvi4N4l1WqH+NM0TWnIFwvwXXublW/s/0orZORwiuTQ6lFcjOWaI4mF7gsQLbBS/gh1SpDb6+YxbVo9K8DqEIfYqxgwZpYAVMrvb/lE9bnaCe1BqPV4huCWu3Ooe2NWTvqkPvXHW4SnoHSE4cCwsurB9JL30QgjtSSTMbZkIsXojjYGHhYJHrA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector10001; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=yDo0IcSp7FZqJ1dpTfGKXor0di9FtTGdp+VnNTKdrN8=; b=T3mQBR5wEZQ2vCCoc1ekEhXZspQumR4ewzzEOQQoi0jnAJAhGYaXoyMFzfVyb0eykUqr4Jrpt+aNmpE8RFiioyAjiJpYxD0knYoxsd6yc5g+E93hf9aKvBErxOOSZDq36s1o494OnV3Ds00A8yPw530AT3Sa2oy81LvPtAVmw3uPqRkJQKEHscYbkBJp/DkMMMbnnrr23WLfoPFuMKbsNJK0tTmD12VJkFdDsVuiUvMQZpaaanjDO1CEnNZ0hQXlOVkc0te+3rh/ivEAulWnS3p7bWA7fYQsv64bLhVxEnK+drxN478yXmqdS88gtKLEfcKTOTCd9QmmQkVS9DV7GA== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=intel.com; dmarc=pass action=none header.from=intel.com; dkim=pass header.d=intel.com; arc=none Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=intel.com; Received: from SJ0PR11MB5772.namprd11.prod.outlook.com (2603:10b6:a03:422::8) by CO1PR11MB5089.namprd11.prod.outlook.com (2603:10b6:303:9b::16) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.7784.19; Tue, 23 Jul 2024 16:04:26 +0000 Received: from SJ0PR11MB5772.namprd11.prod.outlook.com ([fe80::5851:319:3da6:850b]) by SJ0PR11MB5772.namprd11.prod.outlook.com ([fe80::5851:319:3da6:850b%4]) with mapi id 15.20.7762.020; Tue, 23 Jul 2024 16:04:26 +0000 Content-Type: multipart/alternative; boundary="------------TMoiCITwiLQx5VvJVOb0ZNGI" Message-ID: <7c690dcb-8824-452e-85d5-7f665ff56246@intel.com> Date: Tue, 23 Jul 2024 17:04:18 +0100 User-Agent: Mozilla Thunderbird Subject: Re: [EXTERNAL] [PATCH v2] examples/ipsec-secgw: fix SA salt endianness problem To: Akhil Goyal , Chaoyong He , "dev@dpdk.org" , Anoob Joseph , "Nithin Kumar Dabilpuram" , Gagandeep Singh , Kai Ji , "radu.nicolau@intel.com" , Brian Dooley , "Jack Bond-Preston" , "pablo.de.lara.guarch@intel.com" , "hemant.agrawal@nxp.com" , "suanmingm@nvidia.com" CC: "oss-drivers@corigine.com" , Shihong Wang , "stable@dpdk.org" References: <20240311024939.2523778-2-chaoyong.he@corigine.com> <20240314020052.3107549-1-chaoyong.he@corigine.com> Content-Language: en-US From: "Medvedkin, Vladimir" In-Reply-To: X-ClientProxiedBy: DU2PR04CA0224.eurprd04.prod.outlook.com (2603:10a6:10:2b1::19) To SJ0PR11MB5772.namprd11.prod.outlook.com (2603:10b6:a03:422::8) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: SJ0PR11MB5772:EE_|CO1PR11MB5089:EE_ X-MS-Office365-Filtering-Correlation-Id: b44bb9a5-3fbc-4f73-d076-08dcab312019 X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; ARA:13230040|1800799024|366016|376014|7416014|921020; X-Microsoft-Antispam-Message-Info: =?utf-8?B?K0xPNFR3b1pjWTF3MlVHejdaQmgxWEMxNG5CS29uOUtCRVdIdFkrTFRSZFBp?= =?utf-8?B?NHN1b2x1ZU53VktIUGFXenhGZVZKMFo2YlFydW1maDg3ZDJMd0VnTmlIVDg3?= =?utf-8?B?M0l2L2ZTQmJMeWxPV09LRVdTSm0rWXBOL1g3MUE4WUtpODU2bGtDMVZmczA3?= =?utf-8?B?eVd3K0hPK2lvQVNNQk1JL3krL2s4YkZQckFUVS9TaEpxOFhEblNqSVZrNmdh?= =?utf-8?B?WnorMWtvTGlwOFBwR0NnUmFXOWFwVGNsbnVlM0pUQk1vUkRxbjVVQzRGK1VP?= =?utf-8?B?VnU1enpGeHo4TzJ2blhJQnRpVW55T2VZMVZKdkkxKzdWME4xb3JBc1YwbUhV?= =?utf-8?B?RXJ3bEVBVE9GVHVsQkNEcGZmNDBsU3lNYzhYRXUzV0Z4bXd0d0JqcVFvRm9S?= =?utf-8?B?bFRJbXphK1FTQ043bFBwa0kxSjh6UUwySHdocUdIeHlxdzF0S2l3b0FmaWZk?= =?utf-8?B?VUgwVTE3djYvL1pub1FTRzlQUXJzQnB5T1NWbFZCQ2lvWSswQkcvcTN0dmJG?= =?utf-8?B?K3FWT21vazl2cGdQcE9FVlhLbTBFMFE3cDZtbURqQXpITHJJRjZZUjNBeEhZ?= =?utf-8?B?YzBxN20vOC9UZWZiN0F3UGhOOWVWbmJnRlVsSVZZQ0FXTDFnWG5MSmQ3d0pG?= =?utf-8?B?NzFpMTFQSVFUK1ZPNnpkeUFnTFRldWZyeUx2TnloREErMXNTbkdGVkpUOEd4?= =?utf-8?B?c1I3d0xXck5JNHpNdlYxOG9IUCt3U3k2MlBPZjVkYVFFUWl1R1g4UGd5aHFT?= =?utf-8?B?MS9XK3Z2T0dFTzlwUlMwV29KTi9TWmdMaHYwQzduUTVGMDlOMmVYWEw5WTAz?= =?utf-8?B?dXNlVnlsRE1LQzhCQ2NrdkhIK1l5d0V0Y09qZmJjamcxbFhrdml1Qnd0VnR6?= =?utf-8?B?M1BzL0xwUFQvZHFIblNWNmo4dWZqZjV2dThvK2VrWnJldGJaSkppcmdZMDFJ?= =?utf-8?B?T0lUWE5yOWFIVHVXZWIwM2tCN3pRdTUvTXlnT0ppZnV1blRTM2FHNUUwaVpN?= =?utf-8?B?SzFuM1lyUGFNSDRiVGNzSThTNVFBRUVSQmlJOVNjZjV1MkErSE8wRGdJdSta?= =?utf-8?B?MGtSZUNTaTR2eVFJQkw1RDhvU3psV1dBY0xmUkdqc0xJemswVXRIOXI3ZmxT?= =?utf-8?B?VW1sa1QwQ2Iybjd5Vm00Y3BSd1hKMisrUVIwNWVHaUpHanFkU0RzVXVLUXVx?= =?utf-8?B?NVQyMWF2R2k2ZlgwUDY3SE5zSGI4SFdLbmxrNFQvaFFtN1hzNFRIelQ4cndV?= =?utf-8?B?MUFNeFkzVnJvU3QzN2RYWjJrdzkrNFRkckdtd0d5RjdiNHdJalcwSnU0elox?= =?utf-8?B?MWlyZTFBbkJrYS9mTnJLdW5rK1dyTzlUVy84Qi9GTldualY1ejdDUEZyaHVU?= =?utf-8?B?ZTJQdU9uT3hpS2Y0OEVEYUt3ZEpndW93c1NkSU9ybDgyR011dCtmUVh5NWhD?= =?utf-8?B?UVVpT1Bic291N3ptYklSYk1rM1dlRmVKV1RXMGUyMEs3NXQya2poN3pob3JC?= =?utf-8?B?bS8vbm5HWHpqcmJxdy9BY2orZ0hTSTk1bTArL2FJUGttTU9aWEY2UE55enlh?= =?utf-8?B?d05yaEhRZVZJSGd3OHFKYXVHaEY2cCsrdWVYYTdmQzdkbzJnbDJYalFqUk9h?= =?utf-8?B?LzVCZVVrbG5saDY0UjNMeHFyY3lEcmhrejFtY3pFL2JtOEM0UjU5bDJhMHJW?= =?utf-8?B?ZlQzVVQySTZQNGkyY3FVZ0RaM2ZvOGJoVlFvZmpKRDdaTGxpb0RyUTlLOFMz?= =?utf-8?B?NUlQTHpmUG5hNGxsWVBrdHd2UTNaZWwyV2l3SW1DYkF1bmUyRUtWTWNaYTQ0?= =?utf-8?B?anlZSHNJeHFRSWVqamlHUHhFQis5VnZ5ZFFNYTVWTFlyNGRtaGtIQjR2TktK?= =?utf-8?Q?1oA0asGY3EFBF?= X-Forefront-Antispam-Report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:SJ0PR11MB5772.namprd11.prod.outlook.com; PTR:; CAT:NONE; SFS:(13230040)(1800799024)(366016)(376014)(7416014)(921020); DIR:OUT; SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?emJqbEFGWldXYlFlMmxmaXphMEdTemhPalRyMTFVaVlTaTRLaWJRSkhsM3R2?= =?utf-8?B?YTl2YU5SRHpmMlNiaDVFLzhmL3gxTUNlTlZFSU50Vjc5QmkrOEZFZnRqU1hK?= =?utf-8?B?ZlNkeGZvbGhhWnVrMXZSTlJiNmRJMmlKdk1WSDZjbkR0WGNrdExDQXBhZ1pL?= =?utf-8?B?S1N2NGF3c3Z5cEhLQXYwSzR1WWRTYTN2eFc4SGFhV0h6bGszWGdJdzdDQVFh?= =?utf-8?B?Ylp1KzZKd0VqRGk1RVlsbnhOVXVpUUh0UVQ2L1BGY3cxaTRrbXFvdmUvUHdT?= =?utf-8?B?VmsvUGF4eTM5WWwwUk5kNmdpQk1mR1daTGNVejdIQkVITHZvVnpkeDYrYi9L?= =?utf-8?B?S3F6dHh4aGd6cDJKbWcvQktySVFSeWlCZ1Y0MTZCSXpEYVgwdmZaSjB6cE5t?= =?utf-8?B?M0tEdTd0OW9mOUxlSktGV2Vhc3BXUEJqa2dkNnF5cThiMmN1czRLWkI2Y2lp?= =?utf-8?B?blhCYnBwMEVQL21iNGEzWExJenhIeGZxdmh2ZCt4SENvNWdFaENtZEE4d25p?= =?utf-8?B?SS9KbWw1MXYzbE9LNmRKazZicEd5STQzMHU2NVFleG5wRmdzTHVXT1V4cmVZ?= =?utf-8?B?bGZZTEdMTlIrcGQyS2ROcVpXcVR1OCtZMFJnbTNpbDlKVGtGbk9FcEZTdDlZ?= =?utf-8?B?ZkRwemlOWTRTVTNwZmhEVlBpM2VjbmZldXNFYXJDYm1kK2tnV0JhVFJ4WExX?= =?utf-8?B?SDVrckFacFlBUk9SaGdNMkdya0JDb3o0cjkxUTE1YlQxUDJscFNVSUxPd2VD?= =?utf-8?B?ekRudHFCUVFFSHUrK1YyQ3dpQzlEeUF6d1NDMEdZaTJzY21LQ1lFUXlZN3FG?= =?utf-8?B?QnFWQ1JscHJhQzE0WlppSXVlU0QwYWhDU2xVMlIxdGM3RHJnM3pQSTkyQUtY?= =?utf-8?B?WFV0TlVyUzgzSndueG5ISk1KbUtVbFUrUUhCeHd4aGdhYXIxVE1UY3RlTTcx?= =?utf-8?B?bktMclpPUUg2MlcrSjdET3d5Y2grL3lUdjB2R2x2TmFBVkc4OXB2RXl3ZVNs?= =?utf-8?B?TkZMS1F3eStkS1YvdHJrMEpUd0JNVk5ERldqRnRiVXlWVWRPYWV0V2JibzRt?= =?utf-8?B?V2JyN0w2OTFmakZialBHNzR4UnVvTnlFSXg3Q1VwRXhCU01pYkhBRDNrUG1P?= =?utf-8?B?YTVnWmIwcEVSVkhsaFlGclZjSXc2bnRVeUhiUlVLZXQ4aDY0clRjVTlTc29u?= =?utf-8?B?K1VOaFgwZjIyRWFMNUJmQkQ3OG5Wd0VVYVFoVzFXR3ZVc3JYc1lhNkRkZnkx?= =?utf-8?B?TVoybHNTL1NydUswNjFQUFV6K2NqbzA5VzlqQXliZnJzOUVuV2xCMGcyaytV?= =?utf-8?B?RVZ3V1hVb3pFeExud3dzOTR3N2Y4bnVkKzVpTmJhd3hUMzN4T3BuMG9RTytu?= =?utf-8?B?MHBsYjdDTi8zMGRKYWxteDhQU1lnNmlyUE9VMXQ2aVJhdzBBUmQrRUtUaGxO?= =?utf-8?B?Z2tzU0svczFpeVo0c2c4ZWlvc0FlWHNIWGo1R1ZQSUI3VnBWMElPejJLNkZT?= =?utf-8?B?bEFSQU52UzF3OWtGLzNHczU1Nnh4VHRNeG15a1lVazhKNnpMdWk2Z3N2d000?= =?utf-8?B?Q2w1SEZzYld2UFhsWXlnMFpMcE42d28zdG5ZclZaSlNzOWJOelRmNkhnV3dV?= =?utf-8?B?RmZQYzJXL0Z1SUFGbyt4ZjVNWXgreElXR3o0R21aOFp0YmVNei9DMXRzMmJs?= =?utf-8?B?M0pVaitwWldNT3NIelNTVjN3MFB1K0NYaEZRYlc2c3UxbmprMUpuTGFDOFJv?= =?utf-8?B?dUdlY3IvcUQ5bzVvK0VaaC9ob0N2MkRNamcyVmgrS0VTNGtMcm5UcDBOdE5B?= =?utf-8?B?MkpRSzJrWndrZFc3bnlmY3drS1RyVVZCQWo5anpwRFhvcktCOTFVaUJ5RGR3?= =?utf-8?B?c29FY0ZFTVpJVEthYTE4bWppY055b0g2NTNDN3FMRUxUWmZsL1FCK25HbFlp?= =?utf-8?B?azRTUEt4VkRzdDRSc2FuOVBGSEo1aVkyMWpFTEtwR2tiVDNSc3cvY1ZDNk81?= =?utf-8?B?emdjUzRLYmU4akgyYS9YdFR5cnAvd012NDA2Q21kTEg1aHhOYmtmNS9UV0hY?= =?utf-8?B?MU9hRW5uclY3S0VYUFdFN0lESHBQeDMzdlJaZU9kc0RzRmxsMzVTWkNxRklp?= =?utf-8?B?L1RTZnlGQ24yTGptajloakgzU2RPTjh3ZzFqM21kS2lvcWN4dENQVEV4eUFh?= =?utf-8?B?UXc9PQ==?= X-MS-Exchange-CrossTenant-Network-Message-Id: b44bb9a5-3fbc-4f73-d076-08dcab312019 X-MS-Exchange-CrossTenant-AuthSource: SJ0PR11MB5772.namprd11.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 23 Jul 2024 16:04:26.2976 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 46c98d88-e344-4ed4-8496-4ed7712e255d X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: Brz2l2nseE3vVNSZKvRLt4rQmVzA1I6rcpLN/IlUrzTqGO+CSCm1v41afBiqmcWSL/k9eMTH+M8qJm/a4h6Dn7WBHwLxmyJI427GtBxGmnc= X-MS-Exchange-Transport-CrossTenantHeadersStamped: CO1PR11MB5089 X-OriginatorOrg: intel.com X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org --------------TMoiCITwiLQx5VvJVOb0ZNGI Content-Type: text/plain; charset="UTF-8"; format=flowed Content-Transfer-Encoding: 8bit Hi all, This patch breaks ipsec tests with ipsec-secgw: ./examples/ipsec-secgw/test/run_test.sh -4 trs_aesctr_sha1 ... ERROR: ./examples/ipsec-secgw/test/linux_test.sh failed for dst=192.168.31.14, sz=1  test IPv4 trs_aesctr_sha1 finished with status 1 ERROR  test trs_aesctr_sha1 FAILED On 03/07/2024 18:58, Akhil Goyal wrote: > >> -----Original Message----- >> From: Akhil Goyal >> Sent: Friday, March 15, 2024 12:42 AM >> To: Akhil Goyal; Chaoyong He >> ;dev@dpdk.org >> Cc:oss-drivers@corigine.com; Shihong Wang; >> stable@dpdk.org >> Subject: RE: [EXTERNAL] [PATCH v2] examples/ipsec-secgw: fix SA salt >> endianness problem >> >>> Subject: RE: [EXTERNAL] [PATCH v2] examples/ipsec-secgw: fix SA salt >>> endianness problem >>> >>>> From: Shihong Wang >>>> >>>> The SA salt of struct ipsec_sa is a CPU-endian u32 variable, but it’s >>>> value is stored in an array of encryption or authentication keys >>>> according to big-endian. So it maybe need to convert the endianness >>>> order to ensure that the value assigned to the SA salt is CPU-endian. >>>> >>>> Fixes: 50d75cae2a2c ("examples/ipsec-secgw: initialize SA salt") >>>> Fixes: 9413c3901f31 ("examples/ipsec-secgw: support additional algorithms") >>>> Fixes: 501e9c226adf ("examples/ipsec-secgw: add AEAD parameters") >>>> Cc:stable@dpdk.org >>>> >>>> Signed-off-by: Shihong Wang >>>> Reviewed-by: Chaoyong He >>>> >>> Acked-by: Akhil Goyal >>> >>> Applied to dpdk-next-crypto >> The patch is pulled back from dpdk-next-crypto. >> This change may cause all the PMDs to fail these cases. >> Would need acks from PMDs. > Applied to dpdk-next-crypto > No update from PMD owners. > Applying it before RC2 so that we have time for fixes if needed. > -- Regards, Vladimir --------------TMoiCITwiLQx5VvJVOb0ZNGI Content-Type: text/html; charset="UTF-8" Content-Transfer-Encoding: 8bit

Hi all,

This patch breaks ipsec tests with ipsec-secgw:

./examples/ipsec-secgw/test/run_test.sh -4 trs_aesctr_sha1
...
ERROR: ./examples/ipsec-secgw/test/linux_test.sh failed for dst=192.168.31.14, sz=1
 test IPv4 trs_aesctr_sha1 finished with status 1
ERROR  test trs_aesctr_sha1 FAILED


On 03/07/2024 18:58, Akhil Goyal wrote:


-----Original Message-----
From: Akhil Goyal <gakhil@marvell.com>
Sent: Friday, March 15, 2024 12:42 AM
To: Akhil Goyal <gakhil@marvell.com>; Chaoyong He
<chaoyong.he@corigine.com>; dev@dpdk.org
Cc: oss-drivers@corigine.com; Shihong Wang <shihong.wang@corigine.com>;
stable@dpdk.org
Subject: RE: [EXTERNAL] [PATCH v2] examples/ipsec-secgw: fix SA salt
endianness problem


Subject: RE: [EXTERNAL] [PATCH v2] examples/ipsec-secgw: fix SA salt
endianness problem


From: Shihong Wang <shihong.wang@corigine.com>

The SA salt of struct ipsec_sa is a CPU-endian u32 variable, but it’s
value is stored in an array of encryption or authentication keys
according to big-endian. So it maybe need to convert the endianness
order to ensure that the value assigned to the SA salt is CPU-endian.

Fixes: 50d75cae2a2c ("examples/ipsec-secgw: initialize SA salt")
Fixes: 9413c3901f31 ("examples/ipsec-secgw: support additional algorithms")
Fixes: 501e9c226adf ("examples/ipsec-secgw: add AEAD parameters")
Cc: stable@dpdk.org

Signed-off-by: Shihong Wang <shihong.wang@corigine.com>
Reviewed-by: Chaoyong He <chaoyong.he@corigine.com>


Acked-by: Akhil Goyal <gakhil@marvell.com>

Applied to dpdk-next-crypto

The patch is pulled back from dpdk-next-crypto.
This change may cause all the PMDs to fail these cases.
Would need acks from PMDs.

Applied to dpdk-next-crypto
No update from PMD owners.
Applying it before RC2 so that we have time for fixes if needed.


-- 
Regards,
Vladimir
--------------TMoiCITwiLQx5VvJVOb0ZNGI--