From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id 1B90AA04F3; Mon, 16 Dec 2019 12:21:58 +0100 (CET) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id B43191BF91; Mon, 16 Dec 2019 12:21:57 +0100 (CET) Received: from mga12.intel.com (mga12.intel.com [192.55.52.136]) by dpdk.org (Postfix) with ESMTP id BE36B1BF87 for ; Mon, 16 Dec 2019 12:21:56 +0100 (CET) X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from orsmga008.jf.intel.com ([10.7.209.65]) by fmsmga106.fm.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 16 Dec 2019 03:21:53 -0800 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.69,321,1571727600"; d="scan'208";a="209272096" Received: from klaatz-mobl1.ger.corp.intel.com (HELO [10.237.221.89]) ([10.237.221.89]) by orsmga008.jf.intel.com with ESMTP; 16 Dec 2019 03:21:50 -0800 To: Bruce Richardson , dev@dpdk.org Cc: thomas@monjalon.net, ray.kinsella@intel.com, ferruh.yigit@intel.com, bluca@debian.org References: <20191211102642.983579-1-bruce.richardson@intel.com> <20191212115826.2167871-1-bruce.richardson@intel.com> From: "Laatz, Kevin" Message-ID: <7c788baa-c304-6042-327f-5ea00e0e1d0c@intel.com> Date: Mon, 16 Dec 2019 11:21:50 +0000 User-Agent: Mozilla/5.0 (Windows NT 10.0; WOW64; rv:60.0) Gecko/20100101 Thunderbird/60.9.1 MIME-Version: 1.0 In-Reply-To: <20191212115826.2167871-1-bruce.richardson@intel.com> Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: 7bit Content-Language: en-US Subject: Re: [dpdk-dev] [PATCH v3] build: fix soname info for 19.11 compatiblity X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" On 12/12/2019 11:58, Bruce Richardson wrote: > The soname for each stable ABI version should be just the ABI version major > number without the minor number. Unfortunately both major and minor were > used causing version 20.1 to be incompatible with 20.0. > > This patch fixes the issue by switching from 2-part to 3-part ABI version > numbers so that we can keep 20.0 as soname and using the final digits to > identify the 20.x releases which are ABI compatible. This requires changes > to both make and meson builds to handle the three-digit version and shrink > it to 2-digit for soname. > > The final fix needed in this patch is to adjust the library version number > for the ethtool example library, which needs to be upped to 2-digits, as > external libraries using the DPDK build system also use the logic in this > file. > > Fixes: cba806e07d6f ("build: change ABI versioning to global") > > Signed-off-by: Thomas Monjalon > Signed-off-by: Bruce Richardson > --- Patch also tested with new Meson ABI checks (see http://patches.dpdk.org/project/dpdk/list/?series=7830) Tested-by: Kevin Laatz