Re: [dpdk-dev] [PATCH] lib/cryptodev: remove RTE_LIBRTE_CRYPTODEV_DEBUG

[Akhil Goyal <akhil.goyal@nxp.com>]

Please remove lib from subject also.


On 6/21/2018 7:41 PM, Akhil Goyal wrote:
> Hi Jananee,
>
>
> On 6/12/2018 12:08 PM, Jananee Parthasarathy wrote:
>> For librte_cryptodev dynamic logging,
>> conditional compilation of debug logs would not be required anymore.
>
> I believe this shall also be removed from config/common_base and
> lib/librte_eal/common/include/rte_dev.h as nobody is using it.
>
> -Akhil
>
>>
>> Signed-off-by: Jananee Parthasarathy 
>> <jananeex.m.parthasarathy@intel.com>
>> Reviewed-by: Reshma Pattan <reshma.pattan@intel.com>
>> ---
>>   lib/librte_cryptodev/rte_cryptodev.h | 8 --------
>>   1 file changed, 8 deletions(-)
>>
>> diff --git a/lib/librte_cryptodev/rte_cryptodev.h 
>> b/lib/librte_cryptodev/rte_cryptodev.h
>> index 92ce6d49a..229712ebf 100644
>> --- a/lib/librte_cryptodev/rte_cryptodev.h
>> +++ b/lib/librte_cryptodev/rte_cryptodev.h
>> @@ -65,7 +65,6 @@ extern const char **rte_cyptodev_names;
>>           RTE_FMT(RTE_FMT_HEAD(__VA_ARGS__,) "\n", \
>>               RTE_FMT_TAIL(__VA_ARGS__,)))
>>   -#ifdef RTE_LIBRTE_CRYPTODEV_DEBUG
>>   #define CDEV_LOG_DEBUG(...) \
>>       RTE_LOG(DEBUG, CRYPTODEV, \
>>           RTE_FMT("%s() line %u: " RTE_FMT_HEAD(__VA_ARGS__,) "\n", \
>> @@ -76,13 +75,6 @@ extern const char **rte_cyptodev_names;
>>           RTE_FMT("[%s] %s: " RTE_FMT_HEAD(__VA_ARGS__,) "\n", \
>>               dev, __func__, RTE_FMT_TAIL(__VA_ARGS__,)))
>>   -#else
>> -#define CDEV_LOG_DEBUG(...) (void)0
>> -#define CDEV_PMD_TRACE(...) (void)0
>> -#endif
>> -
>> -
>> -
>>   /**
>>    * A macro that points to an offset from the start
>>    * of the crypto operation structure (rte_crypto_op)
>