From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from EUR03-DB5-obe.outbound.protection.outlook.com (mail-eopbgr40057.outbound.protection.outlook.com [40.107.4.57]) by dpdk.org (Postfix) with ESMTP id 5982A1BB3E for ; Thu, 21 Jun 2018 16:13:05 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=nxp.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=0uF/j021T2RiJHlzNwgEbANwuUMk1p5jCJjacAX27Eg=; b=YcppNsfdvlKUSAn3H/PJc3boIzRx/ZQSqmSSteTeCMIbgPPh34kErPySGCHW/0o46oHU0FLvmNDwgwSVM2TE6dneCguyUbkk6MO+oVZ+KbuP8oATqknfDU57JUlYPRTMYAnM1R0Ag0YeyRB5l7LN0ItmoOFqhvjax0gYgbiF8Fc= Authentication-Results: spf=none (sender IP is ) smtp.mailfrom=akhil.goyal@nxp.com; Received: from [10.232.134.144] (14.142.187.166) by AM3PR04MB1378.eurprd04.prod.outlook.com (2a01:111:e400:536a::16) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.884.20; Thu, 21 Jun 2018 14:13:03 +0000 From: Akhil Goyal To: Jananee Parthasarathy , dev@dpdk.org Cc: pablo.de.lara.guarch@intel.com, reshma.pattan@intel.com References: <1528785534-23425-1-git-send-email-jananeex.m.parthasarathy@intel.com> <32f96244-0b7f-17ff-9cc0-8e8955b8904e@nxp.com> Message-ID: <7c8dc199-9d02-e23a-05e1-0f0666149275@nxp.com> Date: Thu, 21 Jun 2018 19:42:50 +0530 User-Agent: Mozilla/5.0 (Windows NT 10.0; WOW64; rv:52.0) Gecko/20100101 Thunderbird/52.8.0 MIME-Version: 1.0 In-Reply-To: <32f96244-0b7f-17ff-9cc0-8e8955b8904e@nxp.com> Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: 8bit Content-Language: en-US X-Originating-IP: [14.142.187.166] X-ClientProxiedBy: BM1PR0101CA0054.INDPRD01.PROD.OUTLOOK.COM (2603:1096:b00:19::16) To AM3PR04MB1378.eurprd04.prod.outlook.com (2a01:111:e400:536a::16) X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: dcd7c315-a60a-43d4-7e81-08d5d7811ab0 X-MS-Office365-Filtering-HT: Tenant X-Microsoft-Antispam: UriScan:; BCL:0; PCL:0; RULEID:(7020095)(4652020)(4534165)(7168020)(4627221)(201703031133081)(201702281549075)(5600026)(711020)(48565401081)(2017052603328)(7153060)(7193020); SRVR:AM3PR04MB1378; X-Microsoft-Exchange-Diagnostics: 1; AM3PR04MB1378; 3:Gl5rvyYftWxDXi3ZAOc6bk2RPT1u5KD2KUUjCXJ/oTDK1XDoGlfzwGiBgaNzQlehekHQSHyIBGBHu+0x7Ph7VdwA0+X1tZrUGN+mEXjV9nqXKCjUpFz0wEkm5DRuGEXo8LGwWISJJ/sraWVlnLnzgNNMZsa6h0uB3wyX7XWTYzF88eu6fiMxtrPhbxgNtlWU4iViEn6T0pB+WC6yQZ2w+U5+E6ITghK0WxeodKZlnNgAaUAR/nOLxdIGgMDpxALW; 25:g7waPromSLRqSuHkHacVrgm5dW4yP0UxTriCr5DFiI20t66lJHcpsRAQ25E+Tvs+iznTINiNXwqfGYT1ZNosXeY3y9l2abCnYcD+2uWmhyQ5mLOiGIcDFd/X1YGYko23pTp88RPgNkmLflYKUj3iar90uDZeaM2tArc9w1VKJB1qKaUdWTX0ClQ6cN86AavJqwi3vDbnGVjcm0O7XaK6PTEWaBzuFL47LexIDDYiICJwmi7vKGKegEEUtBdnfKD6VNlBHZ20IhxBfa63EMnaMk3l2Gbb43w2/ybCJp9G7+lNIHfwQ9nfx0AwNBC9kNnhmDInKN4PVANwyp4nPL4BXA==; 31:nlUXQgDKjkC3JnIsY1iqOfV2G+gbsGbALyTuSSaPPnBBGHQIPRWcL0/IYbOaBBTTlv1A1QFykOXOb7S+eYzrWbWNZV+Y0jY+TFwFgPruG5RaEKl09GuY3H+zzD6R1V+H3mB4K2qe3t7Xy1Z7usxCbDE0ZHgjim0hJzRy/KkmN9Pi/nVOOs3ZEoJeHOj20hrDLr4Xw5/+Ju2tGR/63juHv+E7D2x/gNEwQWu/UdcE6Uw= X-MS-TrafficTypeDiagnostic: AM3PR04MB1378: X-Microsoft-Exchange-Diagnostics: 1; AM3PR04MB1378; 20:F1JffejKllJGRN3iC6Dd/eAbV1tI7UuXBJdA7+iH1QcrEYDLHr1BrAZmpW4sFWAAfoKfbjVC+5Q0RoNk1nKUtdDQ3o/atz/P51KghYgRmeRpQQZAEAfBf2KzYQEG+C1xwqwp+DjHXzTvnnxnbEG1l7AIAnDSqGqKnlplZXINPwDyi98LbXwgPMvEsMfxnaSnSDERvvMg+yVqr851HNxAAi7HtS6skgHCTG378t+2GXHkMka1eIeUcyRHXH/UQttAoyviRcxJtDdfiuNQIahvNZxhjww7S3XZ6yMRdUEblWn2QcZRN5VHlsyby0gNR7Vc8Uc5/mDVq83cb+FYJUOjje2zFTRukA84TGyDpJgIfJWB5Kj8C1ggxB0359CxsloqIKokF66cJPfZYiDCdk1ESplCpWm2AEIYW0Vq1Sd4AQErJ1v/d8knpNpXuZRdiQlsjKNaQM70hYnosk37ruBmXbDWKbfDA14UY/dV5xaxpjn1zbnoj4vkaQd/+4H3siGR; 4:QZjk+5gBYgZQDb7Tvvf04zaJqG2yYFXgPnhdxRU4XWEjdLyI/Fm2NIBNB4Co623qjUzf/QjumABnjWknAjZiwul+qGwSGkdOxN7nUbFi3WABweyOa99z0xonF3Ce482pPvO8pKTM6wPDTFmaioSDPztP0MMdTKH0doaYDWDZJRFL+pfWHSfwMrD/JLzvePunXWym1abA6eakzWuuYakeocxh71dyLX94tqoORRC2Ty/kwXO93pDc3I4YtQ7gq7hv29p+W0QOuWEtNmCERHxgnSNXiAreGKVFNiy7bCvweMvmV5wWzAWPOhjp8NdyfsU6 X-Microsoft-Antispam-PRVS: X-Exchange-Antispam-Report-Test: UriScan:(228905959029699); X-MS-Exchange-SenderADCheck: 1 X-Exchange-Antispam-Report-CFA-Test: BCL:0; PCL:0; RULEID:(8211001083)(6040522)(2401047)(5005006)(8121501046)(93006095)(93001095)(3231254)(944501410)(52105095)(10201501046)(3002001)(6055026)(149027)(150027)(6041310)(20161123558120)(20161123562045)(20161123564045)(20161123560045)(201703131423095)(201702281528075)(20161123555045)(201703061421075)(201703061406153)(6072148)(201708071742011)(7699016); SRVR:AM3PR04MB1378; BCL:0; PCL:0; RULEID:; SRVR:AM3PR04MB1378; X-Forefront-PRVS: 07106EF9B9 X-Forefront-Antispam-Report: SFV:NSPM; SFS:(10009020)(6049001)(346002)(376002)(396003)(39860400002)(39380400002)(366004)(199004)(189003)(64126003)(6486002)(8936002)(229853002)(11346002)(16526019)(5009440100003)(446003)(186003)(77096007)(956004)(2616005)(26005)(476003)(81166006)(53936002)(8676002)(58126008)(16576012)(486006)(81156014)(53546011)(6116002)(386003)(3846002)(55236004)(50466002)(67846002)(2870700001)(36756003)(316002)(6246003)(2906002)(44832011)(25786009)(86362001)(52116002)(97736004)(31696002)(76176011)(68736007)(2486003)(3260700006)(52146003)(23676004)(305945005)(31686004)(7736002)(4326008)(47776003)(5660300001)(65956001)(65826007)(65806001)(66066001)(6666003)(105586002)(478600001)(106356001)(110426005); DIR:OUT; SFP:1101; SCL:1; SRVR:AM3PR04MB1378; H:[10.232.134.144]; FPR:; SPF:None; LANG:en; PTR:InfoNoRecords; A:1; MX:1; Received-SPF: None (protection.outlook.com: nxp.com does not designate permitted sender hosts) X-Microsoft-Exchange-Diagnostics: =?utf-8?B?MTtBTTNQUjA0TUIxMzc4OzIzOm1MUzVKM0hmVVkwMVpxMk1MZXRkTUdWYlRq?= =?utf-8?B?SnNzN0o4dlJidzE4WDM1QnVkcVZOdlByV2tOQ2pQUG50Tkk3RTJTY2VtMmNK?= =?utf-8?B?Z1k5K0VuUkZWNFJwZzF2clVKUzB6NXgzM1E3RHZrZWlZZXYvcnNYdkg5dWYz?= =?utf-8?B?OWh4RjlsTWY5MVpRUnluSU9kVlBhdzVTVXlITEZEV2k1SmkrSjhvTkhrWkdI?= =?utf-8?B?OHFTczdLeU5NenZyNlRHNmtoRVBtZExSOFlHS3diZ3hFS2pVVmZBRFQ4MStI?= =?utf-8?B?S1d2MU1tU1RMeFdlQlJjRjRCR1JlM2VKT0RoaGI3aWZyU3ExbisvbExoemk3?= =?utf-8?B?Z0NqNjg1QndVWHgwSVRNR2pkbnJtVk55YWlpblVhQ01zOTVxRG44bzdsZmd3?= =?utf-8?B?Q2luUUdrN25yVFhrc2Z6cUU3eEFzdldDbEJhMmI1TFBmN2lRYW5lRDBQcUc4?= =?utf-8?B?UDZJcFl1eXJjYmFqMlB5d1Z3eUovSWhydDVwenZ0TDFMOFFTQmlLTVlOd25E?= =?utf-8?B?SzcvVjRjaEY5R01CMGtVUFVuMWtrK2lyUXhrMytSbDk5NGlLOEtCK2RtZlJh?= =?utf-8?B?Y0R6cW1tRlRtdlBUWjFyNDlER0FRRHNua2hBVW1lcFExMWZTOUtaV0Jibzd6?= =?utf-8?B?NU11SGkyL29iL2h4cXYzbGFSSE1kZkc5UnFlSWVjWWUxQ28xOGFHVEpqbzd1?= =?utf-8?B?TUNFbnpWa1dNME1qLzMyMmcwRkYybHc5ZzdTc1lMQzUwN0FhdlNFa3BWWCtj?= =?utf-8?B?RkdSelpBM1UyZFJpako2LytTL1orY2pta29wOGkxallPNk9XV1IyNWR5VFJp?= =?utf-8?B?NzJSTkEyV2lUZ2tsc0RnamNxZjFIV3Z3azhUa3pnV1FWRzloaHZXaisvODZH?= =?utf-8?B?MU9TZGVvVzF4b1h3ek1MaENEQ24yQ3M3cWhFZ3pWSUFBaldaSVNGOHRyRFlK?= =?utf-8?B?cUowOW9VL1hSYS9nRVM0NFVGZFVCVDk0anFtRGw1RVNDTFA4TGd4WGlqRTlS?= =?utf-8?B?M01CSFgzeStBckZqUmZ4THNRUGMvOUJFeG4rY2ZOUStGOTJlT0VHVjF1bjA5?= =?utf-8?B?Wk5aaG4yTm83T3Q5a1RvcU0rN25TeGM5VVllVmt5cmFGY1NRVFZVc1VIajhR?= =?utf-8?B?UjJVMFVKN1VLOEZUdnUxL2thZWFyTlQxTnU0bHRJaXYvRFZKTWlQUFo4MVg3?= =?utf-8?B?NzdGaThDVHM1dldzTDhBVkZncnA0bkhrWUZ1QW10MG5DQ3VRMHcvcnY1UFg4?= =?utf-8?B?eXczQzRxOHg5TnJ4UzNLMWFFWVJibGRxMk92MnBMaWdqaklsdVJWdnlHSEMx?= =?utf-8?B?YmRPRDFBYWRPdXNHMkJXellXTWprd052K2hpS1FMSVJHaE1aR1NScno1U2Vy?= =?utf-8?B?N0dWLyt5Um1BcVFLY0tLdytBYXZHenBVN2YrL1NVTTlUOTQrOHZCaE1ZVlYw?= =?utf-8?B?M21MNEJHNUZaN01FandSNmx1YWhwYWRIRVdVTHNmNGpCYVBWaHBEbW41U0NR?= =?utf-8?B?U0swUUNrUU9zd3J6SmZTeUEwWjhyM2FNeko5ZE9BUmdCczNtS0dCQTFkUGl3?= =?utf-8?B?ZTZCdUxybTRRNkV3V2duNTluaEdPSFYvaXFnbDVVM1lRYzgwOEh3MCtzR1Vs?= =?utf-8?B?ZEYwUXh0TGt2SEtZMnRGTXZveXBWUHgwN3p5bXJwRW1XaDBtcW01cVRESVQ0?= =?utf-8?B?ZjZqNWJNbEd1S0lrSjVxWmZZOUxwcHZLM1FWcWpqYjBDVUY5eVRoR2prVFpq?= =?utf-8?B?eTVNaUZoUVJnODBzclZnb2N3NnR4dlp5NDFsaHJXSlJrTUtyZ2xYSDhlUTd4?= =?utf-8?B?YXFNNktXRDZzUHpoRGNJemtUTzd4K2RhTFA0Q2dveXpNTlE4aFdxL0NXdXVt?= =?utf-8?B?Y2RQeXZIMWlocTNSZTl0a0JyUW1iQ1ZhS1NIVkNZQ2VJNW9JTXdaaUJqbU85?= =?utf-8?B?ZnczUTk4MlIxMDBHR21JM0o0WXpHaVY3dzRmUmp0TENpbFdvejJjT09oQ0dN?= =?utf-8?B?d1ozSW1KUDdxSUs5VXdnKy96ZjlONjRkbjhoMFlUNmV3bC9UL2x5LzFpOUdl?= =?utf-8?B?VEVCWUlsS2RnRUpGaytIckFzUklCZTRJVWF3dUZZR004ZmJNWmw4d2htK2lu?= =?utf-8?B?Ync9PQ==?= X-Microsoft-Antispam-Message-Info: eMLFoarn/RuSH192CrclB1xo1V0S45op4/vNM+VVPN7eA3XVtyelEvnf+iCdhR1J1n6SOvzG7DRi1X9cq+tu9cSjXSlD58otZPTXESuJf0U3GJYof0yvXpop3nbdUKRqd23yjq4Y2lPFVRFlsHqHJWUyZO/tekKhX+OhpiF44FNoelMV3lxw+CSfCqM+7SE3kw0c1omN5xkEdFSJIMleenexjJS1YQg67JntzsOQ2WnhuBjyqkoTtudfvmdiTWje1k3u97zgQHMFLlWVpKhtr5jP9lSUaBY/RwVqZs4h/HcBGbdd5INxXlDLvtLSfM12YzGsVIvQJdb1WWm8Od/wvA== X-Microsoft-Exchange-Diagnostics: 1; AM3PR04MB1378; 6:SY5LbNC9rQEBtj4EY7xBQ5fWYY0ryhudN3tI9tQoC76Vg8pEjMjY7niIpVaHiiicsG1S7E/dLOXsWd0RNN4hK5zfX4QVIfPhTUF06V6Xy83RYUSvxJUBAaMrdDl0P89h3gGlZvGdOUPFvT2PQkUgQNnTpSiAR+CAUnqao9UQ50sT6uYJLV0qFWNigKwPHoxFPv4pZggzmoDLDuePCph22K8nB2m3qfSGsTFSomM+m/Mz7O04QdPzCiy+B9KWEgxMiWrnhgeKHOLLABJtYOZiQ/Q5zHAtgD077CfOxkZezXJw/6xOJY+iesNCLPMKCZ6QPCW78WsWxl4mW6YR2Etlc+JD2qQOG4HkRwr1m1BqDFx9pTg38lN5ZmbeFn7FGiNTmpbmpFIbwG3SiwLX1qa0w4od/Kbn8CULXv4dSnpbAaRqb2B4BgkgFPUZ/8lIKq+myGHBFncZu6cNU+lLGACxLg==; 5:TWIpVEwQrncShRgQBMwWuinMd//6FiOvB+exT/fokTwWzetpsN+yJK27Zs17QtVo4o1vC4xQIKdHpjca8g3eb4dhGif0EhY4G1huheEoHcOqpCUfyHsjjfP+uKFllR2z3ggCYL+yKo4gIf/EUIB5zDxkoZ5D1Gexyx6e7hJgA8Q=; 24:QwT1x3yPYbCJ8AAzRM8x4+tYnm0S98JT+gfQo9r+hoVfAuz4Vbc1WAS8PowpeTzBwX319ExdFymFW/VAuLXz0+pWqC+OZ6TXS1zVDrmsb9k= SpamDiagnosticOutput: 1:99 SpamDiagnosticMetadata: NSPM X-Microsoft-Exchange-Diagnostics: 1; AM3PR04MB1378; 7:lBR9yGWBBr6dM5TfEsFtJ/EkUpAk8ksKqZNSQVqqq/mrb8tvoiWb0a8Vx5+BcBucNRzb02Zs4QDX9cKcjPxhnxAO9tbJqcRFWJwqEY3KkuAXpwIRcilMqYvlziedSh7t+a6W5S7js/DR6UYkQOxvX1rZ2gt/NxVUkhxVIzmKrRFYoL2X5d28TNHuIHy1khPEOS5W7w6XhveyktQefVcvRQgMTBrKfe1scmM/zVtS+c4j4AJSMCXCU+2xsIKamY5y X-OriginatorOrg: nxp.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 21 Jun 2018 14:13:03.2101 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: dcd7c315-a60a-43d4-7e81-08d5d7811ab0 X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 686ea1d3-bc2b-4c6f-a92c-d99c5c301635 X-MS-Exchange-Transport-CrossTenantHeadersStamped: AM3PR04MB1378 Subject: Re: [dpdk-dev] [PATCH] lib/cryptodev: remove RTE_LIBRTE_CRYPTODEV_DEBUG X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 21 Jun 2018 14:13:05 -0000 Please remove lib from subject also. On 6/21/2018 7:41 PM, Akhil Goyal wrote: > Hi Jananee, > > > On 6/12/2018 12:08 PM, Jananee Parthasarathy wrote: >> For librte_cryptodev dynamic logging, >> conditional compilation of debug logs would not be required anymore. > > I believe this shall also be removed from config/common_base and > lib/librte_eal/common/include/rte_dev.h as nobody is using it. > > -Akhil > >> >> Signed-off-by: Jananee Parthasarathy >> >> Reviewed-by: Reshma Pattan >> --- >>   lib/librte_cryptodev/rte_cryptodev.h | 8 -------- >>   1 file changed, 8 deletions(-) >> >> diff --git a/lib/librte_cryptodev/rte_cryptodev.h >> b/lib/librte_cryptodev/rte_cryptodev.h >> index 92ce6d49a..229712ebf 100644 >> --- a/lib/librte_cryptodev/rte_cryptodev.h >> +++ b/lib/librte_cryptodev/rte_cryptodev.h >> @@ -65,7 +65,6 @@ extern const char **rte_cyptodev_names; >>           RTE_FMT(RTE_FMT_HEAD(__VA_ARGS__,) "\n", \ >>               RTE_FMT_TAIL(__VA_ARGS__,))) >>   -#ifdef RTE_LIBRTE_CRYPTODEV_DEBUG >>   #define CDEV_LOG_DEBUG(...) \ >>       RTE_LOG(DEBUG, CRYPTODEV, \ >>           RTE_FMT("%s() line %u: " RTE_FMT_HEAD(__VA_ARGS__,) "\n", \ >> @@ -76,13 +75,6 @@ extern const char **rte_cyptodev_names; >>           RTE_FMT("[%s] %s: " RTE_FMT_HEAD(__VA_ARGS__,) "\n", \ >>               dev, __func__, RTE_FMT_TAIL(__VA_ARGS__,))) >>   -#else >> -#define CDEV_LOG_DEBUG(...) (void)0 >> -#define CDEV_PMD_TRACE(...) (void)0 >> -#endif >> - >> - >> - >>   /** >>    * A macro that points to an offset from the start >>    * of the crypto operation structure (rte_crypto_op) >