From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 41183A0547; Thu, 9 Sep 2021 12:20:57 +0200 (CEST) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 279B04068E; Thu, 9 Sep 2021 12:20:57 +0200 (CEST) Received: from mga09.intel.com (mga09.intel.com [134.134.136.24]) by mails.dpdk.org (Postfix) with ESMTP id 266674003E for ; Thu, 9 Sep 2021 12:20:54 +0200 (CEST) X-IronPort-AV: E=McAfee;i="6200,9189,10101"; a="220778661" X-IronPort-AV: E=Sophos;i="5.85,279,1624345200"; d="scan'208";a="220778661" Received: from orsmga007.jf.intel.com ([10.7.209.58]) by orsmga102.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 09 Sep 2021 03:20:54 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.85,279,1624345200"; d="scan'208";a="470022113" Received: from fmsmsx606.amr.corp.intel.com ([10.18.126.86]) by orsmga007.jf.intel.com with ESMTP; 09 Sep 2021 03:20:54 -0700 Received: from fmsmsx602.amr.corp.intel.com (10.18.126.82) by fmsmsx606.amr.corp.intel.com (10.18.126.86) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2242.12; Thu, 9 Sep 2021 03:20:53 -0700 Received: from FMSEDG603.ED.cps.intel.com (10.1.192.133) by fmsmsx602.amr.corp.intel.com (10.18.126.82) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2242.12 via Frontend Transport; Thu, 9 Sep 2021 03:20:53 -0700 Received: from NAM10-MW2-obe.outbound.protection.outlook.com (104.47.55.108) by edgegateway.intel.com (192.55.55.68) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.1.2242.12; Thu, 9 Sep 2021 03:20:53 -0700 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=mBflkb2YEb5YMvYXgBj3O2KP6h4MFoirGLdUo3v0EO1Pd2Lscv1l5EZZkmhSEmgkyMvWN7yKEAsAQOEFpe1j5BEDBZOTAAyTPSmzZhHWVeRVebXlgxbar/VD6FUs88qzFuZWRso1EhpJTtnPNFCYSF5MGvQ7WjzPJcEkTzi3WgccjlenEXu9gCs5ZeVqnortvmKFo19fBnd6iaV5YHyK6jorQgiFJYzdhqWSUQoM9ugtA3H8cgEzMGXhIIL7jmUYbf3nXmdFrenGR220XEZJY4jVxjJh+p1NOHWdptL6Ndzo28qxoDGNUlmfMaXMcY7bK97jcEfUmmWepSQYRZ9rTA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version; bh=ZlC6M8ciOLOXtqvjUP18Xb2tBtjD7FiMYGwSAGofVzg=; b=jhfEul6nbOqiaXlaUA8INzQObUYgv1rB8EQgXoOjXa4zzTNxN6TbVWmjvB7+S2dTI1WiEyRnHq4MbESwxz/9IeTKcX7eXqshR/ekRPFbzP5gpKPi1UTuH1j4qhqwQ4bZUVFPpA1qtZ/a9MpDR1eLjJAIXOz8T/vSEw4hnqKa4TSLfJM7ko+IrRGEHVis1iLD/stNKIjILxWrkJuNqL4cVio550anF8kksEvn7jJn3o+0/cy0lsDrAc+IoO661jxEFqzh7M5oFgvkDGikwiavrRsL7Ly/0Dp9iWkNmiMBrj0dEEQDZk5Boo3X1j6MD+rZYvciZyD6EzHqC7+KBMWZUw== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=intel.com; dmarc=pass action=none header.from=intel.com; dkim=pass header.d=intel.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=intel.onmicrosoft.com; s=selector2-intel-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=ZlC6M8ciOLOXtqvjUP18Xb2tBtjD7FiMYGwSAGofVzg=; b=QHCG/641441zgkP4JYrW5C4DtEoBXGg0Eb1GGv1GPoeuyv5CmVjppCpTB0VLWGFnScosY82ZGAt8PSBnnFTQQFOLAnkqtmBwKTrLsc6u2PYzGvnPMZ6v2YoxYsOvIRfzOkhgJJjum/El+ABPnhiB2whzmb/Z0jAQNogRxki4Bl0= Authentication-Results: dpdk.org; dkim=none (message not signed) header.d=none;dpdk.org; dmarc=none action=none header.from=intel.com; Received: from PH0PR11MB5000.namprd11.prod.outlook.com (2603:10b6:510:41::19) by PH0PR11MB5127.namprd11.prod.outlook.com (2603:10b6:510:3c::17) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4500.14; Thu, 9 Sep 2021 10:20:52 +0000 Received: from PH0PR11MB5000.namprd11.prod.outlook.com ([fe80::747b:3a08:d1ec:31fc]) by PH0PR11MB5000.namprd11.prod.outlook.com ([fe80::747b:3a08:d1ec:31fc%5]) with mapi id 15.20.4478.025; Thu, 9 Sep 2021 10:20:52 +0000 To: Qiming Chen , References: <20210909041658.10123-1-chenqiming_huawei@163.com> <20210909082323.10658-1-chenqiming_huawei@163.com> From: Ferruh Yigit X-User: ferruhy Message-ID: <7ccc7438-ca74-2e31-36bf-d89c5a601e6f@intel.com> Date: Thu, 9 Sep 2021 11:20:48 +0100 In-Reply-To: <20210909082323.10658-1-chenqiming_huawei@163.com> Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 8bit X-ClientProxiedBy: DB3PR06CA0007.eurprd06.prod.outlook.com (2603:10a6:8:1::20) To PH0PR11MB5000.namprd11.prod.outlook.com (2603:10b6:510:41::19) MIME-Version: 1.0 Received: from [192.168.0.206] (37.228.236.146) by DB3PR06CA0007.eurprd06.prod.outlook.com (2603:10a6:8:1::20) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4500.14 via Frontend Transport; Thu, 9 Sep 2021 10:20:52 +0000 X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: bb49019e-eef1-43f7-aa80-08d9737b80b9 X-MS-TrafficTypeDiagnostic: PH0PR11MB5127: X-Microsoft-Antispam-PRVS: X-MS-Oob-TLC-OOBClassifiers: OLM:2657; X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: NzuSqLGpz9VsvAYhwktPxwz0lUy6bZjSylTJ+FOYp1EVfd8ne1iK3n/MDpXeJJvEn79HgBRx8Ds/SsPWYEJJtOQH1rMFR2bKtfFV7Z2zaDiETX2FwB4R09T8WP1O8ICv3wSh4DZDiuJnyvfrTtr7FUUrIjYgv+HGleHataoDMCmdeJZgyv602TwB8TFbWnd/Ke7qI2aIMZEk1apPMCklsF2MzY54q3WShqOW+5D335cTJLgHnzK6OPtB8j8jR7OJ8IF72zAWvHOT1Cw0+FhzmRF+U+8Se75L1LO/TCe9mo5i+3h7bck9o9RLYsHFOpb31ZbKlJJvTujj9NRLdHqPSjxxgNiCjcTpm4/q6MobB4lXXHocEAVyjZG2T/dKimLR1ggwvb5l08BlAvHcv/W6e9MScw+qV0mea745KHTesBBMbKWKEousj26o5D6hgo1kkVIHWVPZq/LSYKUHcQULW9GIgyCowKHOpS+Ka1LlJ8DdSQ5HVdGI1wdvy+LKyFBiQ2Ucg6V6yiP1WXN6D1SFSG/jG2+qjyWC9VtLvzYkMtBI5u1eCo/uG6haV2C8GL77UMxE3gXeup7IlNV0MFSkf8vJA1ob5AjjTW7AgBtt2YS7h6c7VU7wrtfzUXIGkqfOErEuT6P6fSbpB8hKc1gmblJqYMK20F6t4uD+hAUOXsOoWM+3gdWiH3fZgwjMWckc7SxGGLTK1G+H4lwIg9Isfw== X-Forefront-Antispam-Report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:PH0PR11MB5000.namprd11.prod.outlook.com; PTR:; CAT:NONE; SFS:(4636009)(39860400002)(376002)(396003)(346002)(366004)(136003)(6666004)(8676002)(53546011)(36756003)(956004)(66946007)(2616005)(31696002)(44832011)(86362001)(5660300002)(478600001)(8936002)(31686004)(316002)(16576012)(2906002)(26005)(66556008)(6486002)(4744005)(66476007)(186003)(38100700002)(45980500001); DIR:OUT; SFP:1102; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?ek1XOTFOMVNaMHB1b2VMYnQxWEp3S2IwZDNrSW9VdWM5cjhmenVPTitHU1N1?= =?utf-8?B?M0hzNXU2QkxGQmxWdk5EenlYejdsazJYNEJFaVVCNHJPTW5FcXRjZWlyUm5x?= =?utf-8?B?eXBmbkw1TG9mUzRNTWQ0d2s1T3Q2TGdMWXRXSzVnU0dDRnFad0JqbEN3dXYw?= =?utf-8?B?eHh1Q0ZESXp3cnA3eEpQRG5QN1dXY2RIMXZMZ2ZReU5wdEtudDFwYkdDN3pj?= =?utf-8?B?aExWVlFVMDdRZ3FEemd2MHFMUnZFWTBMZ3NITTFEU0V5WDk1ZktWYlR4ZzVM?= =?utf-8?B?QTRpc0s2ekhZK2dFZjl3ODNoU3RnWXNtY1pZaXZXeGhZc1djZWpCVnE5Z0Fv?= =?utf-8?B?WTFlSStPRVUzS2p5cksxSlBmTUxzOUMwaFhoM25jOU9TdUEwOTMxOGI4SUtm?= =?utf-8?B?akVqK0FLNm1iUG83OXZhUlVoTlNzOTZrdVhPcTBJeit0RzNUQk5wekMvWWFx?= =?utf-8?B?WTdjNitraGZBbFlmQm5TZ3A4d1hNeDdCVk1IQnNHbCtreHVvRWJmRXpyVmV6?= =?utf-8?B?Vks0amlRMDFSdlJGeFQ5dWxBT2plSVNVMElsMVJFMmNZcGFHVjRjV1JCMjBj?= =?utf-8?B?ek5jZVNxaHN5QzNvKzZKYy9Sd3ZEa2hFbndBcjhQM2xpMGdlemxuNksybFNE?= =?utf-8?B?QlEvMTFVUlEyeGhqUTYxM1F1allRZHZtMzRmNy8wNFBZZzl6Vm03MlBiZ1FE?= =?utf-8?B?c3RtUEwvaXlEcGszbVdWMXF3NnNMQWZyT1dDSnl6QzkwbjJIampFTXBadmNS?= =?utf-8?B?YmRqdFFrSGlsRDVrQ2d2ZytoaC96OXNVdE1iVFdOYThsakdzbkYvNjhZQ1F6?= =?utf-8?B?NzJ5ck5jQlBiSlo2MUdIcCtJeC9lNVFWdWxybXJGTnVzL3BVKzA3Umx1czdy?= =?utf-8?B?SFoxR0FIeDhOQy9OUE8yWTR6VS9zQ2p4eW9ESDRJN2lhWDArRU1kT3NsYXIz?= =?utf-8?B?RVZYMmF5NlJyenFPR0loZXkySkplSGNKdmlWYnl1WVQwUmJWaHkvQTZGOTJV?= =?utf-8?B?RUxDcVBxdzlaUzJleFdKaXpwTnByVkZ4K0Z5Z3VpTGtMdnpDTWZIdUtEWWNn?= =?utf-8?B?WWtkS3JRZlR5RFNyNk9DaWdBcEo2S2pPZXhxNnI3R1U2SHRXVkpTMFFCTkh6?= =?utf-8?B?Y2xYdEpmZ0NJbmcwclZaam1KU3BBMldLck9ORXNZeWlGdnJIc1k0TFAwZTJF?= =?utf-8?B?dHlKeW1MYzVoRXBjT3Nub3haQ01DODBvZ2FYekgwSTVkUS9MWUxuajRhendD?= =?utf-8?B?VzV1WjN1V0lxUXUvdG1vNSs2T1VjSEllWVR3cEJGN1RuRWczcG9SREU4SFFr?= =?utf-8?B?N05Zczg3c202UHBIdW5Pc0xEOFFsTFJvbFRWZWEyRGNIN05Ed09lWXlGZXF6?= =?utf-8?B?a2pFdzRTanpOeU03R0tBYThJQ0o2NmE1MUFadkhsTENqQ3oyaCtrNEc1RUNF?= =?utf-8?B?WDFONjU5SkhkMzR4V1hmK3BsTUQ2cEphSEFQdXZzdEdiTkVKWEhwU1F5TjZS?= =?utf-8?B?K2U1am5jWFBPNGZmT3IyaVJFWEpBYW5hM1pZOTNOOHJVN0QzZE5DZFUzM2Nw?= =?utf-8?B?RUp5dG5jWnZHczhNM0hSSDgzWlB0NDh6TmJyV2VxSWFKemRUTGRCWkdsSXhv?= =?utf-8?B?M2NSUFhzM3dXY2xZTTVEbGw4WjZDMW1kQ2pYNGs3T1VtRXdOUU95ck45UjFp?= =?utf-8?B?RjZNeSsvSFg3bUJ3clE1T3VmYWg0SUhIQldYVndBSzJXT25POVpJd3QvVHV1?= =?utf-8?Q?O6uJ3BtuCIe8Xb69qOwo8vNTuH9grXK/W8Nd5tu?= X-MS-Exchange-CrossTenant-Network-Message-Id: bb49019e-eef1-43f7-aa80-08d9737b80b9 X-MS-Exchange-CrossTenant-AuthSource: PH0PR11MB5000.namprd11.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 09 Sep 2021 10:20:52.8524 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 46c98d88-e344-4ed4-8496-4ed7712e255d X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: N/pv+JuzqLSygIcsZcw2iKrg9SYlbmVCt3LoCA/7bvYsVzmu12M3fYSc8r8V40X2ydEm+E9bYNGV5tM4ZZBUKw== X-MS-Exchange-Transport-CrossTenantHeadersStamped: PH0PR11MB5127 X-OriginatorOrg: intel.com Subject: Re: [dpdk-dev] [PATCH v5] net/pcap: improve rx statistics X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" On 9/9/2021 9:23 AM, Qiming Chen wrote: > In the receiving direction, if alloc mbuf or jumbo process failed, there > is no err_pkts count, which makes it difficult to locate the problem. > Because alloc mbuf failed, the rx_nombuf field is counted. > > Signed-off-by: Qiming Chen <...> > @@ -742,7 +746,7 @@ eth_stats_get(struct rte_eth_dev *dev, struct rte_eth_stats *stats) > { > unsigned int i; > unsigned long rx_packets_total = 0, rx_bytes_total = 0; > - unsigned long rx_missed_total = 0; > + unsigned long rx_missed_total = 0, rx_nombuf = 0, rx_err_total = 0; Since all other variables for same purpose has '_total' suffix, let's add it to the 'rx_nombuf' too. And can you please start a new line for new two variables: unsigned long rx_nombuf_total = 0, rx_err_total = 0;