DPDK patches and discussions
 help / color / mirror / Atom feed
From: "Zhang, Qi Z" <qi.z.zhang@intel.com>
To: "Yigit, Ferruh" <ferruh.yigit@intel.com>,
	"Xing, Beilei" <beilei.xing@intel.com>
Cc: "dev@dpdk.org" <dev@dpdk.org>
Subject: Re: [dpdk-dev] [PATCH] net/i40e: fix build for 32-bit
Date: Mon, 1 Nov 2021 01:15:19 +0000	[thread overview]
Message-ID: <7cfea9ae67ad40cfa07982dbb373e5f7@intel.com> (raw)
In-Reply-To: <20211029103701.4094508-1-ferruh.yigit@intel.com>



> -----Original Message-----
> From: Yigit, Ferruh <ferruh.yigit@intel.com>
> Sent: Friday, October 29, 2021 6:37 PM
> To: Xing, Beilei <beilei.xing@intel.com>
> Cc: Yigit, Ferruh <ferruh.yigit@intel.com>; dev@dpdk.org; Zhang, Qi Z
> <qi.z.zhang@intel.com>
> Subject: [PATCH] net/i40e: fix build for 32-bit
> 
> Got error with: gcc 11.2.1 "cc (GCC) 11.2.1 20210728 (Red Hat 11.2.1-1)"
> 
> Build error:
> In function ‘i40e_flow_parse_fdir_pattern’,
>     inlined from ‘i40e_flow_parse_fdir_filter’
>     at ../drivers/net/i40e/i40e_flow.c:3274:8:
> ../drivers/net/i40e/i40e_flow.c:3052:69:
>     error: writing 1 byte into a region of size 0
>     [-Werror=stringop-overflow=]
>  3052 |                         filter->input.flow_ext.flexbytes[j] =
>       |
> ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~^
>  3053 |                                 raw_spec->pattern[i];
>       |                                 ~~~~~~~~~~~~~~~~~~~~
> In file included from ../drivers/net/i40e/i40e_flow.c:25:
>   ../drivers/net/i40e/i40e_flow.c:
>   In function ‘i40e_flow_parse_fdir_filter’:
>   ../drivers/net/i40e/i40e_ethdev.h:638:17:
>   note: at offset 16 into destination object ‘flexbytes’ of size 16
>   638 |         uint8_t flexbytes[RTE_ETH_FDIR_MAX_FLEXLEN];
>       |                 ^~~~~~~~~
> 
> Fixing by adding range checks.
> 
> Signed-off-by: Ferruh Yigit <ferruh.yigit@intel.com>

Acked-by: Qi Zhang <qi.z.zhang@intel.com>

Applied to dpdk-next-net-intel after added below fixline and Cc stable.
Fixes: 6ced3dd72f5f ("net/i40e: support flexible payload parsing for FDIR")

Thanks
Qi


      reply	other threads:[~2021-11-01  1:15 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-10-29 10:37 Ferruh Yigit
2021-11-01  1:15 ` Zhang, Qi Z [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=7cfea9ae67ad40cfa07982dbb373e5f7@intel.com \
    --to=qi.z.zhang@intel.com \
    --cc=beilei.xing@intel.com \
    --cc=dev@dpdk.org \
    --cc=ferruh.yigit@intel.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).