From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id 1994DA0471 for ; Tue, 13 Aug 2019 11:37:48 +0200 (CEST) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id 6816D1BDAC; Tue, 13 Aug 2019 11:37:46 +0200 (CEST) Received: from mail-wr1-f68.google.com (mail-wr1-f68.google.com [209.85.221.68]) by dpdk.org (Postfix) with ESMTP id 871EB378B; Tue, 13 Aug 2019 11:37:45 +0200 (CEST) Received: by mail-wr1-f68.google.com with SMTP id r3so13379412wrt.3; Tue, 13 Aug 2019 02:37:45 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:message-id:subject:from:to:cc:date:in-reply-to :references:content-transfer-encoding:user-agent:mime-version; bh=cjE3Xx+SRiBkjsJ1/dLYiSkwZnjjPI5xUkvw+CABEds=; b=ootijW0NP0XIb6e8cF+AMCb1mTj8mvqIS1APQ5StrJVFi3jwQbxyGKpFJBEbXNdYms FzJSBHV83qzqhchFDxgZaZ+2AgpKL8jhfyZxYbATYfFuxv0zRUypFh6FwgGh+WB06kLY krVGNpTQtf+hAYSQCJX726M2MV2MihvHB78i+8Q+iPufpqCZVjGxQYB1oRzunsYfGMOE cExXUzvsWUg9ipABmENp0N9BkNRhBjKg84ejf8V1KfDyljO/lsYKkD2+vM4P/vBVfmsx uPwNFqGgD8FpR1n8XJhXX/Zyn6tvzxWQbKWGTdJ9kpAzEEwEM412FBaVQLTJi5Fr44r6 owxA== X-Gm-Message-State: APjAAAU1RUSm6B4bW4h11xkZLxFrTS4eIxaPGb28eqd+/G6ovOnHk/k9 UpyRL7JKe264OcJt6F7XdGQ= X-Google-Smtp-Source: APXvYqyUEYSl+RjSaFuesZk/SOWjAgNw7uyTg7PiAJiXrklyIDXfp4rou5TSmivqmXoyY84Y9k2KDA== X-Received: by 2002:adf:e3ce:: with SMTP id k14mr15508115wrm.303.1565689065010; Tue, 13 Aug 2019 02:37:45 -0700 (PDT) Received: from localhost ([2a01:4b00:f419:6f00:7a8e:ed70:5c52:ea3]) by smtp.gmail.com with ESMTPSA id r17sm13072455wrg.93.2019.08.13.02.37.44 (version=TLS1_3 cipher=AEAD-AES256-GCM-SHA384 bits=256/256); Tue, 13 Aug 2019 02:37:44 -0700 (PDT) Message-ID: <7d0573dc26e48bae9715bc977d2d687f956497c3.camel@debian.org> From: Luca Boccassi To: Thomas Monjalon , bruce.richardson@intel.com, Lee Daly , Fiona Trahe , Pablo de Lara , Ashish Gupta , Xiaolong Ye , Qi Zhang Cc: dev@dpdk.org, stable@dpdk.org Date: Tue, 13 Aug 2019 10:37:43 +0100 In-Reply-To: <20190812230358.988-2-thomas@monjalon.net> References: <20190812230358.988-1-thomas@monjalon.net> <20190812230358.988-2-thomas@monjalon.net> Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable User-Agent: Evolution 3.30.5-1.1 MIME-Version: 1.0 Subject: Re: [dpdk-dev] [PATCH 1/6] build: remove redundant libs from pkgconfig X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" On Tue, 2019-08-13 at 01:03 +0200, Thomas Monjalon wrote: > As explained in drivers/meson.build, > " > For the find_library() case (but not with dependency()) we also > need to specify the "-l" flags in pkgconfig_extra_libs variable > too, so that it can be reflected in the pkgconfig output for > static builds. > " >=20 > The commit e30b4e566f47 ("build: improve dependency handling") > must be followed up with this one in order to remove more > occurences of pkgconfig_extra_libs redundant with use of > dependency(). >=20 > Fixes: f1debd77efaf ("net/af_xdp: introduce AF_XDP PMD") > Cc:=20 > xiaolong.ye@intel.com >=20 > Fixes: 3c32e89f68e1 ("compress/isal: add skeleton ISA-L compression > PMD") > Cc:=20 > lee.daly@intel.com >=20 > Cc:=20 > bluca@debian.org >=20 > Cc:=20 > stable@dpdk.org >=20 >=20 > Signed-off-by: Thomas Monjalon < > thomas@monjalon.net > > > --- > drivers/compress/isal/meson.build | 1 - > drivers/net/af_xdp/meson.build | 1 - > 2 files changed, 2 deletions(-) >=20 > diff --git a/drivers/compress/isal/meson.build > b/drivers/compress/isal/meson.build > index 67b5c4aae..25578880d 100644 > --- a/drivers/compress/isal/meson.build > +++ b/drivers/compress/isal/meson.build > @@ -10,6 +10,5 @@ endif > deps +=3D 'bus_vdev' > sources =3D files('isal_compress_pmd.c', 'isal_compress_pmd_ops.c') > ext_deps +=3D dep > -pkgconfig_extra_libs +=3D '-lisal' > =20 > allow_experimental_apis =3D true > diff --git a/drivers/net/af_xdp/meson.build > b/drivers/net/af_xdp/meson.build > index ac679b92b..307aa0e38 100644 > --- a/drivers/net/af_xdp/meson.build > +++ b/drivers/net/af_xdp/meson.build > @@ -10,7 +10,6 @@ endif > =20 > if bpf_dep.found() and cc.has_header('bpf/xsk.h') and > cc.has_header('linux/if_xdp.h') > ext_deps +=3D bpf_dep > - pkgconfig_extra_libs +=3D '-lbpf' > else > build =3D false > reason =3D 'missing dependency, "libbpf"' >=20 Acked-by: Luca Boccassi --=20 Kind regards, Luca Boccassi