From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mga14.intel.com (mga14.intel.com [192.55.52.115]) by dpdk.org (Postfix) with ESMTP id C2E441C01 for ; Wed, 25 Apr 2018 09:09:41 +0200 (CEST) X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from orsmga008.jf.intel.com ([10.7.209.65]) by fmsmga103.fm.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 25 Apr 2018 00:09:39 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.49,325,1520924400"; d="scan'208";a="36258735" Received: from tanjianf-mobl.ccr.corp.intel.com (HELO [10.67.64.57]) ([10.67.64.57]) by orsmga008.jf.intel.com with ESMTP; 25 Apr 2018 00:09:38 -0700 To: Anatoly Burakov , dev@dpdk.org References: <19c4033ae0d07a666f8142c8dd06b9ac0eb45af3.1523977960.git.anatoly.burakov@intel.com> Cc: thomas@monjalon.net From: "Tan, Jianfeng" Message-ID: <7d1afc66-f8ce-44c8-7518-7cb641d9aac9@intel.com> Date: Wed, 25 Apr 2018 15:09:37 +0800 User-Agent: Mozilla/5.0 (Windows NT 6.3; WOW64; rv:45.0) Gecko/20100101 Thunderbird/45.8.0 MIME-Version: 1.0 In-Reply-To: <19c4033ae0d07a666f8142c8dd06b9ac0eb45af3.1523977960.git.anatoly.burakov@intel.com> Content-Type: text/plain; charset=windows-1252; format=flowed Content-Transfer-Encoding: 7bit Subject: Re: [dpdk-dev] [PATCH 2/2] eal: fix not checking unlock result X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 25 Apr 2018 07:09:43 -0000 On 4/17/2018 11:42 PM, Anatoly Burakov wrote: > Coverity issue: 272607 > > Fixes: 66cc45e293ed ("mem: replace memseg with memseg lists") > Cc: anatoly.burakov@intel.com > > Signed-off-by: Anatoly Burakov > --- > lib/librte_eal/linuxapp/eal/eal_hugepage_info.c | 7 +++++-- > 1 file changed, 5 insertions(+), 2 deletions(-) > > diff --git a/lib/librte_eal/linuxapp/eal/eal_hugepage_info.c b/lib/librte_eal/linuxapp/eal/eal_hugepage_info.c > index 009f963..01fee51 100644 > --- a/lib/librte_eal/linuxapp/eal/eal_hugepage_info.c > +++ b/lib/librte_eal/linuxapp/eal/eal_hugepage_info.c > @@ -304,8 +304,11 @@ clear_hugedir(const char * hugedir) > /* if lock succeeds, unlock and remove the file */ > if (lck_result != -1) { > lck.l_type = F_UNLCK; > - fcntl(fd, F_SETLK, &lck); > - unlinkat(dir_fd, dirent->d_name, 0); > + if (fcntl(fd, F_SETLK, &lck) < 0) > + RTE_LOG(ERR, EAL, "Couldn't unlock %s: %s\n", > + dirent->d_name, strerror(errno)); It seems that we shall return error if this nearly-impossible error happens, no? > + else > + unlinkat(dir_fd, dirent->d_name, 0); > } > close (fd); > dirent = readdir(dir);