From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mga04.intel.com (mga04.intel.com [192.55.52.120]) by dpdk.org (Postfix) with ESMTP id 7D1252C27 for ; Wed, 12 Apr 2017 16:07:55 +0200 (CEST) Received: from fmsmga006.fm.intel.com ([10.253.24.20]) by fmsmga104.fm.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 12 Apr 2017 07:07:55 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.37,191,1488873600"; d="scan'208";a="88219456" Received: from fyigit-mobl1.ger.corp.intel.com (HELO [10.237.220.122]) ([10.237.220.122]) by fmsmga006.fm.intel.com with ESMTP; 12 Apr 2017 07:07:52 -0700 To: "Iremonger, Bernard" , "Zhang, Qi Z" , "dev@dpdk.org" Cc: "Xing, Beilei" , "Lu, Wenzhuo" , "Zhang, Qi" References: <1491922880-18702-1-git-send-email-bernard.iremonger@intel.com> <039ED4275CED7440929022BC67E706115308B12A@SHSMSX103.ccr.corp.intel.com> <8CEF83825BEC744B83065625E567D7C224D52F48@IRSMSX108.ger.corp.intel.com> <039ED4275CED7440929022BC67E706115308B186@SHSMSX103.ccr.corp.intel.com> <8CEF83825BEC744B83065625E567D7C224D53012@IRSMSX108.ger.corp.intel.com> From: Ferruh Yigit Message-ID: <7d1b6aaf-7ba5-4bb3-db44-6e83ef054e93@intel.com> Date: Wed, 12 Apr 2017 15:07:52 +0100 User-Agent: Mozilla/5.0 (Windows NT 10.0; WOW64; rv:52.0) Gecko/20100101 Thunderbird/52.0 MIME-Version: 1.0 In-Reply-To: <8CEF83825BEC744B83065625E567D7C224D53012@IRSMSX108.ger.corp.intel.com> Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 8bit Subject: Re: [dpdk-dev] [PATCH] net/i40e: fix to ensure vector mode is not used X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 12 Apr 2017 14:07:57 -0000 On 4/12/2017 2:54 PM, Iremonger, Bernard wrote: > Hi Qi, > > > > > >>>> -----Original Message----- >>>> From: Zhang, Qi Z >>>> Sent: Wednesday, April 12, 2017 12:43 PM >>>> To: Iremonger, Bernard ; dev@dpdk.org >>>> Cc: Xing, Beilei ; Lu, Wenzhuo >>>> ; Zhang, Qi ; Iremonger, >>>> Bernard >>>> Subject: RE: [dpdk-dev] [PATCH] net/i40e: fix to ensure vector mode >>>> is not used >>>> >>>> Hi Bernard: >>>> >>>>> -----Original Message----- >>>>> From: dev [mailto:dev-bounces@dpdk.org] On Behalf Of Bernard >>>> Iremonger >>>>> Sent: Tuesday, April 11, 2017 11:01 PM >>>>> To: dev@dpdk.org >>>>> Cc: Xing, Beilei ; Lu, Wenzhuo >>>>> ; Zhang, Qi ; >> Iremonger, >>>>> Bernard >>>>> Subject: [dpdk-dev] [PATCH] net/i40e: fix to ensure vector mode is >>>>> not used >>>>> >>>>> In rx vector mode, the QinQ VLAN tag is not stripped. >>>>> When hw_vlan_extend is set for QinQ ensure that rx vector mode is >>>>> not selected. >>>>> >>>>> Fixes: ca74903b75cf ("net/i40e: extract non-x86 specific code from >>>>> vector >>>>> driver") >>>> >>>> Why fixes? I didn't see above commit change rx callback function if >>>> hw_vlan_extend == 1 >>> >>> Some of the QinQ functionality was introduced in 17.02, this >>> functionality also has the same issue. >>> So I added a fixes line. >> >> If you think this patch is a fix, you need to find the commit that introduce this >> issue The commit ca74903b75cf is not the root cause of the issue, it just move >> the code from I40e_rxtx_vec.c to i40e_rxtx_vec_common.h >> >> Regards >> Qi >> > This is a fix to the i40e_rx_vec_dev_conf_condition_check_default() function. > The issue is caused because there is no check on the hw_vlan_extend flag at present. > This is the correct fixline for that function. > ca74903b75 (Jianbo Liu 2016-10-14 09:30:00 +0530 221) i40e_rx_vec_dev_conf_condition_check_default(struct rte_eth_dev *dev) > > I will send a v2 as I should have added the "Cc: stable@dpdk.org" line. Hi Bernard, I agree with Qi, the commit you are using is just moves function to a common header, you are not fixing that. Perhaps fixline can be the commit that adds QinQ support, because it forgets adding hw_vlan_extend check? byw, since this common function used by other vector drivers, neon and altivec, will this something effect them, is there any case "hw_vlan_extend == 1" but other vector drivers can be used? Thanks, ferruh > > Regards, > > Bernard. > >