From: Shijith Thotton <sthotton@marvell.com>
To: <dev@dpdk.org>
Cc: Shijith Thotton <sthotton@marvell.com>,
Erik Gabriel Carrillo <erik.g.carrillo@intel.com>,
Jerin Jacob <jerinj@marvell.com>,
"Pavan Nikhilesh" <pbhagavatula@marvell.com>
Subject: [dpdk-dev] [PATCH v1] test/event: fix return value of timer test setup
Date: Fri, 7 May 2021 15:42:47 +0530 [thread overview]
Message-ID: <7d28b0e4a5e0eb715eaced93b98af833da34b63b.1620382076.git.sthotton@marvell.com> (raw)
Test case setup should return -ENOTSUP, if it is not supported.
Fixes: 7d761b07fcf6 ("test/event: add unit tests for periodic timer")
Signed-off-by: Shijith Thotton <sthotton@marvell.com>
---
app/test/test_event_timer_adapter.c | 6 ++----
1 file changed, 2 insertions(+), 4 deletions(-)
diff --git a/app/test/test_event_timer_adapter.c b/app/test/test_event_timer_adapter.c
index c36ab32ac..121c2d93e 100644
--- a/app/test/test_event_timer_adapter.c
+++ b/app/test/test_event_timer_adapter.c
@@ -303,10 +303,8 @@ _timdev_setup(uint64_t max_tmo_ns, uint64_t bkt_tck_ns, uint64_t flags)
"failed to get adapter capabilities");
if (flags & RTE_EVENT_TIMER_ADAPTER_F_PERIODIC &&
- !(caps & RTE_EVENT_TIMER_ADAPTER_CAP_PERIODIC)) {
- printf("Adapter does not support periodic timers\n");
- return TEST_SKIPPED;
- }
+ !(caps & RTE_EVENT_TIMER_ADAPTER_CAP_PERIODIC))
+ return -ENOTSUP;
if (!(caps & RTE_EVENT_TIMER_ADAPTER_CAP_INTERNAL_PORT)) {
timdev = rte_event_timer_adapter_create_ext(&config,
--
2.25.1
next reply other threads:[~2021-05-07 10:12 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-05-07 10:12 Shijith Thotton [this message]
2021-05-09 16:06 ` Jerin Jacob
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=7d28b0e4a5e0eb715eaced93b98af833da34b63b.1620382076.git.sthotton@marvell.com \
--to=sthotton@marvell.com \
--cc=dev@dpdk.org \
--cc=erik.g.carrillo@intel.com \
--cc=jerinj@marvell.com \
--cc=pbhagavatula@marvell.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).