From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 81C75A0A03; Tue, 19 Jan 2021 11:29:53 +0100 (CET) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 1D6A1140D4E; Tue, 19 Jan 2021 11:29:53 +0100 (CET) Received: from mga17.intel.com (mga17.intel.com [192.55.52.151]) by mails.dpdk.org (Postfix) with ESMTP id B83D6140D4D for ; Tue, 19 Jan 2021 11:29:49 +0100 (CET) IronPort-SDR: mBr/MimANhT0UN6G7lB0jR2LEXqZjS8D2zJ/W9722T7x5ZlQB3MQR7qOyU4UWeucXrQkVPgN2M in5aL//M5mKw== X-IronPort-AV: E=McAfee;i="6000,8403,9868"; a="158679641" X-IronPort-AV: E=Sophos;i="5.79,358,1602572400"; d="scan'208";a="158679641" Received: from orsmga008.jf.intel.com ([10.7.209.65]) by fmsmga107.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 19 Jan 2021 02:29:46 -0800 IronPort-SDR: wSwPmVwOP7quPnGkcw4M381jCsdngM65cxB45QnMJYF550Bym0D1hPAvB9fzG30+FVeCtoKwZm c+D0MRe6sOig== X-IronPort-AV: E=Sophos;i="5.79,358,1602572400"; d="scan'208";a="383878220" Received: from mkoeck-mobl1.ger.corp.intel.com (HELO [10.252.49.223]) ([10.252.49.223]) by orsmga008-auth.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 19 Jan 2021 02:29:43 -0800 To: Thomas Monjalon Cc: dev@dpdk.org, Timothy McDaniel , Jan Viktorin , Ruifeng Wang , Jerin Jacob , David Christensen , Bruce Richardson , Konstantin Ananyev , david.hunt@intel.com, chris.macnamara@intel.com References: <4544999.HkzO7cMdQl@thomas> From: "Burakov, Anatoly" Message-ID: <7d39b1f2-fb18-73db-c9da-49be72543161@intel.com> Date: Tue, 19 Jan 2021 10:29:41 +0000 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:68.0) Gecko/20100101 Thunderbird/68.12.0 MIME-Version: 1.0 In-Reply-To: <4544999.HkzO7cMdQl@thomas> Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: 7bit Subject: Re: [dpdk-dev] [PATCH v17 03/11] eal: change API of power intrinsics X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" On 18-Jan-21 10:26 PM, Thomas Monjalon wrote: > 14/01/2021 15:46, Anatoly Burakov: >> +struct rte_power_monitor_cond { >> + volatile void *addr; /**< Address to monitor for changes */ >> + uint64_t val; /**< Before attempting the monitoring, the address >> + * may be read and compared against this value. > > "may" be read and compared? > Is there a case where there is no read and compare? Yes, if the mask is not set. > >> + **/ >> + uint64_t mask; /**< 64-bit mask to extract current value from addr */ >> + uint8_t data_sz; /**< Data size (in bytes) that will be used to compare >> + * expected value with the memory address. Can be 1, >> + * 2, 4, or 8. Supplying any other value will lead to >> + * undefined result. */ > > Other parameters are not prefixed with "data_", > so I think this field could be simply named "size". OK. > >> +}; > > I understand this struct is a direct translation of what existed > in 20.11 as function parameters and comments. > If you agree, these comments could be addressed in a separate patch. > I'll be respinning anyway, so might as well do some quick fixups. -- Thanks, Anatoly