From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mga02.intel.com (mga02.intel.com [134.134.136.20]) by dpdk.org (Postfix) with ESMTP id 86C34CF7A for ; Tue, 28 Mar 2017 10:25:35 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple; d=intel.com; i=@intel.com; q=dns/txt; s=intel; t=1490689535; x=1522225535; h=subject:to:references:cc:from:message-id:date: mime-version:in-reply-to:content-transfer-encoding; bh=bOApuB8kzWq+Lg24w8FECuC6LHA4cevixZHoMCGxGAY=; b=te+g/vxljzMgNpkv8A+pWFTANGYBnkC278+R46IxVmsdQzQolQIxWmv4 beSKRP/enoG/yGIAhy/mS5lccoBCfQ==; Received: from fmsmga006.fm.intel.com ([10.253.24.20]) by orsmga101.jf.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 28 Mar 2017 01:25:34 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.36,236,1486454400"; d="scan'208";a="81789417" Received: from dhunt5-mobl.ger.corp.intel.com (HELO [10.237.221.69]) ([10.237.221.69]) by fmsmga006.fm.intel.com with ESMTP; 28 Mar 2017 01:25:32 -0700 To: Thomas Monjalon References: <1489558767-56329-2-git-send-email-david.hunt@intel.com> <1490004522-183515-1-git-send-email-david.hunt@intel.com> <1490004522-183515-9-git-send-email-david.hunt@intel.com> <1955761.tFH3Sr4yC9@xps13> Cc: dev@dpdk.org, bruce.richardson@intel.com From: "Hunt, David" Message-ID: <7d66a825-b027-69c4-7073-c2fd27561ed1@intel.com> Date: Tue, 28 Mar 2017 09:25:32 +0100 User-Agent: Mozilla/5.0 (Windows NT 6.3; WOW64; rv:45.0) Gecko/20100101 Thunderbird/45.8.0 MIME-Version: 1.0 In-Reply-To: <1955761.tFH3Sr4yC9@xps13> Content-Type: text/plain; charset=windows-1252; format=flowed Content-Transfer-Encoding: 7bit Subject: Re: [dpdk-dev] [PATCH v11 08/18] lib: add symbol versioning to distributor X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 28 Mar 2017 08:25:35 -0000 Hi Thomas, On 27/3/2017 2:02 PM, Thomas Monjalon wrote: > 2017-03-20 10:08, David Hunt: >> Also bumped up the ABI version number in the Makefile > It would be good to explain the intent of versioning here. > >> Signed-off-by: David Hunt >> Acked-by: Bruce Richardson >> --- >> lib/librte_distributor/Makefile | 2 +- >> lib/librte_distributor/rte_distributor.c | 57 +++++++++++--- >> lib/librte_distributor/rte_distributor_v1705.h | 89 ++++++++++++++++++++++ >> lib/librte_distributor/rte_distributor_v20.c | 10 +++ >> lib/librte_distributor/rte_distributor_version.map | 14 ++++ >> 5 files changed, 162 insertions(+), 10 deletions(-) >> create mode 100644 lib/librte_distributor/rte_distributor_v1705.h >> >> diff --git a/lib/librte_distributor/Makefile b/lib/librte_distributor/Makefile >> index 2b28eff..2f05cf3 100644 >> --- a/lib/librte_distributor/Makefile >> +++ b/lib/librte_distributor/Makefile >> @@ -39,7 +39,7 @@ CFLAGS += $(WERROR_FLAGS) -I$(SRCDIR) >> >> EXPORT_MAP := rte_distributor_version.map >> >> -LIBABIVER := 1 >> +LIBABIVER := 2 > Why keeping ABI compat if you bump ABIVER? > > I guess you do not really want to bump now. You are correct. The symbol versioning will ensure old binaries will work without the bump in LIBABIVER. Please do not apply this line. Thanks, Dave.