From: Maxime Coquelin <maxime.coquelin@redhat.com>
To: Weiguo Li <liwg06@foxmail.com>, vsrivast@xilinx.com
Cc: dev@dpdk.org
Subject: Re: [PATCH] vdpa/sfc: fix null pointer dereference
Date: Thu, 10 Feb 2022 15:37:59 +0100 [thread overview]
Message-ID: <7d79e3e8-ac87-f92c-2147-0527ce858f65@redhat.com> (raw)
In-Reply-To: <tencent_1D428430E68027EEF436625787ECBB7DE405@qq.com>
Hi,
On 2/4/22 12:56, Weiguo Li wrote:
> The macro sfc_vdpa_info(sva, ...) will invoke sva->logtype_main,
> It'll trigger a NULL dereference when sva is NULL.
>
> This patch fix it.
>
> BTW this patch is not superseded by another one:
> [v2] vdpa/sfc: fix null dereference
> (http://dpdk.org/patch/106720)
>
> They looks alike in title, but deal with different files.
>
> Please don't tag me as superseded again :)
>
Got it, having commit titles being more specific would help to avoid
that! :)
Reviewed-by: Maxime Coquelin <maxime.coquelin@redhat.com>
Thanks,
Maxime
next prev parent reply other threads:[~2022-02-10 14:38 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-01-29 17:30 Weiguo Li
2022-02-04 11:56 ` Weiguo Li
2022-02-10 14:37 ` Maxime Coquelin [this message]
2022-02-10 15:11 ` [PATCH] " Maxime Coquelin
2022-02-10 15:12 ` Maxime Coquelin
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=7d79e3e8-ac87-f92c-2147-0527ce858f65@redhat.com \
--to=maxime.coquelin@redhat.com \
--cc=dev@dpdk.org \
--cc=liwg06@foxmail.com \
--cc=vsrivast@xilinx.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).