From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 69950A00BE; Thu, 10 Feb 2022 15:38:13 +0100 (CET) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 58FA4426EE; Thu, 10 Feb 2022 15:38:13 +0100 (CET) Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) by mails.dpdk.org (Postfix) with ESMTP id 7ED1A4013F for ; Thu, 10 Feb 2022 15:38:11 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1644503891; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=iJskoZRHTEgxq/PscTHdhmyX4ZI6QaN8ZjtcQrWQsWQ=; b=Dy0HJQQ0ize2ox8elQuhUA1YwpYebwsp+BxuYfjkddS7pyK+10hhGK5L7yj88GF7JwSOkf L0GSds2V5ChGici2ZPmiKm6sjcJvoKrdF413HK52BkXf9oWK4kYiDEUZvdKBgpL059UjB+ apYSUuGb0kKK5f+pOjDP3wO4lBY2B00= Received: from mimecast-mx01.redhat.com (mimecast-mx01.redhat.com [209.132.183.4]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id us-mta-611-pyrbxwKTM7uzE4YbSXETRw-1; Thu, 10 Feb 2022 09:38:04 -0500 X-MC-Unique: pyrbxwKTM7uzE4YbSXETRw-1 Received: from smtp.corp.redhat.com (int-mx04.intmail.prod.int.phx2.redhat.com [10.5.11.14]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx01.redhat.com (Postfix) with ESMTPS id 363805A064; Thu, 10 Feb 2022 14:38:03 +0000 (UTC) Received: from [10.39.208.19] (unknown [10.39.208.19]) by smtp.corp.redhat.com (Postfix) with ESMTPS id 56DA078A91; Thu, 10 Feb 2022 14:38:00 +0000 (UTC) Message-ID: <7d79e3e8-ac87-f92c-2147-0527ce858f65@redhat.com> Date: Thu, 10 Feb 2022 15:37:59 +0100 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101 Thunderbird/91.5.0 Subject: Re: [PATCH] vdpa/sfc: fix null pointer dereference To: Weiguo Li , vsrivast@xilinx.com Cc: dev@dpdk.org References: From: Maxime Coquelin In-Reply-To: X-Scanned-By: MIMEDefang 2.79 on 10.5.11.14 Authentication-Results: relay.mimecast.com; auth=pass smtp.auth=CUSA124A263 smtp.mailfrom=maxime.coquelin@redhat.com X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Language: en-US Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Hi, On 2/4/22 12:56, Weiguo Li wrote: > The macro sfc_vdpa_info(sva, ...) will invoke sva->logtype_main, > It'll trigger a NULL dereference when sva is NULL. > > This patch fix it. > > BTW this patch is not superseded by another one: > [v2] vdpa/sfc: fix null dereference > (http://dpdk.org/patch/106720) > > They looks alike in title, but deal with different files. > > Please don't tag me as superseded again :) > Got it, having commit titles being more specific would help to avoid that! :) Reviewed-by: Maxime Coquelin Thanks, Maxime