From: fengchengwen <fengchengwen@huawei.com>
To: Thomas Monjalon <thomas@monjalon.net>, <dev@dpdk.org>
Cc: <stephen@networkplumber.org>, <aman.deep.singh@intel.com>,
	<lihuisong@huawei.com>, <liuyonglong@huawei.com>,
	Dengdui Huang <huangdengdui@huawei.com>,
	Andrew Rybchenko <andrew.rybchenko@oktetlabs.ru>,
	Ivan Malov <ivan.malov@oktetlabs.ru>,
	Ivan Malov <ivan.malov@arknetworks.am>,
	 Sunil Kumar Kori <skori@marvell.com>,
	<yangxingui@h-partners.com>
Subject: Re: [PATCH] net: fix incorrect L2 length for GRE tunneling packet
Date: Mon, 3 Nov 2025 10:40:13 +0800	[thread overview]
Message-ID: <7d809cc9-941e-49af-b2d1-c4bb40c44407@huawei.com> (raw)
In-Reply-To: <3634305.KRxA6XjA2N@thomas>
Reviewed-by: Chengwen Feng <fengchengwen@huawei.com>
This commit also fix one access not-initialized inner_l2_len problem, consider:
If the packet is one tunnel type which recognize by ptype_tunnel_without_udp(), and
application don't init "struct rte_net_hdr_lens hdr_lens;" , then the inner_l2_len will
be random without this commit because later process the inner_l2_len both are both += ops.
On 9/24/2025 10:41 PM, Thomas Monjalon wrote:
> Looking for review, please.
> 
> 
> 23/07/2025 12:47, Dengdui Huang:
>> The meaning of L2_len in the parsing result of the rte_net_get_ptype()
>> is the same as the L2_len field in the mbuf. For tunnel packets,
>> the L2_len should include protocol header of tunnel packets.
>>
>> Bugzilla ID: 1754
>> Fixes: d21d855464ff ("net: support GRE in software packet type parser")
>> Cc: stable@dpdk.org
>>
>> Signed-off-by: Dengdui Huang <huangdengdui@huawei.com>
>> ---
>>  lib/net/rte_net.c | 1 +
>>  1 file changed, 1 insertion(+)
>>
>> diff --git a/lib/net/rte_net.c b/lib/net/rte_net.c
>> index 44fb6c0f51..c70b57fdc0 100644
>> --- a/lib/net/rte_net.c
>> +++ b/lib/net/rte_net.c
>> @@ -481,6 +481,7 @@ uint32_t rte_net_get_ptype(const struct rte_mbuf *m,
>>  
>>  		pkt_type |= ptype_tunnel_without_udp(&proto, m, &off);
>>  		hdr_lens->tunnel_len = off - prev_off;
>> +		hdr_lens->inner_l2_len = off - prev_off;
>>  	}
>>  
>>  	/* same job for inner header: we need to duplicate the code
>>
> 
> 
> 
> 
> 
     prev parent reply	other threads:[~2025-11-03  2:40 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2025-07-23 10:47 Dengdui Huang
2025-09-24 14:41 ` Thomas Monjalon
2025-11-03  2:40   ` fengchengwen [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox
  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):
  git send-email \
    --in-reply-to=7d809cc9-941e-49af-b2d1-c4bb40c44407@huawei.com \
    --to=fengchengwen@huawei.com \
    --cc=aman.deep.singh@intel.com \
    --cc=andrew.rybchenko@oktetlabs.ru \
    --cc=dev@dpdk.org \
    --cc=huangdengdui@huawei.com \
    --cc=ivan.malov@arknetworks.am \
    --cc=ivan.malov@oktetlabs.ru \
    --cc=lihuisong@huawei.com \
    --cc=liuyonglong@huawei.com \
    --cc=skori@marvell.com \
    --cc=stephen@networkplumber.org \
    --cc=thomas@monjalon.net \
    --cc=yangxingui@h-partners.com \
    /path/to/YOUR_REPLY
  https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
  Be sure your reply has a Subject: header at the top and a blank line
  before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).