From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id C5EA6A0C41; Thu, 30 Sep 2021 14:03:23 +0200 (CEST) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 8855C410E5; Thu, 30 Sep 2021 14:03:23 +0200 (CEST) Received: from shelob.oktetlabs.ru (shelob.oktetlabs.ru [91.220.146.113]) by mails.dpdk.org (Postfix) with ESMTP id 0F62440DDA for ; Thu, 30 Sep 2021 14:03:22 +0200 (CEST) Received: from [192.168.38.17] (aros.oktetlabs.ru [192.168.38.17]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by shelob.oktetlabs.ru (Postfix) with ESMTPSA id 49D7F7F6BC; Thu, 30 Sep 2021 15:03:21 +0300 (MSK) DKIM-Filter: OpenDKIM Filter v2.11.0 shelob.oktetlabs.ru 49D7F7F6BC DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple; d=oktetlabs.ru; s=default; t=1633003401; bh=NTboiiwbMESyKR4ce9JtXCZ3a6YYK+v4zjN6ZAv5nY8=; h=Subject:To:Cc:References:From:Date:In-Reply-To; b=oPQillXpeo5H6/wGG3zH3Z+NH//D+xyGxJbSJkIG2lv6ha4i2zmRJn8KmHhc54uGz /lKbX7in3AguVx2oD8kspAea279IId6tVU4wFcsW4AZsJRWbK5maenxuMqDC0+Nn5L /pkf327O8Jv5CbfTY6XDehvNOugvbc+cRsGt2Gpc= To: "Singh, Aman Deep" , Ajit Khaparde , Somnath Kotur , John Daley , Hyong Youb Kim , Beilei Xing , Qiming Yang , Qi Zhang , Haiyue Wang , Matan Azrad , Viacheslav Ovsiienko , Thomas Monjalon , Ferruh Yigit Cc: dev@dpdk.org, Viacheslav Galaktionov References: <20210712161747.958019-1-andrew.rybchenko@oktetlabs.ru> <20210913112633.2836730-1-andrew.rybchenko@oktetlabs.ru> <2ddbed3f-6a65-6a6f-462a-4753860c9b2f@intel.com> From: Andrew Rybchenko Organization: OKTET Labs Message-ID: <7d87e008-6493-075d-cd09-98a3aef399f7@oktetlabs.ru> Date: Thu, 30 Sep 2021 15:03:20 +0300 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101 Thunderbird/78.14.0 MIME-Version: 1.0 In-Reply-To: <2ddbed3f-6a65-6a6f-462a-4753860c9b2f@intel.com> Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 8bit Subject: Re: [dpdk-dev] [PATCH v5] ethdev: fix representor port ID search by name X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" On 9/29/21 2:13 PM, Singh, Aman Deep wrote: > > On 9/13/2021 4:56 PM, Andrew Rybchenko wrote: >> From: Viacheslav Galaktionov >> >> Getting a list of representors from a representor does not make sense. >> Instead, a parent device should be used. >> >> To this end, extend the rte_eth_dev_data structure to include the port ID >> of the backing device for representors. >> >> Signed-off-by: Viacheslav Galaktionov >> >> Signed-off-by: Andrew Rybchenko >> Acked-by: Haiyue Wang >> Acked-by: Beilei Xing >> --- >> The new field is added into the hole in rte_eth_dev_data structure. >> The patch does not change ABI, but extra care is required since ABI >> check is disabled for the structure because of the libabigail bug [1]. >> It should not be a problem anyway since 21.11 is a ABI breaking release. >> >> Potentially it is bad for out-of-tree drivers which implement >> representors but do not fill in a new parert_port_id field in >> rte_eth_dev_data structure. Get ID by name will not work. > Did we change name of new field from parert_port_id to backer_port_id. Yes, see v5 changelog below. It is done to address review notes from Ferruh on v4. >> >> mlx5 changes should be reviwed by maintainers very carefully, since >> we are not sure if we patch it correctly. >> >> [1] https://sourceware.org/bugzilla/show_bug.cgi?id=28060 >> >> v5: >>      - try to improve name: backer_port_id instead of parent_port_id >>      - init new field to RTE_MAX_ETHPORTS on allocation to avoid >>        zero port usage by default >> >> v4: >>      - apply mlx5 review notes: remove fallback from generic ethdev >>        code and add fallback to mlx5 code to handle legacy usecase >> >> v3: >>      - fix mlx5 build breakage >> >> v2: >>      - fix mlx5 review notes >>      - try device port ID first before parent in order to address >>        backward compatibility issue [snip]