DPDK patches and discussions
 help / color / mirror / Atom feed
From: mamcgove@microsoft.com
To: dev@dpdk.org
Cc: Matthew G McGovern <mamcgove@microsoft.com>
Subject: [PATCH 1/2] examples/symmetric-mp: ignore promisc enable failure
Date: Tue, 16 Sep 2025 10:44:09 -0700	[thread overview]
Message-ID: <7ddd45fc1dc033cc595964167cc8469e4b5f7930.1758043370.git.mamcgove@microsoft.com> (raw)
In-Reply-To: <cover.1758043370.git.mamcgove@microsoft.com>
In-Reply-To: <cover.1758043370.git.mamcgove@microsoft.com>

From: Matthew G McGovern <mamcgove@microsoft.com>

Problem: Some devices do not allow promiscuous mode.

Testpmd handles this by warning and ignoring failures from
rte_eth_promiscuous_enable.

Changes: make symmetric-mp warn if promiscuous mode cannot be
enabled, rather than failing.

Signed-off-by: Matthew G McGovern <mamcgove@microsoft.com>
---
 examples/multi_process/symmetric_mp/main.c | 4 +++-
 1 file changed, 3 insertions(+), 1 deletion(-)

diff --git a/examples/multi_process/symmetric_mp/main.c b/examples/multi_process/symmetric_mp/main.c
index f7d8439cd4..22ede756fd 100644
--- a/examples/multi_process/symmetric_mp/main.c
+++ b/examples/multi_process/symmetric_mp/main.c
@@ -275,7 +275,9 @@ smp_port_init(uint16_t port, struct rte_mempool *mbuf_pool,
 
 	retval = rte_eth_promiscuous_enable(port);
 	if (retval != 0)
-		return retval;
+		fprintf(stderr,
+			"Error during enabling promiscuous mode for port %u: %s - ignore\n",
+			retval, rte_strerror(-retval));
 
 	retval  = rte_eth_dev_start(port);
 	if (retval < 0)
-- 
2.34.1


  reply	other threads:[~2025-09-16 17:44 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2025-05-20 18:37 [PATCH] examples/symmetric_mp: log/ignore promiscuous fail mamcgove
2025-07-09 14:29 ` Thomas Monjalon
2025-09-03 15:09   ` [EXTERNAL] " Matthew McGovern (LINUX)
2025-09-03 15:24     ` Thomas Monjalon
2025-09-16 17:44 ` [PATCH 0/2] " mamcgove
2025-09-16 17:44   ` mamcgove [this message]
2025-09-16 17:44   ` [PATCH 2/2] examples/mp_server: warn on promisc enable failure mamcgove
     [not found] ` <cover.1758045692.git.mamcgove@microsoft.com>
2025-09-16 18:51   ` [PATCH v3 1/1] " mamcgove

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=7ddd45fc1dc033cc595964167cc8469e4b5f7930.1758043370.git.mamcgove@microsoft.com \
    --to=mamcgove@microsoft.com \
    --cc=dev@dpdk.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).