From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mx1.redhat.com (mx1.redhat.com [209.132.183.28]) by dpdk.org (Postfix) with ESMTP id AB8AB1B168 for ; Tue, 9 Jan 2018 09:56:58 +0100 (CET) Received: from smtp.corp.redhat.com (int-mx05.intmail.prod.int.phx2.redhat.com [10.5.11.15]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mx1.redhat.com (Postfix) with ESMTPS id 11613629C6; Tue, 9 Jan 2018 08:56:58 +0000 (UTC) Received: from [10.36.112.39] (ovpn-112-39.ams2.redhat.com [10.36.112.39]) by smtp.corp.redhat.com (Postfix) with ESMTPS id 7BEE35D6A2; Tue, 9 Jan 2018 08:56:56 +0000 (UTC) To: Junjie Chen , yliu@fridaylinux.org, xiao.w.wang@intel.com, tiwei.bie@intel.com, lei.a.yao@intel.com Cc: dev@dpdk.org References: <1514310190-140916-1-git-send-email-junjie.j.chen@intel.com> <1515495828-190409-1-git-send-email-junjie.j.chen@intel.com> From: Maxime Coquelin Message-ID: <7de135de-b830-23d7-a725-729b814137a7@redhat.com> Date: Tue, 9 Jan 2018 09:56:54 +0100 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.5.0 MIME-Version: 1.0 In-Reply-To: <1515495828-190409-1-git-send-email-junjie.j.chen@intel.com> Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: 7bit X-Scanned-By: MIMEDefang 2.79 on 10.5.11.15 X-Greylist: Sender IP whitelisted, not delayed by milter-greylist-4.5.16 (mx1.redhat.com [10.5.110.25]); Tue, 09 Jan 2018 08:56:58 +0000 (UTC) Subject: Re: [dpdk-dev] [PATCH v7] vhost: support virtqueue interrupt/notification suppression X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 09 Jan 2018 08:56:58 -0000 On 01/09/2018 12:03 PM, Junjie Chen wrote: > The driver can suppress interrupt when VIRTIO_F_EVENT_IDX feature bit is > negotiated. The driver set vring flags to 0, and MAY use used_event in > available ring to advise device interrupt util reach an index specified > by used_event. The device ignore the lower bit of vring flags, and send > an interrupt when index reach used_event. > > The device can suppress notification in a manner analogous to the ways > driver suppress interrupt. The device manipulates flags or avail_event in > the used ring in the same way the driver manipulates flags or used_event in > available ring. > > Signed-off-by: Junjie Chen > --- > v7: > Add vhost_need_event definition and update code for next virtio. > > v6: > Use volatile qualifier to access avail event idx. > > v5: > Remove updating avail event index in backend. > > v2-v4: > Use definition of VIRTIO_F_EVENT_IDX from kernel. > > lib/librte_vhost/vhost.c | 2 +- > lib/librte_vhost/vhost.h | 44 ++++++++++++++++++++++++++++++++++++++----- > lib/librte_vhost/virtio_net.c | 6 +++--- > 3 files changed, 43 insertions(+), 9 deletions(-) Reviewed-by: Maxime Coquelin Thanks, Maxime