From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id DD4EAA04B0; Fri, 7 Aug 2020 19:00:06 +0200 (CEST) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id EB47C2BF2; Fri, 7 Aug 2020 19:00:05 +0200 (CEST) Received: from mx0a-001b2d01.pphosted.com (mx0a-001b2d01.pphosted.com [148.163.156.1]) by dpdk.org (Postfix) with ESMTP id 1E5461DBF for ; Fri, 7 Aug 2020 19:00:03 +0200 (CEST) Received: from pps.filterd (m0187473.ppops.net [127.0.0.1]) by mx0a-001b2d01.pphosted.com (8.16.0.42/8.16.0.42) with SMTP id 077GVniR056008; Fri, 7 Aug 2020 13:00:00 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=ibm.com; h=subject : from : to : cc : references : message-id : date : mime-version : in-reply-to : content-type : content-transfer-encoding; s=pp1; bh=9EfG5vfgiRvRpgs4641Y+BrDaXmAcx7s1B+DOGddH8k=; b=WRchUcFSkAwi4aAsx1uSck7CNypO2CBVzMSdkNy5C53oEOKylDV10Ce27FYE+XL5XH1Y lAKo0WYbM+/qMBXE7j5Y0yGo4Cq744sv8WU+DsdCOsLrd9x9fDfKqOv8egzkDI4ZKAkj GliNsRH13NUPcCunorJGnZBJ7AQUS2aiKtaTw6CYLTX9z3A8NISsgLrS++OpOjsrLYnf qgeT0mfiFpwLgB1dWzMWvtPMC1pHfftKT6GBfCOof8pBTkJqYrZizqpXB4oP/EguDWkd kKvKWolrafpyDx0PO5uIewW0rhkAwq7ql0FWELu3XqLNR7NbD/3pUrAiYn+24Z7D8rri GA== Received: from ppma01dal.us.ibm.com (83.d6.3fa9.ip4.static.sl-reverse.com [169.63.214.131]) by mx0a-001b2d01.pphosted.com with ESMTP id 32rg3pja63-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Fri, 07 Aug 2020 12:59:59 -0400 Received: from pps.filterd (ppma01dal.us.ibm.com [127.0.0.1]) by ppma01dal.us.ibm.com (8.16.0.42/8.16.0.42) with SMTP id 077Gxx2S028292; Fri, 7 Aug 2020 16:59:59 GMT Received: from b01cxnp23033.gho.pok.ibm.com (b01cxnp23033.gho.pok.ibm.com [9.57.198.28]) by ppma01dal.us.ibm.com with ESMTP id 32n01a8n2x-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Fri, 07 Aug 2020 16:59:59 +0000 Received: from b01ledav002.gho.pok.ibm.com (b01ledav002.gho.pok.ibm.com [9.57.199.107]) by b01cxnp23033.gho.pok.ibm.com (8.14.9/8.14.9/NCO v10.0) with ESMTP id 077Gxw8h56426894 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK); Fri, 7 Aug 2020 16:59:58 GMT Received: from b01ledav002.gho.pok.ibm.com (unknown [127.0.0.1]) by IMSVA (Postfix) with ESMTP id 3A949124053; Fri, 7 Aug 2020 16:59:58 +0000 (GMT) Received: from b01ledav002.gho.pok.ibm.com (unknown [127.0.0.1]) by IMSVA (Postfix) with ESMTP id 6852C124052; Fri, 7 Aug 2020 16:59:57 +0000 (GMT) Received: from Davids-MBP.randomparity.org (unknown [9.163.7.45]) by b01ledav002.gho.pok.ibm.com (Postfix) with ESMTP; Fri, 7 Aug 2020 16:59:57 +0000 (GMT) From: David Christensen To: Ciara Power , dev@dpdk.org Cc: bruce.richardson@intel.com, Ruifeng Wang , Jerin Jacob , Honnappa Nagarahalli References: <20200807155859.63888-1-ciara.power@intel.com> <20200807155859.63888-3-ciara.power@intel.com> <25416a77-6ce1-0770-d304-2dfa1fe23c73@linux.vnet.ibm.com> Message-ID: <7e973d03-c839-995e-0b9a-cea4058d8050@linux.vnet.ibm.com> Date: Fri, 7 Aug 2020 09:59:56 -0700 User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.15; rv:68.0) Gecko/20100101 Thunderbird/68.11.0 MIME-Version: 1.0 In-Reply-To: <25416a77-6ce1-0770-d304-2dfa1fe23c73@linux.vnet.ibm.com> Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: 8bit X-TM-AS-GCONF: 00 X-Proofpoint-Virus-Version: vendor=fsecure engine=2.50.10434:6.0.235, 18.0.687 definitions=2020-08-07_12:2020-08-06, 2020-08-07 signatures=0 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 phishscore=0 suspectscore=0 bulkscore=0 priorityscore=1501 clxscore=1015 lowpriorityscore=0 mlxlogscore=999 malwarescore=0 adultscore=0 mlxscore=0 spamscore=0 impostorscore=0 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.12.0-2006250000 definitions=main-2008070112 Subject: Re: [dpdk-dev] [PATCH 20.11 02/12] eal: add default SIMD bitwidth values X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" On 8/7/20 9:31 AM, David Christensen wrote: > On 8/7/20 8:58 AM, Ciara Power wrote: >> Each arch has a define for the default SIMD bitwidth value, this is used >> on EAL init to set the config max SIMD bitwidth. > > What's the intended use case? > >> >> Cc: Ruifeng Wang >> Cc: Jerin Jacob >> Cc: Honnappa Nagarahalli >> Cc: David Christensen >> >> Signed-off-by: Ciara Power >> --- >>   lib/librte_eal/arm/include/rte_vect.h      | 2 ++ >>   lib/librte_eal/common/eal_common_options.c | 3 +++ >>   lib/librte_eal/include/generic/rte_vect.h  | 2 ++ >>   lib/librte_eal/ppc/include/rte_vect.h      | 2 ++ >>   lib/librte_eal/x86/include/rte_vect.h      | 2 ++ >>   5 files changed, 11 insertions(+) >> >> diff --git a/lib/librte_eal/arm/include/rte_vect.h >> b/lib/librte_eal/arm/include/rte_vect.h >> index 01c51712a1..7487a53862 100644 >> --- a/lib/librte_eal/arm/include/rte_vect.h >> +++ b/lib/librte_eal/arm/include/rte_vect.h >> @@ -14,6 +14,8 @@ >>   extern "C" { >>   #endif >> >> +#define RTE_DEFAULT_SIMD_BITWIDTH 256 >> + >>   typedef int32x4_t xmm_t; >> >>   #define    XMM_SIZE    (sizeof(xmm_t)) >> diff --git a/lib/librte_eal/common/eal_common_options.c >> b/lib/librte_eal/common/eal_common_options.c >> index 90f4e8f5c3..c2a9624f89 100644 >> --- a/lib/librte_eal/common/eal_common_options.c >> +++ b/lib/librte_eal/common/eal_common_options.c >> @@ -35,6 +35,7 @@ >>   #ifndef RTE_EXEC_ENV_WINDOWS >>   #include >>   #endif >> +#include >> >>   #include "eal_internal_cfg.h" >>   #include "eal_options.h" >> @@ -344,6 +345,8 @@ eal_reset_internal_config(struct internal_config >> *internal_cfg) >>       internal_cfg->user_mbuf_pool_ops_name = NULL; >>       CPU_ZERO(&internal_cfg->ctrl_cpuset); >>       internal_cfg->init_complete = 0; >> +    internal_cfg->max_simd_bitwidth.bitwidth = >> RTE_DEFAULT_SIMD_BITWIDTH; >> +    internal_cfg->max_simd_bitwidth.locked = 0; >>   } > > Build error on HEAD: > > ../lib/librte_eal/common/eal_common_options.c: In function > ‘eal_reset_internal_config’: > ../lib/librte_eal/common/eal_common_options.c:347:14: error: ‘struct > internal_config’ has no member named ‘max_simd_bitwidth’ >   internal_cfg->max_simd_bitwidth.bitwidth = RTE_DEFAULT_SIMD_BITWIDTH; >               ^~ > ../lib/librte_eal/common/eal_common_options.c:348:14: error: ‘struct > internal_config’ has no member named ‘max_simd_bitwidth’ >   internal_cfg->max_simd_bitwidth.locked = 0; >               ^~ Sorry, jumped the gun when testing the patch, missed the preceeding patch. Dave