From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id D1E1643EF9; Wed, 24 Apr 2024 20:02:55 +0200 (CEST) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id A8968435C0; Wed, 24 Apr 2024 20:02:55 +0200 (CEST) Received: from NAM10-MW2-obe.outbound.protection.outlook.com (mail-mw2nam10on2062.outbound.protection.outlook.com [40.107.94.62]) by mails.dpdk.org (Postfix) with ESMTP id EC752435BE for ; Wed, 24 Apr 2024 20:02:53 +0200 (CEST) ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=Gq0ztAWY7lDNF4ohiZZvyTgcPDeJ+m5sLnhUSBhAyBgbqmpn67mbrz1Y1HVAj5KXRy7DB8rRCHlpnCt1eFk0z+OAQWQ+AgrTfpVr7P2yUx6bWc51CPLcq4huQI52tLT+/8Ut7wo9GHTSwBvJRDxp1/RSSVIT78LLTTYudz/xcHoFdNH3xeqdivdSOjefCmf+bI8vqMBG6e5Ssfqawk3mteLmPlAzFyp6XMPSlGTiKOYFw8EazeaLQidWpX/Knhs1L+MvoKlQpJ97BeY45pZRzsxwco8ScammqRNakGgn70fQa6T6KdxsohRp6zA172gAzHeJ7zoO/vMv7OZ+1xgsoQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=NDNMkGOFqHvqnblkmWaoqd1K47P9QvfTJuoIjkG/L1g=; b=Wh2oee0B6UDuDcVhRJeBvAfhgJBG3HxtcGFfdnfKUgVKBvLI39zyjuMFD23c8t3C7O2mtRvWsCOx6C0lOdRhca8PbYwrFe98BVWkRO8PZN7rxswowfXzt72rzgiuEisstZr7u2sfRD0utspDkbfg5jwAK5Tg8+TRkBoiY6L6MjWAM11TIbA9Bvcccyjd/eclnz92fvTmGWonqPptdzduPxY4n4WbkQQAMx0+PuINBenYhSfZO16gdE93aJ3WKbermG4LyRkBJWrrtmyGAovnW2u2Gr0NKTh4iBVKWS/jt/6khMPXEXm2ZFpMwzAJLi44RlYyquwRGAc+lBy0TjXdlw== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=amd.com; dmarc=pass action=none header.from=amd.com; dkim=pass header.d=amd.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=amd.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=NDNMkGOFqHvqnblkmWaoqd1K47P9QvfTJuoIjkG/L1g=; b=amZgjmieylaGkBhaKH5/oZ5sOmQ+x2CmHs9pCu9YECf+0tCoYh/1llrtZnQwNa5zGS+9rW/P6MMLv6KtjLdF56IXiDVJZnLbb3lIM1kBuNUQacBzcDExtbxDxG42MoOP5A7zRLT1sEvyj9un1vDVDVoFQDguCd50kHfi1SeSMpI= Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=amd.com; Received: from CH2PR12MB4294.namprd12.prod.outlook.com (2603:10b6:610:a9::11) by DM6PR12MB4108.namprd12.prod.outlook.com (2603:10b6:5:220::18) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.7519.24; Wed, 24 Apr 2024 18:02:51 +0000 Received: from CH2PR12MB4294.namprd12.prod.outlook.com ([fe80::282f:29d3:cac1:cde3]) by CH2PR12MB4294.namprd12.prod.outlook.com ([fe80::282f:29d3:cac1:cde3%7]) with mapi id 15.20.7472.044; Wed, 24 Apr 2024 18:02:51 +0000 Message-ID: <7e987e8c-27f4-42e5-81f8-3b768e9f150c@amd.com> Date: Wed, 24 Apr 2024 19:02:47 +0100 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH] net/af_packet: cache align Rx/Tx structs To: Bruce Richardson Cc: =?UTF-8?Q?Mattias_R=C3=B6nnblom?= , =?UTF-8?Q?Mattias_R=C3=B6nnblom?= , "John W . Linville" , dev@dpdk.org, Tyler Retzlaff , Honnappa Nagarahalli References: <20240423090813.94110-1-mattias.ronnblom@ericsson.com> <6f7aabcb-2c12-4cfe-ae9d-73b42bfd4977@amd.com> <63dbb564-61f6-4d9f-9c13-4a21f5e97dc9@lysator.liu.se> <5d2a0887-527a-4948-943c-65f1dfda9328@amd.com> Content-Language: en-US From: Ferruh Yigit Autocrypt: addr=ferruh.yigit@amd.com; keydata= xsFNBGJDD3EBEAC/M7Tk/DfQSmP1K96vyzdhfSBzlCaGtcxNXorq4fALruqVsD3oi0yfyEz9 4YN8x7py0o9EL8ZdpOX0skc0AMCDAaw033uWhCn0GLMeGRKUbfOAPvL6ecSDvGD7CJIO9j0J eZUvasBgPdM/435PEr9DmC6Ggzdzt8IuG4PoLi5jpFSfcqxZFCCxLUDEo/w0nuguk2FTuYJg B2zEZ4JTBZrw7hIHiFh8D8hr6YA6a5uTofq1tr+l048lbtdFUl8TR0aIExVzE4Z8qKZlcE+9 RQaewjK5Al1jLE4sHdmd3GN+IvgDF3D/fLsi25SKJDeGSdeHkOmaX0qGeM4WKIfU6iARRCiQ N3AmBIxZ/A7UXBKLaOyZ+/i3sE6Wb53nrO4i8+0K2Qwyh6LjTeiJAIjYKN43ppxz3DaI+QwQ vI+uyHr4Gg0Da9EPPz/YyKauSeOZCfCB5gIfICO0j6x0SCl8uQ2nLpjxcZkf0gjcwUzP3h+S 3x6NfDji9YEij0zczW/dcSpGgZ6vsFpPrtnP9ZXy6J53yp0kJtOJoOlkEFFdU2yCZnCDseum CoudmGLZVvS0/DzHDJejq+3kK3FDGktZBOxZIIpal+nFqS7lVgOZc4+huVv3jyhzoAUOEyXA XK5j6o7g8STUY+z33QNnHpdLvecMwuzmvqy0jR54yAbZ64mB9QARAQABzSNGZXJydWggWWln aXQgPGZlcnJ1aC55aWdpdEBhbWQuY29tPsLBlwQTAQgAQQIbAwULCQgHAgYVCgkICwIEFgID AQIeAQIXgAIZARYhBEm7aYjps5XGsPHCElRTPtCKKm/6BQJkdyEEBQkE3meNAAoJEFRTPtCK Km/6UdcP/0/kEp49aIUhkRnQfmKmNVpcBEs4NqceNCWTQlaXdEwL1lxf1L49dsF5Jz1yvWi3 tMtq0Mk1o68mQ7q8iZAzIeLxGQAlievMNE0BzLWPFmuX+ac98ITBqKdnUAn6ig5ezR+jxrAU 58utUszDl16eMabtCu76sINL5izB8zCWcDEUB4UqM8iBSQZ7/a7TSBVS0jVBldAORg1qfFIs cGMPQn/skhy3QqbK3u3Rhc44zRxvzrQJmhY6T1rpeniHSyGOeIYqjpbpnMU5n1VWzQ4NXvAD VDkZ4NDw6CpvF4S2h2Ds7w7GKvT6RRTddrl672IaLcaWRiqBNCPm+eKh4q5/XkOXTgUqYBVg Ors8uS9EbQC/SAcp9VHF9fB+3nadxZm4CLPe5ZDJnSmgu/ea7xjWQYR8ouo2THxqNZtkercc GOxGFxIaLcJIR/XChh9d0LKgc1FfVARTMW8UrPgINVEmVSFmAVSgVfsWIV+NSpG9/e90E4SV gMLPABn1YpJ8ca/IwqovctqDDXfxZOvCPOVWTzQe/ut767W+ctGR1kRkxWcz470SycOcY+PW VRPJd91Af0GdLFkwzZgNzkd6Gyc9XXcv4lwwqBLhWrBhqPYB0aZXIG1E/cVTiRp4dWpFHAFD DcuLldjIw93lCDsIeEDM9rBizGVMWEoeFmqSe7pzGTPXzsFNBGJDD3EBEAC8fBFQHej8qgIG CBzoIEd1cZgPIARlIhRudODXoNDbwA+zJMKtOVwol3Hh1qJ2/yZP11nZsqrP4fyUvMxrwhDe WBWFVDbWHLnqXMnKuUU1vQMujbzgq/4Rb9wSMW5vBL6YxhZng+h71JgS/9nVtzyaTtsOTrJi 6nzFSDx6Wbza2jYvL9rlK0yxJcMEiKwZQ/if4KcOesD0rtxomU/iSEv6DATcJbGXP6T93nPl 90XksijRKAmOwvdu3A8IIlxiSSVRP0lxiHOeR35y6PjHY2usfEDZZOVOfDfhlCVAIBZUZALv VmFOVSTYXeKgYa6Ooaf72+cHM3SgJIbYnevJfFv8YQW0MEAJ/IXE7B1Lk+pHNxwU3VBCrKnA fd/PTvviesuYRkrRD6qqZnINeu3b2DouVGGt2fVcGA38BujCd3p8i7azoGc7A6cgF7z9ETnr ANrbg1/dJyDmkDxOxVrVquTBbxJbDy2HaIe9wyJTEK2Sznpy62DaHVY+gfDQzexBXM10geHC IIUhEnOUYVaq65X3ZDjyAQnNDBQ4uMqSHZk8DpJ22X+T+IMzWzWl+VyU4UZXjkLKPvlqPjJk 1RbKScek5L2GhxHQbPaD76Hx4Jiel0vm2G+4wei8Ay1+0YRFkhySxogU/uQVXHTv63KzQMak oIfnN/V2R0ucarsvMBW+gwARAQABwsF8BBgBCAAmAhsMFiEESbtpiOmzlcaw8cISVFM+0Ioq b/oFAmR3IPsFCQTeZ44ACgkQVFM+0Ioqb/qINhAAtcor9bevHy22HvJvXX17IOpPSklZJAeQ Az43ZEo5kRlJ8mElc2g3RzYCvL/V3fSiIATxIsLq/MDtYhO8AAvklxND/u2zeBd7BkRZTZZX W1V1cM3oTvfx3LOhDu4f2ExQzCGdkzbXTRswSJIe1W0qwsDp+YPekbrsKp1maZArGeu+6FuW honeosIrWS98QJmscEhP8ooyJkLDCCOgEk+mJ/JBjzcJGuYn6+Iy/ApMw/vqiLGL1UWekcTA g18mREHqIR+A3ZvypIufSFB52oIs1zD/uh/MgmL62bY/Cw6M2SxiVxLRsav9TNkF6ZaNQCgn GqifliCEMvEuLZRBOZSYH2A/PfwjYW0Ss0Gyfywmb2IA990gcQsXxuCLG7pAbWaeYazoYYEQ NYmWatZNMAs68ERI2zvrVxdJ/fBWAllIEd0uQ4P05GtAHPdTIDQYp545+TPV7oyF0LfXcsQs SFVZE6igdvkjfYmh+QOrHGZvpWXLTmffVf/AQ81wspzbfxJ7sYM4P8Mg5kKOsaoUdyA/2qVe cMh1CLUHXF1GlofpGbe1lj4KUJVse5g3qwV7i9VrseA8c4VIZewdIjkzAhmmbxl+8rM/LKBH dZUMTzME5PFCXJIZ83qkZQ795MTe2YScp9dIV7fsS5tpDwIs7BZNVM1l3NAdK+DLHqNxKuyO 8Zk= In-Reply-To: Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit X-ClientProxiedBy: LO4P123CA0561.GBRP123.PROD.OUTLOOK.COM (2603:10a6:600:33b::10) To CH2PR12MB4294.namprd12.prod.outlook.com (2603:10b6:610:a9::11) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: CH2PR12MB4294:EE_|DM6PR12MB4108:EE_ X-MS-Office365-Filtering-Correlation-Id: 1aad970f-9980-4f87-7e57-08dc6488c1f8 X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0;ARA:13230031|376005|1800799015|366007; X-Microsoft-Antispam-Message-Info: =?utf-8?B?Uy9ObENiaDNEeGNyZzdJK2pEV0lib29UQzNuRUZ0U0xDdVZPMlNhdXVjYkZI?= =?utf-8?B?eFhTM09UbTB1RU5wd1JHZnh0T1NUcnprNlRFWGc2c1NYRHJwTlcraEdMdWtN?= =?utf-8?B?MmJVOWdaN2YvVDNRaW1xWFR2bHMzQjVPd0FDc2p3MmFtekYyT3MvNU81OHV0?= =?utf-8?B?TWxCTGtjTWUvZ0xuNUl0ZkpFZW1kZFpJOEVycjM2b0VmZmtOaUFPdkZ4L3h1?= =?utf-8?B?cHZpR083ZVBTUXZUdEpIbFlTRi9TbUVXM1VVWGdLUExIdFJMY2o3Y0NuVkZn?= =?utf-8?B?Qm9uWnhkRHEydW1NeHcvSlE3RURhOUF5NmxCbHR4bEZHQWJJQ2ZWb2lEN1VE?= =?utf-8?B?VHRsQUorYjYyVEdaSkhPNzNvTjBweGthOEdxa2pUbGxhejBmV01oVnlZQ2lt?= =?utf-8?B?UTJXaGZ3SW9OSU1rWmlsMFp2a1VwVUdFR0liRTFId2FQOGQ1RGV3akhwNEg5?= =?utf-8?B?SEs0elFpdFhPRnVPZy9oTzEwbGJib2ptV1hHL3lFei9xM0dUT0g3Q0lZRFlT?= =?utf-8?B?NSt6WjlFUzhMWjBVVndPUjgvREtiOEUxOGd3WitwVDJlajEyN2VPTEx3dHhL?= =?utf-8?B?VTZDbjM5Mm1vYWhVTjMvVHhwdjZxb242TlVsRW9FVGhGNmhXVHhhdDM4T2d4?= =?utf-8?B?S1ZPWXZhYkJQY2pBS2ljdVhQZ0RwVVF2cnRHYmVBc3BCcXY3OVJoYUxRNHpv?= =?utf-8?B?TWtoQzJMM0s5cXVqZzZPdXlHSXZZVVp1dTNIWC8wZlRGdnlidFFxR1JIZG5v?= =?utf-8?B?RDdJcXg3bHpLUHVwaTdVVGs2eVA4aXhRSjhUWGJKLzZienMrUjlLUkl2Qm1P?= =?utf-8?B?YTZES2VxREQ1VlVNQW1JcW16dm5TV0xJTTRYa0EzZk45cVExMit2Q0QvdTRv?= =?utf-8?B?MGRMZnFDZnNWeXcvOVhHTWZGaUp4bWpFVEVCNDZmQXpveWFRTGNzK0lHaVUw?= =?utf-8?B?WENYOGlSckdjS1ZNMFdLMHdXQVNJNm42SGRuNkNiVVNWUnpubDByWlVlN1pt?= =?utf-8?B?c0xnUWxlVCt4djZSL1NEK0dWNWhqSmtSMTJES2YrNjRSa3lyUGZxNFRUOHp3?= =?utf-8?B?Vm9WTDRDM0s2M3NwTk9WeUVjVDhYZ29udW4vOHJDeS93cmg3MXZWSzZ2RjI5?= =?utf-8?B?VXpBVVZ2VThVeXIwbmg2SDdENlJpNkR5QzJQRkxyS3grMTlQV1I2bzlhRGQ1?= =?utf-8?B?NmZONlByWlZHbXFIVTdiWllxVnZzV3RaTVBVaS9MVEtLV29uclVsZDRJaEVF?= =?utf-8?B?ZXBlcmRiZHFHSElLaHRtWXRyZWY3T2ZKaERMb3lTZ00yOXNKVXZpR0lINDJk?= =?utf-8?B?WWJEV2txNWZEWEQ4azN6MzZjMlpySWFUVUNMUHdVNjhVaUl5d0hneTJLQVBU?= =?utf-8?B?QmNKcS9xKzBMQ0FIcTl2ajJ4VWVWSEV2QjY5RFI4SEc3aUFUTHZrOVhtdlU4?= =?utf-8?B?K1dUdUZ3MkdnN1lmSWNjVWxWOHZheERhZlEwRmtnQ3dGNi9Rb3hGUmhwaUds?= =?utf-8?B?NURNbWdZWFpYZE5QdHN5SnVKYlI0VnowV0E2UlNFZHg1SFNrdUJzVGhLNUtP?= =?utf-8?B?SlkvSThXNE10c2llRjhoeXFIL29jMm1JYTJGaUJXdnU5UkZoaW4wSVBRN21R?= =?utf-8?B?T1ArZGovanMzU0JDTWwzR3hqRUYxMEJzdUlZRkh2dlNnQjdINmZvSTVsczhn?= =?utf-8?B?YUNqQU93WmdnNldNaERhNmY3c2ZqSC9JYXpUT0FINnIyaG9JblUwd2RBPT0=?= X-Forefront-Antispam-Report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:CH2PR12MB4294.namprd12.prod.outlook.com; PTR:; CAT:NONE; SFS:(13230031)(376005)(1800799015)(366007); DIR:OUT; SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?OCtYN1Z0bU9nTlZNa0xoOFg0VU5tY3VhZitMK0JmckZaZXZMeUhUQllpalVS?= =?utf-8?B?TkJIZHA3UFI2N2dtZ0tndFpTdWFwRjR4VjY4dGdSbmlwQ05ram9oN1preUVS?= =?utf-8?B?MUNWQTBmRWNnSTR2clZvOENKMTN4Rnc2eEZuSEdicGhaLzZaWEthSE9zd2NY?= =?utf-8?B?cHo2S3NMdEd6UW9hMmNXYUQ5NUpSNWI5TXJvckNuckV0a0xpV3NOSlR0THdU?= =?utf-8?B?T2dxclNvQkxvV0hYWW1xcElya1lUMzlMWlE3QWd3cnJ0RzVRSUdlRml3M0VH?= =?utf-8?B?cEVnakJwaWoycStxemgwQXBMci9LbThkZnk3NFpLTGlmcGE0dEVXeHpDU3Q4?= =?utf-8?B?YUNyenovNjY4OVZHTFlIc3ZwclhZQlVINzQxQjBFL0NDMXBlVWJvRDU3QUty?= =?utf-8?B?NC9OSFVyd01kY2I4Rmo2KzdITStnVDlaTHBrN2pUQ09tV01veTBVN1BYK3lz?= =?utf-8?B?aWxjek5yUDEzZXJsWktZdzFsOXYwNEltWjBneHdJWU5ZQ215ZnFRTkRqTjZw?= =?utf-8?B?L0NRZFJNSEdpbFBoZ1FGN1JlMEVpNkNyUnpYMW5DQ05QN25ocDZxUmt1Yy83?= =?utf-8?B?TGQxeGp6QmhGSTF5RERaRlBpVnRwQjVmVVgzeWtaeEMvcmEvRWZKQ1plaEpS?= =?utf-8?B?LzhLbDkvY0RMM3d4a29uYS9NR3N2RGxBcmVsbExKWEhXeUFjdnFNT3ZRRE1q?= =?utf-8?B?TzI3azBRZ0d0TEFtUm55Q1NudXdXSlh1Q2hZWXBsUWZVTFJaZmtuQmdLaUI0?= =?utf-8?B?RGNXbzNmRzRDdUkyeml1cDNsYnVVb0VXdEhtQ0dKWWpSNDhkU0N3eFRYYlA2?= =?utf-8?B?VEQ3bW8zUTdvRHpLaTVEU0dkYVVpZE1rOTR4RmdKZXFJMERlY2ZoK3FjT2Va?= =?utf-8?B?ZFVvU01XNFROeDIxOHd2dmM0aHhWc21RSkQ1S3U5Z3dFZVI0NlYzOE1hY1Jh?= =?utf-8?B?YzFDUTFwMVQzUkdwVFliQkRqZncycTdWSmM2T254ekNXWFd5RUZQS3p6eGQz?= =?utf-8?B?d1ZSak9QS0lncXNWYW05em5yd2JTUWFqenBjK0J4SHZwTjZCWkZDV0tFYVhu?= =?utf-8?B?dkJyUm5JSUtvR3YzRDNzbHptUUkvalVINEZtcG1pOEUzenRjRTZHR3Z2U0hL?= =?utf-8?B?Wm16ZUJPenRVa1ZEWjVwbTRNNHdBM0pVR05WNnQ3YWRPN0FKVDlVYlNrR0Zj?= =?utf-8?B?STdBRHJJYi81QngrZ0FYcjhMWVNEdytNbkxRaHFrL0ZhNU9wdUw4bWdwYVVt?= =?utf-8?B?d0EzcjFMQVZJWURhajh3NVVGQ1o2TDdRUVk5NVpCVGh2dkoxc2FCcC9GUWJx?= =?utf-8?B?UXJyN2JCNlRRS2JPOVc2K291c1FLYXNBWEhDa1R4QkNyRnhsT1FFOGt1Ritr?= =?utf-8?B?YmZLWEhPN3Urbk9USno4M3g1UDRxZWh2cVVNMENWUDFwT2hqamJxU2FBWHVY?= =?utf-8?B?cllQNkhNQi8vL0ZtRWJPcnlLcGx0a2dhbUxaYWNGUUVkTXZvVS9RWWJ0dWxU?= =?utf-8?B?VHhvWG1zQ3FrbnB2NkdieG1kWkFxaXZMTHhPQzBrVWN4VjJPZ1ZjSjF6L2s0?= =?utf-8?B?YTMxUmg1TmUwZVVqY3JIUUtiL3pnRGcwRW1xSFpTaW1Zek5ZSlk4dVRPakpm?= =?utf-8?B?MkYxUFF6U282T1N0OUEyRExZc1J3bVREVC9ybnNoK2UwWllSUlJ0L2owZXdm?= =?utf-8?B?Qk1meU9aa2htNGt4S2FLL0JWT0x2YjI1Uk5KaVdKeEZjanJVOW9TSzBaU0F1?= =?utf-8?B?RWRRZDRpT05HR1RINHhWYmRiNWFiTTNhb3laUi9tdzlsOC92N2szYXBvQVlp?= =?utf-8?B?OFBXeWthQWIxTnF2c2VLOGtUOXhUcndBMm9CbVc1SnFaZ1lzczduejZQYlRL?= =?utf-8?B?RE5GSFVjajZHTGtmSElmaCtuYUliZnZyT2s5OVJ1M25yNFBTTFAvL2MyNml1?= =?utf-8?B?OXo3ZGUyTjdhNjZVVUFrSDdtWktpVyt4bUlyd2EvQnpOd21uRjU2Z1J4UFp4?= =?utf-8?B?U2VxUFNBZExLTXl6OE5ITldoTzVIck1DTDR5dW9XU2RzM1U4QjlVR0FKZUlW?= =?utf-8?B?dGFZcjdQL1dVOWswbkxCY3FJL2hUa1krZGhtVE1qSWdzVm04dmMwcmI4VVpx?= =?utf-8?Q?5XpifGcAJknnbsC3JH9bMu8Ab?= X-OriginatorOrg: amd.com X-MS-Exchange-CrossTenant-Network-Message-Id: 1aad970f-9980-4f87-7e57-08dc6488c1f8 X-MS-Exchange-CrossTenant-AuthSource: CH2PR12MB4294.namprd12.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 24 Apr 2024 18:02:51.4603 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 3dd8961f-e488-4e60-8e11-a82d994e183d X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: 9v+2dhG7QmV5qlUZ1KsG7VMFAa4jT5LWUtq9DlqyUpLSD8PRpm2tDX98EDbu4BC7 X-MS-Exchange-Transport-CrossTenantHeadersStamped: DM6PR12MB4108 X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org On 4/24/2024 11:28 AM, Bruce Richardson wrote: > On Wed, Apr 24, 2024 at 11:21:52AM +0100, Ferruh Yigit wrote: >> On 4/23/2024 9:56 PM, Mattias Rönnblom wrote: >>> On 2024-04-23 13:15, Ferruh Yigit wrote: >>>> On 4/23/2024 10:08 AM, Mattias Rönnblom wrote: >>>>> Cache align Rx and Tx queue struct to avoid false sharing. >>>>> >>>>> RX struct happens to be 64 bytes on x86_64 already, so cache >>>>> alignment makes no change there, but it does on 32-bit ISAs. >>>>> >>>>> TX struct is 56 bytes on x86_64. >>>>> >>>> >>>> Hi Mattias, >>>> >>>> No objection to the patch. Is the improvement theoretical or do you >>>> measure any improvement practically, if so how much is the >>>> improvement? >>>> >>> >>> I didn't run any benchmarks. >>> >>> Two cores storing to a (falsely) shared cache line on a per-packet >>> basis is going to be very expensive, at least for "light touch" >>> applications. >>> >> >> ack I expect for af_packet bottleneck is the kernel side, so I don't >> expect any visible improvement practically, but OK to fix this >> theoretical issue. >> >>>>> Both structs keep counters, and in the RX case they are updated even >>>>> for empty polls. >>>>> >>>> >>>> Do you think does it help if move 'rx_pkts' & 'rx_bytes' update within >>>> the loop? >>>> >>> >>> No, why? Wouldn't that be worse? Especially since rx_pkts and rx_bytes >>> are declared volatile, so you are forcing a load-modify-store cycle for >>> every increment. >>> >> >> My intention was to prevent updating stats in empty polls, I thought >> stats will be hot in the cache but won't work with volatile. >> > Yes, it will. Volatile only prevents caching in registers, it does not > affect the storing of data within the cache hierarchy. Reads/writes of > stats on empty polls should indeed hit the L1 as expected. However, that is > still less efficient than just doing a register increment which could > theoretically be the result without the volatile. > > Thanks Bruce for clarification.