From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 09037A0A02; Sat, 17 Apr 2021 08:15:59 +0200 (CEST) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id CF73F4068F; Sat, 17 Apr 2021 08:15:59 +0200 (CEST) Received: from szxga04-in.huawei.com (szxga04-in.huawei.com [45.249.212.190]) by mails.dpdk.org (Postfix) with ESMTP id 5C7C240143 for ; Sat, 17 Apr 2021 08:15:58 +0200 (CEST) Received: from DGGEMS402-HUB.china.huawei.com (unknown [172.30.72.58]) by szxga04-in.huawei.com (SkyGuard) with ESMTP id 4FMjSc2MF3z17Qxg; Sat, 17 Apr 2021 14:13:36 +0800 (CST) Received: from [10.67.103.128] (10.67.103.128) by DGGEMS402-HUB.china.huawei.com (10.3.19.202) with Microsoft SMTP Server id 14.3.498.0; Sat, 17 Apr 2021 14:15:53 +0800 To: Thomas Monjalon , David Marchand , Shepard Siegel , Qiming Yang , Xiao Wang , "Rosen Xu" , Maxime Coquelin , , "Yigit, Ferruh" CC: "Mcnamara, John" , Ciara Power References: <1618051221-19962-1-git-send-email-humin29@huawei.com> <9694923.JHvA49bgKg@thomas> From: "Min Hu (Connor)" Message-ID: <7eac5e29-971d-257b-0feb-d0623eaa34ec@huawei.com> Date: Sat, 17 Apr 2021 14:15:53 +0800 User-Agent: Mozilla/5.0 (Windows NT 10.0; WOW64; rv:68.0) Gecko/20100101 Thunderbird/68.3.1 MIME-Version: 1.0 In-Reply-To: <9694923.JHvA49bgKg@thomas> Content-Type: text/plain; charset="utf-8"; format=flowed Content-Transfer-Encoding: 8bit X-Originating-IP: [10.67.103.128] X-CFilter-Loop: Reflected Subject: Re: [dpdk-dev] [PATCH 0/7] support set thread name X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" 在 2021/4/17 2:40, Thomas Monjalon 写道: > 13/04/2021 03:12, Min Hu (Connor): >> 在 2021/4/12 15:19, David Marchand 写道: >>> On Sat, Apr 10, 2021 at 12:40 PM Min Hu (Connor) wrote: >>>> >>>> This set of patches support set thread name for debugging. >>>> >>>> Chengwen Feng (7): >>>> net/ark: support set thread name >>>> net/ice: support set VSI reset thread name >>>> vdpa/ifc: support set notify and vring relay thread name >>>> raw/ifpga: support set monitor thread name >>>> examples/performance-thread: support set thread name >>>> telemetry: support set init threads name >>>> examples/vhost_blk: support set ctrl worker thread name >>> >>> Rather than add those calls, can maintainers check if their component >>> can use ctrl threads instead? >>> rte_ctrl_thread_create ensures both that the name is set, and that the >>> ctrl thread won't run on the same cpu as "datapath" threads. >>> >>> I also saw some issues with components creating threads. >>> I'll post a series addressing those later (net/ark, net/ice not >>> detaching/joining created threads + telemetry not checking >>> pthread_create failures). >>> >> Totally agree with David. >> By the way, for "telemetry not checking pthread_create failures", I have >> sent patches to fix it. Please check it out. >> Thanks. > > Do I understand correctly that we prefer switching > to rte_ctrl_thread_create() instead of this patch series > adding rte_thread_setname()? > > Any volunteer to add the use of rte_ctrl_thread_create() > in these drivers and examples? > Hi, Thomos, we will send next patch to fix it, thanks. > > . >