From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id D6114425CD; Wed, 20 Sep 2023 18:39:19 +0200 (CEST) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id AB44440691; Wed, 20 Sep 2023 18:39:19 +0200 (CEST) Received: from NAM12-BN8-obe.outbound.protection.outlook.com (mail-bn8nam12on2061.outbound.protection.outlook.com [40.107.237.61]) by mails.dpdk.org (Postfix) with ESMTP id 3F495402E4 for ; Wed, 20 Sep 2023 18:39:18 +0200 (CEST) ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=Ub//M8OFUFAaYVwPknqPkf+BW7Gv4iyKb7IhG8N+6nFX7Eb1T4jH7UeE37GASsxewkIo7GMJvEWpHkgg5VgeSHErchTDD1oFWp+tgHqcJ1dF+2kPglP0D7ot1xOptmplbfdxoBCni/NjalOmrC52rBOZLw4IEiZMI4ZyKMceYAtYLNG7E3WrTNSKTmwO19Um/kErH2GnXFnoRUmI+z6xt1TjUjKECEwYQrUvxzUZJ9S5MOW8cSuxr5+CYwbDwYfQM2OG57fs/qSUqVfmUbSJavwZWxTbJ4C9BIVFZ7BOORJSJ061omvjSTv9Bvem/HCllsGFt4FK/iHf8kTRLWkzgQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=J+hTMLgifD8FAmi8qxd73+3BLV9F/bPBTSC4vBLyaLI=; b=nvD8UVINRmc2IJqJPY78mDzne5rbid6+aZar69RyGtm/R+6JjJR7j/Ma5/GKgIJVeCeWmfQ7ZAwbSrZnHZh8Fekj+aQ7eZjWyyNvA+wZzDzeV6OTvDr2FKBCus5WcL5i7h+7sQ/qiD6aJBI+FYq5mITnStoiO4oTmsGtl8v/cMk401NT2zuuuFPq32nz5Psct5EtWpupsKRn18MujNPq9Xl11TknMZr6b24xOYlCb7bf5y4N6Z9YL+jBm1wtiTcyetWzsGgVO8RrETaRFhfvB9zdJwiRts0bl/SL6WDlb3NEKuLU7QeIPwzMxfT8ju2+vXOZ23SftxD2AwI6QrZO7A== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=amd.com; dmarc=pass action=none header.from=amd.com; dkim=pass header.d=amd.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=amd.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=J+hTMLgifD8FAmi8qxd73+3BLV9F/bPBTSC4vBLyaLI=; b=yQ+OENqwVYVVc5H8GCFGlUGsCaNisCnYK4+EMR/GR7CdQ0F8aEZyXPinuAkdUeyRMBAQQdChWA4hoYnrVmokr0CmUpppZo2DTcdDiCID32ZnC2HnsTmTstmE4VlijQUVcbPLdViI9XSE29qBOqedLc7o8cpSJRFamdVhZzrYl0s= Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=amd.com; Received: from CH2PR12MB4294.namprd12.prod.outlook.com (2603:10b6:610:a9::11) by PH8PR12MB7026.namprd12.prod.outlook.com (2603:10b6:510:1bd::19) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6792.27; Wed, 20 Sep 2023 16:39:12 +0000 Received: from CH2PR12MB4294.namprd12.prod.outlook.com ([fe80::102f:c69b:d3e5:7fe8]) by CH2PR12MB4294.namprd12.prod.outlook.com ([fe80::102f:c69b:d3e5:7fe8%4]) with mapi id 15.20.6792.026; Wed, 20 Sep 2023 16:39:12 +0000 Message-ID: <7eaf8d21-e86f-4f59-b126-aa8eac72a6f1@amd.com> Date: Wed, 20 Sep 2023 17:39:05 +0100 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v4 1/7] ethdev: recomment some definitions related to RSS Content-Language: en-US To: Jie Hai , dev@dpdk.org, Thomas Monjalon , Andrew Rybchenko , Ori Kam Cc: lihuisong@huawei.com References: <20230904072851.7384-1-haijie1@huawei.com> <20230908080030.3837515-1-haijie1@huawei.com> <20230908080030.3837515-2-haijie1@huawei.com> From: Ferruh Yigit Autocrypt: addr=ferruh.yigit@amd.com; keydata= xsFNBGJDD3EBEAC/M7Tk/DfQSmP1K96vyzdhfSBzlCaGtcxNXorq4fALruqVsD3oi0yfyEz9 4YN8x7py0o9EL8ZdpOX0skc0AMCDAaw033uWhCn0GLMeGRKUbfOAPvL6ecSDvGD7CJIO9j0J eZUvasBgPdM/435PEr9DmC6Ggzdzt8IuG4PoLi5jpFSfcqxZFCCxLUDEo/w0nuguk2FTuYJg B2zEZ4JTBZrw7hIHiFh8D8hr6YA6a5uTofq1tr+l048lbtdFUl8TR0aIExVzE4Z8qKZlcE+9 RQaewjK5Al1jLE4sHdmd3GN+IvgDF3D/fLsi25SKJDeGSdeHkOmaX0qGeM4WKIfU6iARRCiQ N3AmBIxZ/A7UXBKLaOyZ+/i3sE6Wb53nrO4i8+0K2Qwyh6LjTeiJAIjYKN43ppxz3DaI+QwQ vI+uyHr4Gg0Da9EPPz/YyKauSeOZCfCB5gIfICO0j6x0SCl8uQ2nLpjxcZkf0gjcwUzP3h+S 3x6NfDji9YEij0zczW/dcSpGgZ6vsFpPrtnP9ZXy6J53yp0kJtOJoOlkEFFdU2yCZnCDseum CoudmGLZVvS0/DzHDJejq+3kK3FDGktZBOxZIIpal+nFqS7lVgOZc4+huVv3jyhzoAUOEyXA XK5j6o7g8STUY+z33QNnHpdLvecMwuzmvqy0jR54yAbZ64mB9QARAQABzSNGZXJydWggWWln aXQgPGZlcnJ1aC55aWdpdEBhbWQuY29tPsLBlwQTAQgAQQIbAwULCQgHAgYVCgkICwIEFgID AQIeAQIXgAIZARYhBEm7aYjps5XGsPHCElRTPtCKKm/6BQJjb9DJBQkC+3/YAAoJEFRTPtCK Km/6d94P/irGq3mPa7LamXMIioQ8i6ppMSjpr8g+SxH9RnzbmoUjUY6hVzCpXYxEejiJHubg 7lwD+bOocYpiU8Pe0UncVBhIPNk/dIWQAyH0IWK1nd+hOnjxHv3AQpP80Be2o1mUn3oq/b+B QYiyvvre2gIugYq0hzLcG7z4zREeT+Nl0DMDfnLx+Tj2FAOHrOfudUqjdr/VjF5PoTK0bxnb Brqulp0I0ft7hNsufhzf+TlqaB5l0eQO4gDo5xGTP97TT1cGYsXVMsyDhHqW6P3cuj8kkLkO Ch4oq8OLL8GElgRy5y5svU6CJu3f8hT9aiqIoaRpfNv6N8iEk6g4/HNN+uydb9YCA+1pbwBx skmDhtxQrmXpI+Fmfq0aX2NmqHcy6JR8Ekm/nfwLAW/aDpwoMImVN5pPXtOBSjYi4pj7hiJk UA0ZFi8HCW+fic85p8MXn1GPDmbO82Mm3JVJ1uJNAzGsBbW5SP1ol6+XTeaSxcmzFlrDs8vL XQJMRTpcG6Pti7GbbsOtldvmxRQpq9PmCgQg9IrPXpMoaKE3WwtiSiCALs0kYj4F+hhgAfjI RsOuaAJTnKYW31pC/QdroMNAEqIpLveql03jj+xD9ntJIVAsXiCitsLIXzKP0L5tcHkoVLC3 NAjVYq6XkAEssPF4mMRLoEwpvxOytHe1BCJoRl0YA0aQzsFNBGJDD3EBEAC8fBFQHej8qgIG CBzoIEd1cZgPIARlIhRudODXoNDbwA+zJMKtOVwol3Hh1qJ2/yZP11nZsqrP4fyUvMxrwhDe WBWFVDbWHLnqXMnKuUU1vQMujbzgq/4Rb9wSMW5vBL6YxhZng+h71JgS/9nVtzyaTtsOTrJi 6nzFSDx6Wbza2jYvL9rlK0yxJcMEiKwZQ/if4KcOesD0rtxomU/iSEv6DATcJbGXP6T93nPl 90XksijRKAmOwvdu3A8IIlxiSSVRP0lxiHOeR35y6PjHY2usfEDZZOVOfDfhlCVAIBZUZALv VmFOVSTYXeKgYa6Ooaf72+cHM3SgJIbYnevJfFv8YQW0MEAJ/IXE7B1Lk+pHNxwU3VBCrKnA fd/PTvviesuYRkrRD6qqZnINeu3b2DouVGGt2fVcGA38BujCd3p8i7azoGc7A6cgF7z9ETnr ANrbg1/dJyDmkDxOxVrVquTBbxJbDy2HaIe9wyJTEK2Sznpy62DaHVY+gfDQzexBXM10geHC IIUhEnOUYVaq65X3ZDjyAQnNDBQ4uMqSHZk8DpJ22X+T+IMzWzWl+VyU4UZXjkLKPvlqPjJk 1RbKScek5L2GhxHQbPaD76Hx4Jiel0vm2G+4wei8Ay1+0YRFkhySxogU/uQVXHTv63KzQMak oIfnN/V2R0ucarsvMBW+gwARAQABwsF8BBgBCAAmAhsMFiEESbtpiOmzlcaw8cISVFM+0Ioq b/oFAmNv0PAFCQL7f/8ACgkQVFM+0Ioqb/oU9hAAisAJJ09j/kiEeA1HGKUg3DyFnYW22zRL z1IHYmcHQanMx4+FAwsb1bonVldQMIYNJ9z69UNIU16zIqLZt3D5QK7Je5F5q4NZgfP2jtjX rc3jyu0PuDerFZQyxNcYhhmlF9JO9NV976WYbBAM3AAr0TDohUk+YicYTKab+ZHYOABXbqHX qi+bzDCH1vKBDfpJviprthhK1tIABUK5lsp9aFwFU2jfu2J3XX3pwQhPMjtn2C4v37XUnOqM SJPr2HLU27IW5I3BBpJn7dZE/BkmDmnceHF8E4tRlXCQ/cf81+eErL832sfhVJo1MpubKh3B j89ZLmw0cDXZP2hqlC9vdXnoWWHI8PDPkiw9z11yLrT9Wd4cTJTjFV49Z9G96rgnOtWDcZ1J xHBAnXYQ7V2k9abY+ZqY1PtAPr/smqzQfPHXyTAhRVZp2f3yQmj7UqB07FJuLQjJ4CGk97Qx ///qeSg7D8x/sGEA8Yp2jgIj6u7tspuz+RgBYrWpfI0VIHhWED0jNXzqztrVX18CzA6r0ReY SG+CSyycKkco6UI9ZeUrXFwnoUJqIJY9wTJo5gD9EgGIbItv3qWTq29dihLYpzd6dqB708k7 4RBz9051oLaFVGkguFw/tXmA17nx+c2uR5jx8wb4j68umG2X++0dSta5eHAVhmtXvrqPW6Ku 3FQ= In-Reply-To: <20230908080030.3837515-2-haijie1@huawei.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-ClientProxiedBy: LO4P123CA0627.GBRP123.PROD.OUTLOOK.COM (2603:10a6:600:294::15) To CH2PR12MB4294.namprd12.prod.outlook.com (2603:10b6:610:a9::11) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: CH2PR12MB4294:EE_|PH8PR12MB7026:EE_ X-MS-Office365-Filtering-Correlation-Id: 5615048e-f5bc-490d-a254-08dbb9f81edc X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: CT2w4JoYg6OdobPrl/3IkMiE3YGaBoismfDgKkMgzP9gr/fZ4G+f2UwpVYkkRWC1Ig9VsjEIsm7DD7FK0FF52M095QrOaxAbpGsvx4lKpDPORerpCuo7kKohC2QSjoYVHZBhWI21Xajg/7QbaFzgKya/f5SiID/tBMFSkn2eFa0Fpm/EEUcHEtR4QTeBskDwCOpyBzkAK13PfWVyvd6m9mjtEKF7y7cUMmYIWvQ0zv0E5wNJq8TbCU3v5NwZ1UqlixQpn22Scetx/eqIgZ/jrYWORJ8tm6OuzrJUZUroSlpIMFWfcN/9+5WBl0pSQA4epq0VzwlTDpTxkLb7LNGbdABRH3KtSRfVxv+oqAAFq5x064UAABbjV54FFZXzO8YqxEANhlMhf7aSuK+1yS1nLlQgHygZkdP7luvFbYj0kTdd7PRRDZSaYFNViOntdAVV7A2/2iUUlQdf7xJym03KknLTLcNP7OE3Q2kMt1RrY6Mgd77uLbX8he1hZnCRqVhsZr+RMWuKCqavk4wimTn44UG3vNhRgn6PCCLPSQ37tcNHNWjhZgYc4rc3oBMYDRh7MLWZoisBNLESK+YMf+68NIfw15w0antMMpZfwnWJSgKgSs8bjng/mK+FP0jPo2JGQ3EYPKIkLgK09t1cm3HF8w== X-Forefront-Antispam-Report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:CH2PR12MB4294.namprd12.prod.outlook.com; PTR:; CAT:NONE; SFS:(13230031)(346002)(39860400002)(136003)(366004)(376002)(396003)(451199024)(186009)(1800799009)(44832011)(5660300002)(41300700001)(8676002)(8936002)(4326008)(66946007)(66476007)(66556008)(110136005)(316002)(31686004)(38100700002)(83380400001)(2906002)(31696002)(478600001)(26005)(2616005)(6666004)(6486002)(6506007)(86362001)(53546011)(6512007)(36756003)(45980500001)(43740500002); DIR:OUT; SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?TUI4SUR2MlRYT0hRcjJ0YmpSN1dvRVVFSDlkL0t2MjlHRmlXYjNmQ3VLeE9Y?= =?utf-8?B?Vm1NREFEaTVsNlBvQ2pEL1d2SjdWdlRnVFhYUXBFeDN1SmVxenprcmNOKzRt?= =?utf-8?B?WTFTUGdYamlRYUx0Q25mdExDY2xvWDBibXZuOXhwbTlYN2Y2S2IwSkQxaVN5?= =?utf-8?B?ajUvK2ZoeUQzNmhkeHZBdkt4ZG5MWG9KOEVaMEFCeFMrUDR1YkZxQjRlRkhy?= =?utf-8?B?SWlEQmdhZ3U5Wm5Dd1VFaXNOdWV0K2tOVnR1YklJcG80b2g0UHFtbjVRc3JX?= =?utf-8?B?bzZTZFRBc09XTVZubDJRRUJHNmZuV3lFZUI3TENNZVdsNkJFaWxHd0p1d3NF?= =?utf-8?B?eis0OHovVjU5d1VqKzVxKzlqMkoxeG9Scko2M3ExNldNRU9zS3ovUTVZTFJl?= =?utf-8?B?Zy9KM2ZXN2dHVnhVK25HSGtLTit3a25INSsvU2pmR01sNEI5MDJsRGlZbkxq?= =?utf-8?B?Yy93YUNrTWh1YWVuN1BQaUR0V2dlMkpRS3BYT0NBRkNQa2crU3hVZndHOW1R?= =?utf-8?B?dTdiY0Vwa2JQb3QreXlIaUNTWldPVDVNMEN4aFRqQU9hNHFNc1BBdXFBT0Zn?= =?utf-8?B?cWw3UXNoYVBSTkllL053aCtZMTg4eEQvclNXVXEwNlBBME1BcmNpSkRMaW50?= =?utf-8?B?TVFVY0MvT2ZjME5YS1h4V1I4M3dSUnplUnc0c3Q4NjNiYkNBa0ppYXlVRzIv?= =?utf-8?B?RUhOQkE2NGRtTGN1ejlaNHB6dVpMVnV4NU55azRIcURKL3h0VjY1L1ljMWZw?= =?utf-8?B?cEU3cm9FZzFjWlBoUjVZc3ZzaTFrdTE5eXZCZEkvWXRBcXlVRGNTbkV3RVdR?= =?utf-8?B?Q2VTY0toOFFGbGlBZGxvVjNyd0dJSlJwSURyeXpUeXdaMk5SMktrNnVIOEgw?= =?utf-8?B?Vlh1ZUZJSE54YncvUDZtVjd5MHF6L0ZyeGt4TXRhY1NuZEVsalFKeS9GQVZx?= =?utf-8?B?VHBiclgxdmZjdXkxUmxoQTJlVEFrMk5mcjJNQjBuVCs2c2VLa3ZnZUJwVU0r?= =?utf-8?B?ajdjbXExNWtQTktsemI2OU81Wm1mcWtEN3lsUi93WWswZEhRY0J6ZjUwVWRz?= =?utf-8?B?Snl3UkpFQWl2V0RJVERhcy9Xcm1saENNV0JJdWNaVlpsYlpQazE2bjZwNXhK?= =?utf-8?B?UUgxNTJqdkVPRUd6OExTR1FMV3hDNEZVbUlaekpMYTRtcEZmeWZCMmJBZVpt?= =?utf-8?B?TkY4UmpnR1hveTNYWlp1L3YycC90MUdNa3hjSTdOM05TT25jZnBPUWlCMjYr?= =?utf-8?B?ZFllbEY5U2hGLzZxVGlvR3MwYm5pYUp2Z2g0TVVaanBWalJieUYzMTZEM2pz?= =?utf-8?B?RDJpRU0xNkwwNmFpdXpuQnhVYUFwQ0V1UTRaSXJVWFlRZlJNelRHVGJNVHdU?= =?utf-8?B?Ykd1VnhYQUY0eHNMdHU4NVNFbFpJRUlFem80bVdWUWdwczFxbWlHVS9nbm12?= =?utf-8?B?M29uYXpTZHlCRi9RL1hySHczQnZjUWN4TjF0enZWTnk3cjhZMnhEQ3VoMTU0?= =?utf-8?B?Y1B2c1BteGVLU2k1RXdEUlZDVzlVek5tZmdFMjRSZ2FpcmZ6bHl0ZDlUREQ0?= =?utf-8?B?UHl4aU5obU1Oakt6WDlxNUlnSW41Q1VNUlBGbUoxdzU0bDVVT1hCVFRlaXFv?= =?utf-8?B?N2FuMi9sUlVPcnh1SXlmUXdhNW5meFNIY1NIenYyRWJmZHEydXpmSzN6eW9R?= =?utf-8?B?T2o4OTJWOVVZK3VSVEZUalFIUWpEOWJmR3hIdWZmSkFwN0IwdlBNZ2dadTVa?= =?utf-8?B?QkNNSjE2NHJEMzN3UUpoY3JjdlZrK0owUjloWmN6cjA4aG9Ecm5lRk5uWXJi?= =?utf-8?B?ei9ERnNqeWlscCtlWDgvRUIzL0d0VGtRS2Q5ODFiS2J1Y3lWUklCTTh2YWxK?= =?utf-8?B?aTJyc0lPK2ZsV2JtSVJVVDU5OHdQcmVRU29DS1dqd0ovMnhhcXJ3U3Jhd2Jx?= =?utf-8?B?bS96MHV3dXhLRnpuWVZnSVZMSmF5SGh6Vk5QYUZJOHNONy95bWwzeGdZcW53?= =?utf-8?B?T3dxTVVydWk5T29oaHVHZ1RwSC9BOGNVdFl0a2c5QUNMS2VzSXlhOUhkN2Vo?= =?utf-8?B?dFBKNU40RVRMTm5NM0lMUHB1ZmJzelROeEN6WnkvTEV2TkFGM25PZnp5RnpM?= =?utf-8?Q?ZD6m/YaCUnFHNEMvbCJdzQ3Js?= X-OriginatorOrg: amd.com X-MS-Exchange-CrossTenant-Network-Message-Id: 5615048e-f5bc-490d-a254-08dbb9f81edc X-MS-Exchange-CrossTenant-AuthSource: CH2PR12MB4294.namprd12.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 20 Sep 2023 16:39:12.6019 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 3dd8961f-e488-4e60-8e11-a82d994e183d X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: S5JiwCUCys34stwHaae37I4j1qq5n9rvyCydOG7iA8pL0SMo3LWLY+4YzuWhpmt1 X-MS-Exchange-Transport-CrossTenantHeadersStamped: PH8PR12MB7026 X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org On 9/8/2023 9:00 AM, Jie Hai wrote: > 1. Recomment fields of 'rte_eth_rss_conf'. > 2. Add comments for RTE_ETH_HASH_FUNCTION_DEFAULT. > > Signed-off-by: Jie Hai > --- > lib/ethdev/rte_ethdev.h | 28 +++++++++++++--------------- > lib/ethdev/rte_flow.h | 4 ++++ > 2 files changed, 17 insertions(+), 15 deletions(-) > > diff --git a/lib/ethdev/rte_ethdev.h b/lib/ethdev/rte_ethdev.h > index 04a2564f222a..40cfbb7efddd 100644 > --- a/lib/ethdev/rte_ethdev.h > +++ b/lib/ethdev/rte_ethdev.h > @@ -448,24 +448,22 @@ struct rte_vlan_filter_conf { > /** > * A structure used to configure the Receive Side Scaling (RSS) feature > * of an Ethernet port. > - * If not NULL, the *rss_key* pointer of the *rss_conf* structure points > - * to an array holding the RSS key to use for hashing specific header > - * fields of received packets. The length of this array should be indicated > - * by *rss_key_len* below. Otherwise, a default random hash key is used by > - * the device driver. > - * > - * The *rss_key_len* field of the *rss_conf* structure indicates the length > - * in bytes of the array pointed by *rss_key*. To be compatible, this length > - * will be checked in i40e only. Others assume 40 bytes to be used as before. > - * > - * The *rss_hf* field of the *rss_conf* structure indicates the different > - * types of IPv4/IPv6 packets to which the RSS hashing must be applied. > - * Supplying an *rss_hf* equal to zero disables the RSS feature. > */ > struct rte_eth_rss_conf { > - uint8_t *rss_key; /**< If not NULL, 40-byte hash key. */ > + /** > + * If not NULL, 40-byte hash key to use for hashing specific header > + * fields of received packets. The size of rss_key should be indicated > + * by *rss_key_len* below. > It says key length is 40 bytes, also says key length is defined by 'rss_key_len'. I wonder how can we clarify this more, what about like: If not NULL, hash key to use for hashing. The size of rss_key should be indicated by *rss_key_len* below. Drivers are free to ignore the *rss_key_len* and assume key length is 40 bytes. > + * Otherwise, a default random hash key is used by the device driver. > + */ > + uint8_t *rss_key; > uint8_t rss_key_len; /**< hash key length in bytes. */ > - uint64_t rss_hf; /**< Hash functions to apply - see below. */ > + /** > + * The different types of packets to which the RSS hashing must be > + * applied, may be combined with SRC/DST_ONLY, see below. I find this difficult to understand, can we simplify it? The name 'hf' (hash function) is confusing on its own, but it is too much burden to update it, at least we can clarify it with the above documentation. rte_flow defines it as 'types' (rte_flow_action_rss.type) (and it has 'func' for "hash algorithm" to increase confusion). Can we define something like (please don't use as it is, just thinking): " Set part of the packet that hashing will be applied for RSS purposes (see RTE_ETH_RSS_*). " > + * Supplying an *rss_hf* equal to zero disables the RSS feature. > + */ s/Supply/Set/ ? "Setting *rss_hf* to zero disables the RSS feature." > + uint64_t rss_hf; > }; > > /* > diff --git a/lib/ethdev/rte_flow.h b/lib/ethdev/rte_flow.h > index 2ebb76dbc083..3bd0dc64fbe2 100644 > --- a/lib/ethdev/rte_flow.h > +++ b/lib/ethdev/rte_flow.h > @@ -3187,6 +3187,10 @@ struct rte_flow_query_count { > * Hash function types. > */ > enum rte_eth_hash_function { > + /** > + * DEFAULT means that conformance to a specific hash algorithm is > + * uncared to the caller. The driver can pick the one it deems optimal. Not sure about word 'uncared' usage here, what about: " DEFAULT means driver decides which hash algorithm to pick. "