From: Andrew Rybchenko <andrew.rybchenko@oktetlabs.ru>
To: Chas Williams <3chas3@gmail.com>, Chas Williams <chas3@att.com>,
"Min Hu (Connor)" <humin29@huawei.com>
Cc: stable@dpdk.org, Hari Kumar Vemula <hari.kumarx.vemula@intel.com>,
Ivan Malov <ivan.malov@oktetlabs.ru>,
dev@dpdk.org
Subject: Re: [PATCH] net/bonding: fix descriptor limit reporting
Date: Mon, 17 Oct 2022 17:08:06 +0300 [thread overview]
Message-ID: <7ee1b944-9ca1-727b-43a5-8ce90019e4ec@oktetlabs.ru> (raw)
In-Reply-To: <c213e5bb-bbec-7c73-14d1-4842f029410a@gmail.com>
On 10/17/22 15:40, Chas Williams wrote:
> On 10/17/22 04:40, Andrew Rybchenko wrote:
>> Chas, Cornor, could you review the patch, please.
>>
>> Thanks,
>> Andrew.
>>
>> On 9/11/22 15:19, Ivan Malov wrote:
>>> Commit 5be3b40fea60 ("net/bonding: fix values of descriptor limits")
>>> breaks reporting of "nb_min" and "nb_align" values obtained from
>>> back-end devices' descriptor limits. This means that work done
>>> by eth_bond_slave_inherit_desc_lim_first() as well as
>>> eth_bond_slave_inherit_desc_lim_next() gets dismissed.
>>>
>>> Revert the offending commit and use proper workaround
>>> for the test case mentioned in the said commit.
>>>
>>> Meanwhile, the test case itself might be poorly constructed.
>>> It tries to run a bond with no back-end devices attached,
>>> but, according to [1] ("Requirements / Limitations"),
>>> at least one back-end device must be attached.
>>>
>>> [1] doc/guides/prog_guide/link_bonding_poll_mode_drv_lib.rst
>>>
>>> Fixes: 5be3b40fea60 ("net/bonding: fix values of descriptor limits")
>>> Cc: stable@dpdk.org
>>>
>>> Signed-off-by: Ivan Malov <ivan.malov@oktetlabs.ru>
>>> Reviewed-by: Andrew Rybchenko <andrew.rybchenko@oktetlabs.ru>
>
> Acked-by: Chas Williams <3chas3@gmail.com>
Applied to dpdk-next-net/main, thanks.
prev parent reply other threads:[~2022-10-17 14:08 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-09-11 12:19 Ivan Malov
2022-10-17 8:40 ` Andrew Rybchenko
2022-10-17 12:40 ` Chas Williams
2022-10-17 14:08 ` Andrew Rybchenko [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=7ee1b944-9ca1-727b-43a5-8ce90019e4ec@oktetlabs.ru \
--to=andrew.rybchenko@oktetlabs.ru \
--cc=3chas3@gmail.com \
--cc=chas3@att.com \
--cc=dev@dpdk.org \
--cc=hari.kumarx.vemula@intel.com \
--cc=humin29@huawei.com \
--cc=ivan.malov@oktetlabs.ru \
--cc=stable@dpdk.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).