From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id BD823A0032; Thu, 12 May 2022 09:36:38 +0200 (CEST) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 5AFE540E64; Thu, 12 May 2022 09:36:38 +0200 (CEST) Received: from shelob.oktetlabs.ru (shelob.oktetlabs.ru [91.220.146.113]) by mails.dpdk.org (Postfix) with ESMTP id 2FE8C4014F for ; Thu, 12 May 2022 09:36:37 +0200 (CEST) Received: from [192.168.38.17] (aros.oktetlabs.ru [192.168.38.17]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by shelob.oktetlabs.ru (Postfix) with ESMTPSA id 271DA82; Thu, 12 May 2022 10:36:33 +0300 (MSK) DKIM-Filter: OpenDKIM Filter v2.11.0 shelob.oktetlabs.ru 271DA82 DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple; d=oktetlabs.ru; s=default; t=1652340993; bh=46RJzkrH5r8ZLlumhZMcvRPX2QF0B95W3Og4oEwwUQY=; h=Date:Subject:To:Cc:References:From:In-Reply-To:From; b=npN2d15hsbfQ0MhkuOWeX5ow7UzcAifBD/H3aLTb2GdtSYc1V2uXSEBPCrqmjj/k2 3+vDDJKTM3W/XNM0WFWhQlwM5EVImNLYL7xGOlVbg1kvaVy4bs8h6a86P9A4sxAAGC BCOUGOwTEjfj/LpREfrkkKooaPMUAyiuPwuu3OsQ= Message-ID: <7ee66146-93e1-36c6-7954-b498af8a1ec8@oktetlabs.ru> Date: Thu, 12 May 2022 10:36:30 +0300 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101 Thunderbird/91.8.0 Subject: Re: [dpdk-dev] [PATCH v5] ethdev: mtr: support protocol based input color selection Content-Language: en-US To: jerinj@marvell.com, dev@dpdk.org, Cristian Dumitrescu , Thomas Monjalon , Ray Kinsella , Ferruh Yigit Cc: ajit.khaparde@broadcom.com, aboyer@pensando.io, beilei.xing@intel.com, bruce.richardson@intel.com, chas3@att.com, chenbo.xia@intel.com, ciara.loftus@intel.com, dsinghrawat@marvell.com, ed.czeck@atomicrules.com, evgenys@amazon.com, grive@u256.net, g.singh@nxp.com, zhouguoyang@huawei.com, haiyue.wang@intel.com, hkalra@marvell.com, heinrich.kuhn@corigine.com, hemant.agrawal@nxp.com, hyonkim@cisco.com, igorch@amazon.com, irusskikh@marvell.com, jgrajcia@cisco.com, jasvinder.singh@intel.com, jianwang@trustnetic.com, jiawenwu@trustnetic.com, jingjing.wu@intel.com, johndale@cisco.com, john.miller@atomicrules.com, linville@tuxdriver.com, keith.wiles@intel.com, kirankumark@marvell.com, oulijun@huawei.com, lironh@marvell.com, longli@microsoft.com, mw@semihalf.com, spinler@cesnet.cz, matan@nvidia.com, matt.peters@windriver.com, maxime.coquelin@redhat.com, mk@semihalf.com, humin29@huawei.com, pnalla@marvell.com, ndabilpuram@marvell.com, qiming.yang@intel.com, qi.z.zhang@intel.com, radhac@marvell.com, rahul.lakkireddy@chelsio.com, rmody@marvell.com, rosen.xu@intel.com, sachin.saxena@oss.nxp.com, skoteshwar@marvell.com, shshaikh@marvell.com, shaibran@amazon.com, shepard.siegel@atomicrules.com, asomalap@amd.com, somnath.kotur@broadcom.com, sthemmin@microsoft.com, steven.webster@windriver.com, skori@marvell.com, mtetsuyah@gmail.com, vburru@marvell.com, viacheslavo@nvidia.com, xiao.w.wang@intel.com, cloud.wangxiaoyun@huawei.com, yisen.zhuang@huawei.com, yongwang@vmware.com, xuanziyang2@huawei.com References: <20220421180241.514767-1-jerinj@marvell.com> <20220501144637.3757757-1-jerinj@marvell.com> From: Andrew Rybchenko Organization: OKTET Labs In-Reply-To: <20220501144637.3757757-1-jerinj@marvell.com> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Hi Jerin, On 5/1/22 17:46, jerinj@marvell.com wrote: > From: Jerin Jacob > > Currently, meter object supports only DSCP based on input color table, > The patch enhance that to support VLAN based input color table, > color table based on inner field for the tunnel use case, and > support for fallback color per meter if packet based on a different field. > > All of the above features are exposed through capability and added > additional capability to specify the implementation supports > more than one input color table per ethdev port. > > Suggested-by: Cristian Dumitrescu > Signed-off-by: Jerin Jacob the patch LGTM, but I have a couple of questions to clarify: 1. Will we have API usage patches in the release cycle (I guess testpmd)? 2. Will we have net driver patches which add support for new driver callbacks and advertise added capabilities? Thanks, Andrew.