From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 87C30A0C3F; Fri, 16 Apr 2021 04:20:33 +0200 (CEST) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 6C670161B3E; Fri, 16 Apr 2021 04:20:33 +0200 (CEST) Received: from szxga05-in.huawei.com (szxga05-in.huawei.com [45.249.212.191]) by mails.dpdk.org (Postfix) with ESMTP id CD9FB40140 for ; Fri, 16 Apr 2021 04:20:31 +0200 (CEST) Received: from DGGEMS406-HUB.china.huawei.com (unknown [172.30.72.58]) by szxga05-in.huawei.com (SkyGuard) with ESMTP id 4FM0Gk4PRdzPr0Z; Fri, 16 Apr 2021 10:17:34 +0800 (CST) Received: from [10.67.103.128] (10.67.103.128) by DGGEMS406-HUB.china.huawei.com (10.3.19.206) with Microsoft SMTP Server id 14.3.498.0; Fri, 16 Apr 2021 10:20:24 +0800 To: Ferruh Yigit , CC: , , "Chen, Zhaoyan" , "Yu, PingX" , Aaron Conole , Honnappa Nagarahalli References: <1614906276-34293-1-git-send-email-oulijun@huawei.com> <1617068905-5364-1-git-send-email-humin29@huawei.com> <9bb01775-faa1-3811-43d8-bb701c2eb09c@intel.com> <340dc152-6135-6a85-da51-f7a7a0c6d195@intel.com> From: "Min Hu (Connor)" Message-ID: <7ef38707-b58c-7bb6-6fdb-ff091f33905c@huawei.com> Date: Fri, 16 Apr 2021 10:20:25 +0800 User-Agent: Mozilla/5.0 (Windows NT 10.0; WOW64; rv:68.0) Gecko/20100101 Thunderbird/68.3.1 MIME-Version: 1.0 In-Reply-To: <340dc152-6135-6a85-da51-f7a7a0c6d195@intel.com> Content-Type: text/plain; charset="utf-8"; format=flowed Content-Transfer-Encoding: 8bit X-Originating-IP: [10.67.103.128] X-CFilter-Loop: Reflected Subject: Re: [dpdk-dev] [PATCH v8] app/testpmd: support multi-process X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" 在 2021/4/15 15:54, Ferruh Yigit 写道: > On 4/12/2021 5:37 PM, Ferruh Yigit wrote: >> On 3/30/2021 2:48 AM, Min Hu (Connor) wrote: >>> From: Lijun Ou >>> >>> This patch adds multi-process support for testpmd. >>> The test cmd example as follows: >>> the primary cmd: >>> ./dpdk-testpmd -a xxx --proc-type=auto -l 0-1 -- -i \ >>> --rxq=4 --txq=4 --num-procs=2 --proc-id=0 >>> >>> the secondary cmd: >>> ./dpdk-testpmd -a xxx --proc-type=auto -l 2-3 -- -i \ >>> --rxq=4 --txq=4 --num-procs=2 --proc-id=1 >>> >> >> Hi Connor, >> >> Please find a few minor comments below, since they are minor issues >> please feel free to keep the existing acks in next version. >> > > Reminder of this patch, waiting for minor updates, it would be good to > have it before -rc1, so that the change can be tested thoroughly. > Hi, Ferruh, v9 has been sent, please check it out, thanks. > Meanwhile I have concern/question on long term testing of the feature. > It is possible to break the multi-process support unintentionally and > not recognize it. How can we continually verify the feature? > > Are you using DTS? > Does it make sense to add a testcase into dts to test testpmd > multi-process support so that it is verified on each release? > . Well, we have our own DTS system which contains testcase of multiple process in testpmd: 1. When we upstream patches to DPDK，the patch should pass all the testcase. 2. Before DPDK version release(in RC1) in every three months, we rebase the new DPDK version, and check all the testcase in our DTS system. If some testcase fails, we will fix it and upstream the patch to DPDK, of course, including multi-process support in testpmd.