DPDK patches and discussions
 help / color / mirror / Atom feed
From: Ferruh Yigit <ferruh.yigit@intel.com>
To: Leyi Rong <leyi.rong@intel.com>, <bruce.richardson@intel.com>,
	<qi.z.zhang@intel.com>
Cc: <dev@dpdk.org>, <wenzhuo.lu@intel.com>, <stable@dpdk.org>
Subject: Re: [dpdk-dev] [PATCH 1/2] net/i40e: fix generic build on FreeBSD
Date: Mon, 18 Oct 2021 22:35:34 +0100	[thread overview]
Message-ID: <7f11c4fb-f235-c2d9-236b-838282b1b54a@intel.com> (raw)
In-Reply-To: <20210929121309.11766-1-leyi.rong@intel.com>

On 9/29/2021 1:13 PM, Leyi Rong wrote:
> The common header file for vectorization is included in multiple files,
> and so must use macros for the current compilation unit, rather than the
> compiler-capability flag set for the whole driver. With the current,
> incorrect, macro, the AVX512 or AVX2 flags may be set when compiling up
> SSE code, leading to compilation errors. Changing from "CC_AVX*_SUPPORT"
> to the compiler-defined "__AVX*__" macros fixes this issue. In addition,
> splitting AVX-specific code into the new i40e_rxtx_common_avx.h header
> file to avoid such bugs.
> 
> Bugzilla ID: 788
> Fixes: 0604b1f2208f ("net/i40e: fix crash in AVX512")
> Cc: wenzhuo.lu@intel.com
> Cc: stable@dpdk.org
> 
> Signed-off-by: Leyi Rong <leyi.rong@intel.com>
> Signed-off-by: Bruce Richardson <bruce.richardson@intel.com>

<...>

> diff --git a/drivers/net/i40e/i40e_rxtx_vec_common.h b/drivers/net/i40e/i40e_rxtx_vec_common.h
> index f52ed98d62..798d6a3e4a 100644
> --- a/drivers/net/i40e/i40e_rxtx_vec_common.h
> +++ b/drivers/net/i40e/i40e_rxtx_vec_common.h
> @@ -15,6 +15,10 @@
>   #pragma GCC diagnostic ignored "-Wcast-qual"
>   #endif
>   
> +#ifdef __AVX2__
> +#include "i40e_rxtx_common_avx.h"
> +#endif
> +

The 'i40e_rxtx_common_avx.h' header is not required by 'i40e_rxtx_vec_common.h',
why not include 'i40e_rxtx_common_avx.h' directly from related .c files:
i40e_rxtx_vec_avx2.c
i40e_rxtx_vec_avx512.c

So "#ifdef __AVX2__" won't be needed. Same for ice.

  parent reply	other threads:[~2021-10-18 21:35 UTC|newest]

Thread overview: 12+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-09-29 12:13 Leyi Rong
2021-09-29 12:13 ` [dpdk-dev] [PATCH 2/2] net/ice: " Leyi Rong
2021-10-18 21:35 ` Ferruh Yigit [this message]
2021-10-19  3:02 ` [dpdk-dev] [PATCH v2 0/2] fix generic build error " Leyi Rong
2021-10-19  3:02   ` [dpdk-dev] [PATCH v2 1/2] net/i40e: fix generic build " Leyi Rong
2021-10-19  3:02   ` [dpdk-dev] [PATCH v2 2/2] net/ice: " Leyi Rong
2021-10-19  9:18   ` [dpdk-dev] [PATCH v2 0/2] fix generic build error " Ferruh Yigit
2021-10-19 11:01     ` Zhang, Qi Z
  -- strict thread matches above, loose matches on Subject: below --
2021-08-10 18:27 [dpdk-dev] [Bug 788] i40e: 16BYTE_RX_DESC build broken on FreeBSD-13 bugzilla
2021-08-18 16:38 ` [dpdk-dev] [PATCH 1/2] net/i40e: fix generic build on FreeBSD Bruce Richardson
2021-08-18 16:42   ` Bruce Richardson
2021-09-03 10:00     ` Ferruh Yigit
2021-09-01  6:23   ` Zhang, Qi Z

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=7f11c4fb-f235-c2d9-236b-838282b1b54a@intel.com \
    --to=ferruh.yigit@intel.com \
    --cc=bruce.richardson@intel.com \
    --cc=dev@dpdk.org \
    --cc=leyi.rong@intel.com \
    --cc=qi.z.zhang@intel.com \
    --cc=stable@dpdk.org \
    --cc=wenzhuo.lu@intel.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).