From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id E3B3B42BE6; Tue, 30 May 2023 17:16:47 +0200 (CEST) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id C2636410EE; Tue, 30 May 2023 17:16:47 +0200 (CEST) Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) by mails.dpdk.org (Postfix) with ESMTP id 999E2410DD for ; Tue, 30 May 2023 17:16:46 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1685459806; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=DrjA27daoQHnmGFP0syxrnxP7a2oXuzfrnCoztGG1f8=; b=g9IhIVEzg+ZLaDjJEYblyb3IlhmBHDlSuvA+cC7MDK2IUIlWy5HV0QaI/YFJaaCMnPIe0Z QHXjgA+86xpVggRG3RPOZiAEEN97tbnhwy6W0C7Ke3ImTXsgBKfKNJN2By/KOpbNFqHlQ8 zqnw+VqQhzakQjxlKox0q5hmrAJvet8= Received: from mimecast-mx02.redhat.com (mimecast-mx02.redhat.com [66.187.233.88]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id us-mta-652-6ETNYpwzNYOMBUSJUfEvMg-1; Tue, 30 May 2023 11:16:44 -0400 X-MC-Unique: 6ETNYpwzNYOMBUSJUfEvMg-1 Received: from smtp.corp.redhat.com (int-mx04.intmail.prod.int.rdu2.redhat.com [10.11.54.4]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx02.redhat.com (Postfix) with ESMTPS id 3DCC5811E88; Tue, 30 May 2023 15:16:44 +0000 (UTC) Received: from [10.39.208.19] (unknown [10.39.208.19]) by smtp.corp.redhat.com (Postfix) with ESMTPS id 06F4D200AE6F; Tue, 30 May 2023 15:16:42 +0000 (UTC) Message-ID: <7f1be920-0318-ae7f-4c2e-cc08b2083f7c@redhat.com> Date: Tue, 30 May 2023 17:16:41 +0200 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.10.0 Subject: Re: [PATCH v3 4/4] vhost: add device op to offload the interrupt kick To: Thomas Monjalon , Eelco Chaudron , chenbo.xia@intel.com, david.marchand@redhat.com Cc: dev@dpdk.org References: <168431450017.558450.16680518469610688737.stgit@ebuild.local> <168431455219.558450.14986601389394385835.stgit@ebuild.local> <49ec9930-66b8-fc95-72ad-5cb012ed8635@redhat.com> <16690234.Ash8RoxBsO@thomas> From: Maxime Coquelin In-Reply-To: <16690234.Ash8RoxBsO@thomas> X-Scanned-By: MIMEDefang 3.1 on 10.11.54.4 X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Language: en-US Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org On 5/30/23 15:16, Thomas Monjalon wrote: > 30/05/2023 15:02, Maxime Coquelin: >> >> On 5/17/23 11:09, Eelco Chaudron wrote: >>> This patch adds an operation callback which gets called every time the >>> library wants to call eventfd_write(). This eventfd_write() call could >>> result in a system call, which could potentially block the PMD thread. >>> >>> The callback function can decide whether it's ok to handle the >>> eventfd_write() now or have the newly introduced function, >>> rte_vhost_notify_guest(), called at a later time. >>> >>> This can be used by 3rd party applications, like OVS, to avoid system >>> calls being called as part of the PMD threads. >>> >>> Signed-off-by: Eelco Chaudron >>> --- >>> lib/vhost/meson.build | 2 ++ >>> lib/vhost/rte_vhost.h | 23 +++++++++++++++++- >>> lib/vhost/socket.c | 63 ++++++++++++++++++++++++++++++++++++++++++++++--- >>> lib/vhost/version.map | 9 +++++++ >>> lib/vhost/vhost.c | 38 ++++++++++++++++++++++++++++++ >>> lib/vhost/vhost.h | 58 ++++++++++++++++++++++++++++++++------------- >>> 6 files changed, 171 insertions(+), 22 deletions(-) >>> >> >> >> The patch looks good to me, but that's the first time we use function >> versioning in Vhost library, so I'd like another pair of eyes to be sure >> I don't miss anything. >> >> Reviewed-by: Maxime Coquelin >> >> Thomas, do we need to mention it somewhere in the release note? > > If compatibility is kept, I think we don't need to mention it. > > Thanks Thomas for the information. Maxime