From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-wr0-f171.google.com (mail-wr0-f171.google.com [209.85.128.171]) by dpdk.org (Postfix) with ESMTP id 582D8234 for ; Tue, 18 Apr 2017 10:30:30 +0200 (CEST) Received: by mail-wr0-f171.google.com with SMTP id o21so97151341wrb.2 for ; Tue, 18 Apr 2017 01:30:30 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=6wind-com.20150623.gappssmtp.com; s=20150623; h=from:to:cc:subject:date:message-id; bh=fRhm9WdJR0ECMtrSjeJ2792WUJ97tRmF3aY9nXM4ygM=; b=CfcGYZrcgzntctH8OkrmsxvoMEXanCkGV10cZfu6iVrjEjUQPLhIikT4bzF6HZ+lO8 G7xC2YzfiHVvfsRnCuuH+aXqjtdd9KP8dS2IwHpRjQAI8UbfTMG/xOt7JUc7WW1z1zv/ dCx54vpH0ZozQw7ie+jONSaUjdkCpnuoIE13z/cH493vPh0Ps8fHVAioW83nrR1RwB/8 1y6NWwDat20qoI4kKMhE5j5sk3MR3C2E6HFz13RNKxxsEv3ljycdBVtPonr31oZW3/X2 KMtQONZ3BUtZuHZ4A0W37QgDmNd/+RtgXHnLEaqszq0CxLYuBXu9YUZQsYUvdGPlZK/4 vEhA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id; bh=fRhm9WdJR0ECMtrSjeJ2792WUJ97tRmF3aY9nXM4ygM=; b=jK8olodOcoMaNzncatfKDuBRDplE/bUfOWVGOvhDbgV/7d11nlEMMDGaasy4Csg08e dpUpwFzgV6R1lLsmykcMXyPCPHwyG14+LgVxzQP5LyBYir1FVLhQ1OArOEZ57FVcPH+l t94/Hc2IIa7Kf2YTJ0fa7rOyJGYqdI1tLivGpaPLEh63RhPkl/1okWvEV+uLk0ZVilkw zQcFLevHMB1tLMfgTE1J5s4OnMtKHs7Z0QWvfC8LCIBxmigA3ClEHg3CL3MKu4RIVpju kuF+VzQLJwMsujfnHu6jGBHMGoadbQt0QHUu26H0GCNMIf0xRjYBFYCP9yXSj+i7U11m HiYA== X-Gm-Message-State: AN3rC/5JvRG7mB8SlpIqXQYMHmAshsGqmV7e2TtZrXUPDolefErzcPYL PKVmUKEpErBGXoXj X-Received: by 10.223.169.226 with SMTP id b89mr23945376wrd.100.1492504230731; Tue, 18 Apr 2017 01:30:30 -0700 (PDT) Received: from ping.vm.6wind.com (host.78.145.23.62.rev.coltfrance.com. [62.23.145.78]) by smtp.gmail.com with ESMTPSA id q130sm13930305wmd.29.2017.04.18.01.30.30 (version=TLS1_2 cipher=ECDHE-RSA-AES128-SHA bits=128/128); Tue, 18 Apr 2017 01:30:30 -0700 (PDT) From: Nelio Laranjeiro To: dev@dpdk.org Cc: Adrien Mazarguil , Shahaf Shuler Date: Tue, 18 Apr 2017 10:30:11 +0200 Message-Id: <7f247b841bc83d6c9446942a0a5b11fd709e7f08.1492504184.git.nelio.laranjeiro@6wind.com> X-Mailer: git-send-email 2.1.4 Subject: [dpdk-dev] [PATCH] net/mlx5: fix empty RSS flow action X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 18 Apr 2017 08:30:31 -0000 Empty RSS action is causing a segmentation fault. Fixes: 3d821d6fea40 ("net/mlx5: support RSS action flow rule") Signed-off-by: Nelio Laranjeiro Acked-by: Shahaf Shuler Acked-by: Adrien Mazarguil --- drivers/net/mlx5/mlx5_flow.c | 7 +++++++ 1 file changed, 7 insertions(+) diff --git a/drivers/net/mlx5/mlx5_flow.c b/drivers/net/mlx5/mlx5_flow.c index 8d62f85..1784e64 100644 --- a/drivers/net/mlx5/mlx5_flow.c +++ b/drivers/net/mlx5/mlx5_flow.c @@ -506,6 +506,13 @@ priv_flow_validate(struct priv *priv, actions->conf; uint16_t n; + if (!rss || !rss->num) { + rte_flow_error_set(error, EINVAL, + RTE_FLOW_ERROR_TYPE_ACTION, + actions, + "no valid queues"); + return -rte_errno; + } if (action->queues_n == 1) { uint16_t found = 0; -- 2.1.4