From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: <arybchenko@solarflare.com> Received: from nbfkord-smmo02.seg.att.com (nbfkord-smmo02.seg.att.com [209.65.160.78]) by dpdk.org (Postfix) with ESMTP id 895852B8B for <dev@dpdk.org>; Fri, 6 Jan 2017 11:08:35 +0100 (CET) Received: from unknown [193.34.186.16] (EHLO nbfkord-smmo02.seg.att.com) by nbfkord-smmo02.seg.att.com(mxl_mta-7.2.4-7) with ESMTP id 3ac6f685.2b5ec7c65940.996668.00-2471.2032000.nbfkord-smmo02.seg.att.com (envelope-from <arybchenko@solarflare.com>); Fri, 06 Jan 2017 10:08:35 +0000 (UTC) X-MXL-Hash: 586f6ca368e26146-27546d10fa79d6090938805efd4f68178a206c68 Received: from unknown [193.34.186.16] by nbfkord-smmo02.seg.att.com(mxl_mta-7.2.4-7) with SMTP id 38c6f685.0.996657.00-2281.2031972.nbfkord-smmo02.seg.att.com (envelope-from <arybchenko@solarflare.com>); Fri, 06 Jan 2017 10:08:28 +0000 (UTC) X-MXL-Hash: 586f6c9c0c55808c-4a6d4ecd0bc5681af02a4bc4cf36fbca24cbdb56 Received: from [192.168.38.17] (84.52.89.52) by ukex01.SolarFlarecom.com (10.17.10.4) with Microsoft SMTP Server (TLS) id 15.0.1044.25; Fri, 6 Jan 2017 10:07:48 +0000 To: Ferruh Yigit <ferruh.yigit@intel.com>, Thomas Monjalon <thomas.monjalon@6wind.com>, Jan Blunck <jblunck@infradead.org> References: <1482332986-7599-1-git-send-email-jblunck@infradead.org> <1482508691-11408-1-git-send-email-jblunck@infradead.org> <3218207.eTF77IRQHx@xps13> <2be3d632-b1eb-d7be-47e3-c6e9211fef33@intel.com> CC: <dev@dpdk.org>, <shreyansh.jain@nxp.com>, <david.marchand@6wind.com>, <stephen@networkplumber.org>, Alejandro Lucero <alejandro.lucero@netronome.com> From: Andrew Rybchenko <arybchenko@solarflare.com> Message-ID: <7f68e370-4bee-9d87-e182-3bcda066a07e@solarflare.com> Date: Fri, 6 Jan 2017 13:07:44 +0300 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:45.0) Gecko/20100101 Thunderbird/45.6.0 MIME-Version: 1.0 In-Reply-To: <2be3d632-b1eb-d7be-47e3-c6e9211fef33@intel.com> Content-Type: text/plain; charset="windows-1252"; format=flowed Content-Transfer-Encoding: 7bit X-Originating-IP: [84.52.89.52] X-ClientProxiedBy: ocex03.SolarFlarecom.com (10.20.40.36) To ukex01.SolarFlarecom.com (10.17.10.4) X-TM-AS-Product-Ver: SMEX-11.0.0.1191-8.000.1202-22806.003 X-TM-AS-Result: No--9.588200-0.000000-31 X-TM-AS-User-Approved-Sender: Yes X-TM-AS-User-Blocked-Sender: No X-AnalysisOut: [v=2.1 cv=ALPOwa1d c=1 sm=1 tr=0 a=8P+NB+fYZDP74ap4g4d9Kw==] X-AnalysisOut: [:17 a=RB3BGLmKESwA:10 a=N659UExz7-8A:10 a=IgFoBzBjUZAA:10 ] X-AnalysisOut: [a=QCW9B7HRpTSwoPMz11oA:9 a=pILNOxqGKmIA:10] X-Spam: [F=0.2000000000; CM=0.500; S=0.200(2015072901)] X-MAIL-FROM: <arybchenko@solarflare.com> X-SOURCE-IP: [193.34.186.16] Subject: Re: [dpdk-dev] [PATCH v5 00/20] Decouple ethdev from PCI device X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions <dev.dpdk.org> List-Unsubscribe: <http://dpdk.org/ml/options/dev>, <mailto:dev-request@dpdk.org?subject=unsubscribe> List-Archive: <http://dpdk.org/ml/archives/dev/> List-Post: <mailto:dev@dpdk.org> List-Help: <mailto:dev-request@dpdk.org?subject=help> List-Subscribe: <http://dpdk.org/ml/listinfo/dev>, <mailto:dev-request@dpdk.org?subject=subscribe> X-List-Received-Date: Fri, 06 Jan 2017 10:08:36 -0000 On 01/03/2017 03:20 PM, Ferruh Yigit wrote: > On 12/25/2016 10:33 PM, Thomas Monjalon wrote: >> 2016-12-23 16:57, Jan Blunck: >>> This repost addresses the review comments of Thomas Monjalon to completely >>> remove the ethdev helper to further decrease the coupling of the ethdev and >>> the eal layers. This required me to squash together all patches using the >>> rte_eth_dev_to_pci() helper into "Decouple from PCI device" patch. As >>> discussed privately I'll keep the PCI information in rte_eth_dev_info >>> untouched. >> Applied with some trivial fixes, thanks >> > I rebased these changes into next-net tree. And need to update some sfc > and nfp patches [1] there. > > Andrew, Alejandro, > > Can you please review your driver in the latest next-net tree? > > Thanks, > ferruh > > [1] > nfp: > net/nfp: add Rx interrupts > > sfc: > net/sfc: support link status change interrupt > net/sfc: interrupts support sufficient for event queue init > net/sfc: implement driver operation to init device on attach > net/sfc: libefx-based PMD stub sufficient to build and init Ferruh, thanks that you care about it. I've reviewed and tested it. It looks and works fine for me. Andrew.