From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 2470E42A06; Wed, 26 Apr 2023 17:58:24 +0200 (CEST) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 9F7C7410FA; Wed, 26 Apr 2023 17:58:23 +0200 (CEST) Received: from NAM11-CO1-obe.outbound.protection.outlook.com (mail-co1nam11on2066.outbound.protection.outlook.com [40.107.220.66]) by mails.dpdk.org (Postfix) with ESMTP id 11C194068E for ; Wed, 26 Apr 2023 17:58:22 +0200 (CEST) ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=Hjjc/SyCtyG3vsduwJXzExtviX9796WsE6ptRQVLgaPqjeBhAZYECGVdXGG15xBxlqmegSNhMjrgpcVfS2+5O7UJXLpCOsfC+ChqUMRx/X8gBeSv6tPFDNhRTsUWgXKIl5GORIMCHTmFqELTeSb+MDXwdHigAtxTAK0n/fez+tIpyYdDODctz8jKViOvIUt5YFgP23xCTAJ2yHr//fiKgQs9qpnhBn+DYf0PiDAssQQEeLp5hdmrj+wuXT0ttMkRRM8oiINu5ivegDwLRr5CQk+zAQ2GDlgoEZXrNJ4mGGcgBmcRr3yhlFS3LM189S0MfsSSYPdJUzEYX+XWPdKyLQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=sOtyHD5ZMx0/+l8yZVVAILww8lzx0XcwgdE5dNaBiCY=; b=ar5UlFqx4j9F7n+Xk+H6SMIl3gwYMquB9/RbvszYpJYtAa6hKc0Kg9F+RRL9eVD+6HVEH9Mmy4qeCcD8D8T15KBQVoRUecDYRwuTPe0/cJTCpFnSfEO4kbeDokpdHeEG7xgeHdVhjJ5qJPcqO2YNgkj/cfkeITyAMkwwv02Raam/RQ4hH/BREa/MNJPMZ6wLGSfH2JoE+kG8fOBTTav3EbcFDMvVxZIWa/rbCHvgUf2jqyLnaQzQpglM4kxm5MD/RUd7iLWpnx8Ya+/V5npNKvP/Al8vs2M6swNHGtQLPvjwM8PVbISvFWnnaNW1weFeLUd4Za1eEfjTDe53afBhhg== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=amd.com; dmarc=pass action=none header.from=amd.com; dkim=pass header.d=amd.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=amd.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=sOtyHD5ZMx0/+l8yZVVAILww8lzx0XcwgdE5dNaBiCY=; b=um92tKw5G9VsTH8XD4KM2wGtiVinj+F6l7duBxKZK+h9ylB5XFVnuYO5z2T0xx/XdsOy1NX9s9ACedhBm2FMKCDZRxmalUjjLpyK12HMM2+n51jeDteLwuhez3ggGQKSZ3fqWsVSDfNRr228Kq3RZrr91zzqJf7iPGKm0oL3X6Y= Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=amd.com; Received: from MN2PR12MB4301.namprd12.prod.outlook.com (2603:10b6:208:1d4::22) by DM4PR12MB5770.namprd12.prod.outlook.com (2603:10b6:8:61::16) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6340.21; Wed, 26 Apr 2023 15:58:19 +0000 Received: from MN2PR12MB4301.namprd12.prod.outlook.com ([fe80::6f2d:9990:c8b5:714a]) by MN2PR12MB4301.namprd12.prod.outlook.com ([fe80::6f2d:9990:c8b5:714a%6]) with mapi id 15.20.6340.021; Wed, 26 Apr 2023 15:58:19 +0000 Message-ID: <7f6d9fb8-c36c-4e36-b7a6-6a4e31007ef1@amd.com> Date: Wed, 26 Apr 2023 16:58:14 +0100 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:102.0) Gecko/20100101 Thunderbird/102.10.1 Content-Language: en-US To: Stephen Hemminger , David Christensen Cc: dev@dpdk.org, Radu Nicolau , Akhil Goyal References: <20230425205806.776057-1-drc@linux.vnet.ibm.com> <20230425173959.3cb70f20@hermes.local> From: Ferruh Yigit Subject: Re: [PATCH] net/tap: Set locally administered bit with a fixed MAC address In-Reply-To: <20230425173959.3cb70f20@hermes.local> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-ClientProxiedBy: LO4P123CA0367.GBRP123.PROD.OUTLOOK.COM (2603:10a6:600:18e::12) To MN2PR12MB4301.namprd12.prod.outlook.com (2603:10b6:208:1d4::22) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: MN2PR12MB4301:EE_|DM4PR12MB5770:EE_ X-MS-Office365-Filtering-Correlation-Id: 00c41904-de7e-41a5-93da-08db466f0de2 X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: ip5kowEwwHU5vU+CC05dFsyHwBPgHlbRI6/21ixfqW4AccAS5Lx/RFgl2yY1K83yESDBZQkerzXKjbBStcIFkfZW5zTByF2r69rZjfSXNGnS7lqslldL2BEyOz5fspTjsFJjhf6K/rPokx0huPKHeesCcoaoc3FOpdYNKkE+zIycytq/6Us1fX2+e36UMWGDqp7OnSCPR4ukMNCpJtdQuGe7eAO0QkxNfQgIdHbnXOwoP1mDlibk5Urdc+gpjsQLpteDHTRpJoXmuP6ZYaMG2YyEq0OiOMYUNdvPCyEVLuOiA/95FEpC+WIqwmTq+IRLdCQv2Y+O3tlY1wcAq4//d/KPfFYFYjLn/YYiK/aoG8TulncjXtZbYgFth8TdvqA4C1IRTSmNQzWOW7QcPl8lxhH64ZSBg8OIKo1Ulg+E5lQuhOgbyKl0ayINjU9AIPCehtqx1r/w1e7ahFBhFa/89UNa8HHlrpxEjeB6kngFh7P3GegrL+XoEGdB+2n7ASGbS/EpWYudHyE78DXgbWOTrv28OhNqS45Lks0x822z6NZ0qUKr6T0ITJ2d3IGcIHCvCo7r10wGP9FL+CLWuCmzc47DLLwJlaFExuau7CpryrpycmgbzsnxtoD7cu68gcDvYIih/5AV8csMDfW8yizT1Q== X-Forefront-Antispam-Report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:MN2PR12MB4301.namprd12.prod.outlook.com; PTR:; CAT:NONE; SFS:(13230028)(4636009)(396003)(39860400002)(346002)(136003)(366004)(376002)(451199021)(44832011)(36756003)(2616005)(31686004)(31696002)(86362001)(53546011)(26005)(6512007)(6506007)(6486002)(6666004)(478600001)(54906003)(316002)(66476007)(66946007)(66556008)(4326008)(110136005)(8936002)(8676002)(41300700001)(38100700002)(186003)(2906002)(5660300002)(45980500001)(43740500002); DIR:OUT; SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?cTVrd2ZGWmVXaUpTdWRhRm9CY241R3c0QWxDaFI2VWk0VHFzMTZOMzVWb0Ux?= =?utf-8?B?VUplQVk0SmFjUEF3ZjJWQ2lOZmdUVDliYnFhdWo0ZWJkQkRuWmZqS1puQWgr?= =?utf-8?B?VTRQcFkwMHUrSWlLWGFVUFFBeHd1NjV1dkhnTlVjdEI2TkRBOWVzcG1EdjNR?= =?utf-8?B?Sys5MWVLLzZGRE9TNmsvbHJTdmtWamQzRk1EU2EvQUdFa3pCdGlHZzJSUWxT?= =?utf-8?B?TVZKbmRhbE54Tkx5QngxQ0l6TFh1eFFTbmR1eUlySWpqQloyR0dURTI1RmZw?= =?utf-8?B?L1ByK0lOSXk2T3l4OWRxeXZRcFFBL21jbVNDUldlNTgySEhDL280VHk2TmpF?= =?utf-8?B?RVJ0K25PS1crSjcybmYyVzZ1TitVcTFhV2ZZUzMxMWdMR0JxRFgzUjc4K1VG?= =?utf-8?B?cTkwUlh2elAwcG5MZStPVC9HOS9PWDVXMHVwYm9RWGduVGNPYzlPMVRrclU0?= =?utf-8?B?UmozTDMwQTBWTm1QOEJTTjBxQ2Q2djFvZzJaVzJ0SmkzVXJVNkhJdmpGY0gw?= =?utf-8?B?bityeng5L2pQUXZJcjd0U3pvcFU1djE5cllkOGVHdEFDMEFIMFZ3dmFzTlJ3?= =?utf-8?B?WWo3WG5OTzB1S1VtbFZ6R0t2Ri9rQ3Z4eFMzK0VJcmgzMUVIRHNaVFJJUWNu?= =?utf-8?B?TGFObm1Scmc0QVY1T2JWYUpBWGMxdkM2Q1lmbFk2eWVPajBadTdNWE9TRFEx?= =?utf-8?B?UWJQNUFhbk9YaXRKOG4vK001WVVRb0prZFNFY0gzNjZYdlFBMjFCL0FpclBn?= =?utf-8?B?WlYzQWIzeWxNcysxZThGa0dKRGVBdE5ZNnJOaDVkeWFsamhtRUFWM3VLdWcy?= =?utf-8?B?ZVJzYmxkYUVPeU9EdFhQbi9mQjg4SysxbnBSdm5uajBVcDZHMFRGMGpjVzlB?= =?utf-8?B?dG5XVnl5TXh6KzRhaUJsSjBZNFFvMTJJazMxV3BtSEpQMjlwM0dvc0NoYy9a?= =?utf-8?B?dS84S2xhRWEvbCtQcXJNK3N1eU10WWswR2hsTkRDdFgzN2dNOXA0eWR2aHJW?= =?utf-8?B?aEVva2c1WHlBZlBiWlFjNVZaejlpWnZkVjZrNkRUYTFiZWtGdEcyMDhrOTAx?= =?utf-8?B?SFRZNnVDQlNNUnZ6TkJlbktZbzM4eE8wREJtSGlqTGx3c2RDODdwdnJ0Qkdx?= =?utf-8?B?OUdaTnFJNWpQSFdLdGhuNmFGUlhBNWRnQjYvNkpzeU1EY282NzZLRTlpR0ty?= =?utf-8?B?WnNwaHdDMjhYQ2MzVkZRMSs3RSt4UnNzTUxUbnNjM04ybVBVdm9RS1ArWHg4?= =?utf-8?B?VzFmbUtrNkJnUzAxM0VnQ2JwSEE3Z1pmbnFjSGI0bnBVVXlxYWVWOVB3NFQr?= =?utf-8?B?S1ZtQWlQQ0JIUGhtc1JtNVptWEp0NDFaaXBtZ0JGWG83dFBUVGtaa1ZVNEFz?= =?utf-8?B?SW1nS3BEWTBQRzlIKzZVcFd4N3pSNGxTS292OGF1dnV0UThvL3NZMmVHRGU0?= =?utf-8?B?NWUyNVJkb1M4VnJLTGhJUjRJNitWaXNCWHhZNWlWMHRGcmNoUGhESnk3akp0?= =?utf-8?B?KzZ6Y2paS0tuQUp6K3lrdWtPZTZLalpuOVFRb0lHb1dkNDUxUkRIT0JaMk1o?= =?utf-8?B?Uzk2VFdBUWl0cXc1RU1UOXdtTzRuUEtkMXVhaVpqZUdTYXN6aFgwbllIdXp4?= =?utf-8?B?SDFqczZhRjdNQVhPV2ZpVHlWa1BKZllNTElLOXliYzBPK1FGRCtTaDV6dW9H?= =?utf-8?B?R0Z5ZUw4U284NTc2eVNHYkV0UHJONnRlQzRkd29QTmpZOWVlYWVFQlhNZWZz?= =?utf-8?B?cGxuaGRTbjVtaGgwZlpzTXdMdGJRWWZnK3grZlByU0kxWnNBOFFKNEtkcXBG?= =?utf-8?B?ZGcrTnh6Q0Q2R1lkdTNIQnNoZnlzQzBPYUxySzdPZGpZUWVidGlBaWRtWWo3?= =?utf-8?B?ZWtQQkNIRmtkYWtkdG5jM1VHcTB2VTYrSEs5N0E1YytQRFRDbGVZSmdqcHps?= =?utf-8?B?QjBTK2dvWlIwditrNHE3SU1rd1UxV25tU0ZVbE0rNmFybkVZRjNXTEN4WitI?= =?utf-8?B?MUVNb2ZrZHZPS254MnFxWG5VUEZpTkpJWnZtSFFlZ0x6N0I1VWxhYUZtNFJW?= =?utf-8?B?WXZFWkJYVlVUUFdYK3hNa3VLNTgzMDNtTTNJUWFVMUhLYzM0NTE0RFpNQmE4?= =?utf-8?Q?g5MuqkXHoL2Hv+OfTc+IwKZZr?= X-OriginatorOrg: amd.com X-MS-Exchange-CrossTenant-Network-Message-Id: 00c41904-de7e-41a5-93da-08db466f0de2 X-MS-Exchange-CrossTenant-AuthSource: MN2PR12MB4301.namprd12.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 26 Apr 2023 15:58:19.5970 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 3dd8961f-e488-4e60-8e11-a82d994e183d X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: YnY8vFX90QEinPYsxriJsDdNgDRPh+TJhM9zh/doqcHKAn+CEael6Bkdt+OxzevW X-MS-Exchange-Transport-CrossTenantHeadersStamped: DM4PR12MB5770 X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org On 4/26/2023 1:39 AM, Stephen Hemminger wrote: > On Tue, 25 Apr 2023 16:58:06 -0400 > David Christensen wrote: > >> When the tap driver is loaded and the user selects the optional >> "mac=fixed" setting, the tap driver incorrectly uses a globally >> unique EUI-48 identifier (as documented in RFC 7042) of >> 00:64:74:61:70:. Since this is a locally generated ID, >> the Local bit in the MAC address should be set to 1, resulting in >> the new address 02:64:74:61:70:. >> >> Bugzilla ID: 1198 >> >> Signed-off-by: David Christensen > > Acked-by: Stephen Hemminger > Bugzilla ID: 1198 Fixes: f6921783fee6 ("net/tap: add support for fixed MAC addresses") Cc: stable@dpdk.org Acked-by: Ferruh Yigit Applied to dpdk-next-net/main, thanks. Dropped 'examples/ipsec-secgw/test/common_defs.sh' change while merging, although it is a minor change can you please send a separate patch for it?