From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mga07.intel.com (mga07.intel.com [134.134.136.100]) by dpdk.org (Postfix) with ESMTP id 9EF993572 for ; Thu, 19 Jul 2018 16:45:04 +0200 (CEST) X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from fmsmga001.fm.intel.com ([10.253.24.23]) by orsmga105.jf.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 19 Jul 2018 07:45:03 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.51,374,1526367600"; d="scan'208";a="73742775" Received: from aburakov-mobl.ger.corp.intel.com (HELO [10.237.220.102]) ([10.237.220.102]) by fmsmga001.fm.intel.com with ESMTP; 19 Jul 2018 07:45:02 -0700 To: Bruce Richardson , dev@dpdk.org References: <20180719142648.44824-1-bruce.richardson@intel.com> From: "Burakov, Anatoly" Message-ID: <7f7269e5-e439-6655-4fe8-7c0e9166f35d@intel.com> Date: Thu, 19 Jul 2018 15:45:01 +0100 User-Agent: Mozilla/5.0 (Windows NT 10.0; WOW64; rv:52.0) Gecko/20100101 Thunderbird/52.9.1 MIME-Version: 1.0 In-Reply-To: <20180719142648.44824-1-bruce.richardson@intel.com> Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: 7bit Subject: Re: [dpdk-dev] [PATCH] kvargs: fix building with meson outside source tree X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 19 Jul 2018 14:45:05 -0000 On 19-Jul-18 3:26 PM, Bruce Richardson wrote: > When building DPDK with meson with the being outside the source > directory, an error was generated as the path to the EAL headers was not > found. The path specified for the includes backed out unnecessarily far and > so broke when the build directory was not in the expected location of > just inside the source dir. Changing the path to be shorter, just going > down one level and then into EAL builds for both cases - where builddir is > in source directory, and also when it's outside it. > > Fixes: 092ee516496d ("kvargs: build before EAL") > > Reported-by: Anatoly Burakov > Signed-off-by: Bruce Richardson > --- > lib/librte_kvargs/meson.build | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/lib/librte_kvargs/meson.build b/lib/librte_kvargs/meson.build > index a1c724961..acd3e5432 100644 > --- a/lib/librte_kvargs/meson.build > +++ b/lib/librte_kvargs/meson.build > @@ -2,7 +2,7 @@ > # Copyright(c) 2017 Intel Corporation > > includes = [global_inc] > -includes += include_directories('../../../lib/librte_eal/common/include') > +includes += include_directories('../librte_eal/common/include') > > version = 1 > sources = files('rte_kvargs.c') > Tested-by: Anatoly Burakov -- Thanks, Anatoly