From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <declan.doherty@intel.com>
Received: from mga05.intel.com (mga05.intel.com [192.55.52.43])
 by dpdk.org (Postfix) with ESMTP id CC20C3257
 for <dev@dpdk.org>; Wed, 12 Jul 2017 12:25:50 +0200 (CEST)
Received: from fmsmga003.fm.intel.com ([10.253.24.29])
 by fmsmga105.fm.intel.com with ESMTP; 12 Jul 2017 03:25:49 -0700
X-ExtLoop1: 1
X-IronPort-AV: E=Sophos;i="5.40,349,1496127600"; d="scan'208";a="877970049"
Received: from dwdohert-dpdk.ir.intel.com ([163.33.210.152])
 by FMSMGA003.fm.intel.com with ESMTP; 12 Jul 2017 03:25:48 -0700
To: Herbert Guan <herbert.guan@arm.com>, dev@dpdk.org, jianbo.liu@linaro.org
References: <1499671222-8283-1-git-send-email-herbert.guan@arm.com>
 <1499685226-8659-1-git-send-email-herbert.guan@arm.com>
From: Declan Doherty <declan.doherty@intel.com>
Message-ID: <7f76a7ca-d243-7d9f-da6c-e853be1e03a5@intel.com>
Date: Wed, 12 Jul 2017 11:23:05 +0100
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101
 Thunderbird/52.2.1
MIME-Version: 1.0
In-Reply-To: <1499685226-8659-1-git-send-email-herbert.guan@arm.com>
Content-Type: text/plain; charset=utf-8; format=flowed
Content-Language: en-US
Content-Transfer-Encoding: 7bit
Subject: Re: [dpdk-dev] [PATCH v2] test: Fix memory corruption issues which
 fails the link_bonding test.
X-BeenThere: dev@dpdk.org
X-Mailman-Version: 2.1.15
Precedence: list
List-Id: DPDK patches and discussions <dev.dpdk.org>
List-Unsubscribe: <http://dpdk.org/ml/options/dev>,
 <mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://dpdk.org/ml/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <http://dpdk.org/ml/listinfo/dev>,
 <mailto:dev-request@dpdk.org?subject=subscribe>
X-List-Received-Date: Wed, 12 Jul 2017 10:25:51 -0000

On 10/07/17 12:13, Herbert Guan wrote:
> Patch V2: fix build warnings by deleting unused variables.
> 
> There were double-free problems in some test cases, which will cause
> a duplicated mbuf will be added into mempool.  After double-free,
> some new allocated mbuf will hold a same address and thus cause the
> memory corruption.
> 
> Another minor issue is that in some test cases, allocated mbuf will
> not be released after test case exits.  Hopefully these leaked mbuf
> will be released by the next test case in its setup phase when
> stopping the virtual pmd ports, while this do is a memory leak of
> the exited test case.
> 
> To fix above 2 issues, this patch will do:
> 1) Release virtual pmd ports' tx queue in the clean up function
>     remove_slaves_and_stop_bonded_device() of each test cases.
> 2) Do not release allocated mbufs for test bursts.  These mbufs
>     will be released in remove_slaves_and_stop_bonded_device() when
>     test case exits.
> 
> Signed-off-by: Herbert Guan <herbert.guan@arm.com>
> ---
...
> 

Acked-by: Declan Doherty <declan.doherty@intel.com>