From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from NAM01-SN1-obe.outbound.protection.outlook.com (mail-sn1nam01on0052.outbound.protection.outlook.com [104.47.32.52]) by dpdk.org (Postfix) with ESMTP id 5F76E282 for ; Fri, 27 Jan 2017 08:13:24 +0100 (CET) Received: from BN6PR03CA0017.namprd03.prod.outlook.com (10.168.230.155) by CY4PR03MB2471.namprd03.prod.outlook.com (10.168.165.7) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_CBC_SHA384_P384) id 15.1.860.13; Fri, 27 Jan 2017 07:13:22 +0000 Received: from BL2FFO11OLC008.protection.gbl (2a01:111:f400:7c09::176) by BN6PR03CA0017.outlook.office365.com (2603:10b6:404:23::27) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_CBC_SHA384_P384) id 15.1.874.12 via Frontend Transport; Fri, 27 Jan 2017 07:13:22 +0000 Authentication-Results: spf=fail (sender IP is 192.88.168.50) smtp.mailfrom=nxp.com; 6wind.com; dkim=none (message not signed) header.d=none;6wind.com; dmarc=fail action=none header.from=nxp.com; Received-SPF: Fail (protection.outlook.com: domain of nxp.com does not designate 192.88.168.50 as permitted sender) receiver=protection.outlook.com; client-ip=192.88.168.50; helo=tx30smr01.am.freescale.net; Received: from tx30smr01.am.freescale.net (192.88.168.50) by BL2FFO11OLC008.mail.protection.outlook.com (10.173.160.143) with Microsoft SMTP Server (version=TLS1_0, cipher=TLS_RSA_WITH_AES_256_CBC_SHA) id 15.1.803.8 via Frontend Transport; Fri, 27 Jan 2017 07:13:22 +0000 Received: from [10.232.14.39] ([10.232.14.39]) by tx30smr01.am.freescale.net (8.14.3/8.14.0) with ESMTP id v0R7DITm018615; Fri, 27 Jan 2017 00:13:19 -0700 To: Thomas Monjalon , "Van Haaren, Harry" References: <2358632.GCFl4gnRC2@xps13> CC: , "Yigit, Ferruh" , Igor Ryzhov , Steve Shin From: Shreyansh Jain Message-ID: <7fb35576-ba10-019a-a6ba-e38418e03848@nxp.com> Date: Fri, 27 Jan 2017 12:48:06 +0530 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:45.0) Gecko/20100101 Thunderbird/45.6.0 MIME-Version: 1.0 In-Reply-To: <2358632.GCFl4gnRC2@xps13> Content-Type: text/plain; charset="windows-1252"; format=flowed Content-Transfer-Encoding: 7bit X-EOPAttributedMessage: 0 X-Matching-Connectors: 131299748023178026; (91ab9b29-cfa4-454e-5278-08d120cd25b8); () X-Forefront-Antispam-Report: CIP:192.88.168.50; IPV:NLI; CTRY:US; EFV:NLI; SFV:NSPM; SFS:(10009020)(6009001)(336005)(7916002)(39850400002)(39860400002)(39840400002)(39380400002)(39450400003)(39400400002)(39410400002)(2980300002)(1110001)(1109001)(339900001)(377454003)(199003)(377424004)(52314003)(24454002)(189002)(31696002)(229853002)(77096006)(38730400001)(2906002)(104016004)(65956001)(65806001)(47776003)(4326007)(54906002)(105606002)(106466001)(92566002)(50986999)(31686004)(76176999)(54356999)(8936002)(356003)(81166006)(2950100002)(81156014)(8676002)(6666003)(305945005)(189998001)(53936002)(50466002)(36756003)(64126003)(68736007)(65826007)(5660300001)(86362001)(626004)(33646002)(230700001)(85426001)(5001770100001)(97736004)(4001350100001)(83506001)(23746002); DIR:OUT; SFP:1101; SCL:1; SRVR:CY4PR03MB2471; H:tx30smr01.am.freescale.net; FPR:; SPF:Fail; PTR:InfoDomainNonexistent; A:1; MX:1; LANG:en; X-Microsoft-Exchange-Diagnostics: 1; BL2FFO11OLC008; 1:OlZxkggn7xjSOqkB2Q12VL8Q8mulBl/Os2uR3j5e/YJVj344C3A20eZLfTCdYEBPAUgKXvxQhHGJoT1qGUqwtkWZ2yGam7raCh43dWOOuqVDbGYkEZVYSG11wZ/1hKK9wfJ6yy9ffEOSk/gUrgTwD/YWvIhSadbk44G7coSLM6x/vlAENabBbxwZ4o+bj66PSr9nzE7Ll1PuUeBg8gRcNoed2YQIdyb/nA4Q9khNzGTO/j2gNoptvr3SbIs3oqpYvWSKX8XeX4IH2x1em+yOaA/ILsaJIcO+OOfWONtTgXO1giXNEGmRo0x6WLh5z4bc4farX+VUZOuI55Ca//6dEz3eWw/Zdguz3Y5aD880RBiQRcZWwtbR+EuI+0O0B8ydYG/ThMrj7xxHX8tYeYu6CIOLqBkqGoJUQj2bh9C8zttGeKAJhvLbnAAjwd+zKqBniXGYK/DkH/NDUDT219kv0Ly3bsfrlnNYKl6OTRPEJvqWo5nSMV7j7mepYymUKAyj7W9p4F//IfixnYUc9EPiaDD+zEoESDfmieBrEPDu8Q23NAw0ocrPRkMy4pn3X4C4LjJAcCjTaEhgPF8/1+WUDdnmaA622BlXtiloa1BIuJ0= X-MS-Office365-Filtering-Correlation-Id: 65e5bbb3-e7ae-4e32-a6e5-08d44683fa66 X-Microsoft-Antispam: UriScan:;BCL:0;PCL:0;RULEID:(22001);SRVR:CY4PR03MB2471; X-Microsoft-Exchange-Diagnostics: 1; CY4PR03MB2471; 3:Gt7UGVzT6NlYWcv+cyu8MNLGE+wwnTzeDi5NppeiS8fBOn29YFNFeAAuyAPC1jj+Qi3zrb67CBX598lXtnm70tqJTVOeIbNX/454VPfi1C8/8BDvzW/C9BEYyqhPV6uMUGLTdZomnPIyloRYGCPL0ak5A0RTkOl+O55IiqN/kN63W5vkiZJTzpN8KFe8ymAhmUdPpL02jHw90a3RUWr8tWYfd67snwxfIBpMNFl89KegsKL4e1FhIDay9paYNLiPnogyU+k89eTlr8jOJtNj65aF3gaamLZHAdkIoeGtJqhz/+hreEz1miQJVjsaq92MSWZ6jIhO51MoGJ1wyLOvQXu+LqKkAJ/prhDmLMqxQEHPNKo8m2MykSld/8J1aQ1c; 25:EsDjI2h8CD4uZMzT0Xt3TO+k5S0zVoFZv4VZnI3iODFpRkFRtUuoJmbMNVOZckexbrp1RvpbR2PesedNMYlVS5vjAznlzhSBoVP/uTvvBhVmfSwKbyh8PD5urLmS7q/gNQ43MQmd7iLDFPMtHX7gq8KuYEziAiMPdZk/bz0hfIih+LVE6jGUeOiwLVZHk5AiI7fuIxoZiNOWydVnC3C7i5Snudh8AdN7RNX5WzgrMVdpDgDXDznbxgxLAWtw/qB91NTP8brLA+AeXHv6PUr+X32FvYSFdTx5bPSImdt5KUOn8RngXQG6/Y9yOlMQpnFo+AC16z5INfH0H41KS1DbBABDyikqgQMAsFgfK7eT5G9gcTBrFxrFsta5AaBcuOkVdhnvd+Cn0xH0kX6QtEcu2wEWAJBhpdWpcBAKX9+rzVi34BGbuwa+GfMe94E60m3gZc92nxs48ABfhjtTVdVyYg== X-Microsoft-Exchange-Diagnostics: 1; CY4PR03MB2471; 31:SXiREN5w68H0ZoJQRVRc9kC+yMg0DkZHlS4Azd33SGleMu+OB0OmnCpVGoztGN+t3/crq3TetdHI+Z9WtiG1AXndQ14WWS7xID2BP/NpyqPq1tGjsepwdSqy50jwL1kHs4xHXBQiAvJI10FrFL92Z9zM+YVx3ZunvNFBq8WcAGfBESgz1uU83GTBynL1zVdZ1ro79/vK2BbzwDElC727YSRzRz/5nIEBjf6s61BhX0j+YiM/lyPqxJBb7YOV94dmucq+Jp4+0Lm58T63XbFrcW7LgZfa3LpeVDLKLjw9vhk= X-Microsoft-Antispam-PRVS: X-Exchange-Antispam-Report-Test: UriScan:(100405760836317); X-Exchange-Antispam-Report-CFA-Test: BCL:0; PCL:0; RULEID:(6095060)(601004)(2401047)(13017025)(13024025)(13015025)(13018025)(8121501046)(13023025)(5005006)(3002001)(10201501046)(6055026)(6096035)(20161123561025)(20161123559025)(20161123556025)(20161123563025)(20161123565025); SRVR:CY4PR03MB2471; BCL:0; PCL:0; RULEID:(400006); SRVR:CY4PR03MB2471; X-Microsoft-Exchange-Diagnostics: 1; CY4PR03MB2471; 4:btye3fgUyEY1EGwwDfj4M4HYWJtK+ArzWMIYY2ob9LRcoa9xDSXm1/fzhRuQHlteN5z7lMvsbfsrRQTqfPnFf+s/P0lUPQrHruIVudX5FJK5A/2NsLYjyFFzjqP4/c2+elTChTZtXl1AMDNUKn9qLJb+33DgAkUQpDLiNVNeBW8e1CLozCojI35KyYFqlYLdF3wM8LbRTk9vWYCCacIqKIcCJlKDBEkmupeSUmhkhQGWoQ0pGxEiAFWdjsp88OC+UVI/XCS+4JW0hAlbOG28EJYy18jMy0uFugmeg+3tNsRQrLLVT8009hQF2t6jzWqcl7RhoQO+TU8GtQ8inWbikkkeBZsWr18Q2seCcNmoAxuoUQz//tK5EYJWkFLNreKNBDW2UxUQDpFe/fh8QHSW2OLRFkZhWP1G8IK1pWvg7vE9AFe/n7TG1/zyFabxFkcQfMIoYy3VE5RWqp5yHi/eTn8/wA29MUcgJTb+Q5p1yb6mTQhFdkYAi2hQnwcFt9+WoClMBOY/b1onyK78X2RyFvRyZot525C8OZwxZZTy1eRWAi+4r7dAe7Z58/q3hA/yJMIg+FKz+zRk1EqzD1JamOJ+xTzFSK3Ho4lK8sDrWXhmtR3Iq0Cku91b0WoFLOS2PY7bJctPlZIQLIhqqLsHzxqHIg8zyXe8X5CWyMVwRqhSCJrM7AgSIyGJ3rxXHeKfe3AjkPHzqJaSGlrjQ90VVmPJ7/Q54lrRrTYmf3xCKmy8wvOfVyflxQCQuU4FgiQZ X-Forefront-PRVS: 0200DDA8BE X-Microsoft-Exchange-Diagnostics: =?Windows-1252?Q?1; CY4PR03MB2471; 23:5EM6MJiyOe+kd03naQ6pZvhwGrQ+zagPsNI/W?= =?Windows-1252?Q?WU96cMdT8DaqGWxVtEkAA+1iIy8Z7AS+cM7vfG1kqvwYiEL+hQxzJQRk?= =?Windows-1252?Q?xRJll3GtSvLKic3KTnHQdaeQVEbGrJp1J1t7oQLW/4olzgJEcxYn+Gve?= =?Windows-1252?Q?k/RfWp+3et+Ce4C83Y1m7Noi3/O9UWEaQFWFugFRIazF3BkbXfKNfR6D?= =?Windows-1252?Q?r04wZDSK6vkxK3BvfXORN1FBqK0mUvO2pJ3fm1ex7VY76AXdS+Nmi9Y5?= =?Windows-1252?Q?28Qn9VjCFaGsVagQ7isFP1WTmxhpGQdRo+1mgq9AXLy7IRsx6U8A6EQL?= =?Windows-1252?Q?u/ddtN1gEB4AjedbTA7fg7/KuwE2TzUUjARDELBTzSPDL4yrib2Sy0aL?= =?Windows-1252?Q?FWPLFl2FJN/Il03QH+E/WVOEVKLg+aZ32S8Y61HT0cZQfZAERHFxXohc?= =?Windows-1252?Q?eOFp18X5+7kC/FUBZxaa3wXc0erW1uryrKzA50skL3rabPAHUrvSF8CW?= =?Windows-1252?Q?ytA8NCPcKuIHz0YIRjLtju052VGDBaAc2srRvcwK7Qtl2RC2isBqAQ/m?= =?Windows-1252?Q?C92hCTOBxIeKXucV6Ecsr6qr6fa4WW+i/DFoslnl257NEdMZ4cMK536G?= =?Windows-1252?Q?3BzPUze9UsaFs0zY7+uAqYsbB8M56z7G3XFzNW/wSohewo0U0w6+/CAW?= =?Windows-1252?Q?yVzdegASPgh9zf6Cj/HC/AWnnXuT95W0TOFWOhQYYsbN1AEZB3JrhH4K?= =?Windows-1252?Q?Gr3fes0JypjLhvo1FbR2dWllGjwCE/j/2hZsB1DVhYIJsDYsVSWhbIqq?= =?Windows-1252?Q?hxN9vBTHPbqg5wIANtUByPB7PfL0HI/e++0uIw6p7BJLrkmXSobePGbv?= =?Windows-1252?Q?t42gIw7rlrAiRs8fTre9barvK66N3RIJdx1mC600sIzCvODOi3n7I+gO?= =?Windows-1252?Q?3SeH6Vbm7oGcwhRJ3fiVR6iRJrpc/LSTjB13fAS4BrdlFbEVFU3u2Qx+?= =?Windows-1252?Q?Dsu/YbVKY5ZxkffVzLK9QYmq54DViG3KpNskTGxxQE17/WnxY+iPMOEw?= =?Windows-1252?Q?QzPUFcwHDJjfx5DmLSh0B9pUNeu93TBSUHpjI6FzGf3tsrav0LONwrvo?= =?Windows-1252?Q?Z0T4Wzu7OC/q1UGTOUf+R6ZpU+s38c7vwqi+XXGc2HISlvWAtZa8/jHa?= =?Windows-1252?Q?pv0YdiM45D1h8owPNwe0M43SFO/mcySIrbf6eEW1imyBKeNh+lKf7o1Z?= =?Windows-1252?Q?XNaRcVRPmvnxkJNkBmiFVPQstEFUOAvdqssQOJNR0YbZMRZhjbKiNZtK?= =?Windows-1252?Q?NJi4CvbHm2XUZCerPJfUSUn01XhlQ8Ia656sUkyRCC88uhYPccz+9Xcu?= =?Windows-1252?Q?bWDFal7ohPeMZWTO5dI4rNlU5/sD160vmip8/3sVO3jJX3Aj3UlkjnL4?= =?Windows-1252?Q?i8pNIkzw6Kamb/j148I+E7IVFguB+3ANXhAsSZPkuZms0OdvO+QnSgwl?= =?Windows-1252?Q?RUya0ynJLP7DaaguJPQUld3uBmg3g+czagNUAwKmAzI07bo/fCakq+qV?= =?Windows-1252?Q?rVpIvHBBxCrYFpW845nswuKz2kEUI/BhHSBNxUY7jgz7kpKsOsnLNo1N?= =?Windows-1252?Q?+aZ0R7sbj1S05zdvA7iWu8TCboCkxb7Yp3+AnY7XtX/+1s5/3nLZ0O0u?= =?Windows-1252?Q?/CkZT4Nng=3D=3D?= X-Microsoft-Exchange-Diagnostics: 1; CY4PR03MB2471; 6:v8Sshy/zqwqzkRkklpKOQu2+xFRMxw6XcdYZSmETd7naDO5AfMfMVxwL6hFk9AZ1/sBmy2NfYkjUPRBJxlwoIVqSUjIzAvl6BW6OtrlHqzu65NFHDpPI3T+PqUHSGi3fQeOi6oIs6OZigTkdGYco4WGI6JrFWDblSp5dJ3QAnHb1hmFnEv7kqRdPaOHW6rJbHK7Rrsm9OU8tiHHsHs1ooduVbg2Tg6cCsNzHuowmviuwQzwV5ARn4POtS9xGxAuW3iOu+VPNIDgRP7YSG7XHzZ1RMhXTm/7Ai84pZMYc3SE9TSphLHRsHVD4hT1TMJyq+iHx9Q/WkJOEAVrDPTM+dKBrdF9O8RC/S7Pv/oPa9G5CzZ9puFIckWjIcj8xCniwf3wqvrl9DdW3aIPySs0jbODvqpfC3aURQ/7xJc6YJcQj9hYZGdnAFEENAXxXtPrd; 5:x87vN2kkw2zGP0c8+3GShyUC47s+Q01GTDtylcnleyYPf7PosQntZ4VVbqGrEau3BB9ARHRJH9dX4GVRtWPdxAgWgyLSY5z6samgHdNA8susOzBwxe9w5Fnh5Bzl2vwHHKHKaeh4wL+H+3gb17CKUY61NocnQawmXLvnriv5xbUd7Y8fCL3yHF7bz060IEpB; 24:0c4oFkTBTsS/rA5WNKWhaUy2GmxUIDS/TnFOTVZ5CdYMVVx4KsWrmbGgyoWXveLuf2DnxdZlR5HoNg0u/i32nP4iZXZiBSgYfP3/n0VsFa0= SpamDiagnosticOutput: 1:99 SpamDiagnosticMetadata: NSPM X-Microsoft-Exchange-Diagnostics: 1; CY4PR03MB2471; 7:UvRdmgLXar2Wla/1FTZY8mNGkISJ922RpfvVhHpf5vir0xKcGggnMcSKc7G4s5TxUbGfXuZheUvkZyS8xC/idxA1xqHyeiZO/oDELvi8KlUBIn4iCzJ/Y1mY0X9S7UNv17dpyA/iR4DKDzp7liJ21Fi8XD0LrVOrW4H4SsWqOu11Wjky+gcfH3MYXffkg2Uu5ZeKhwtaC38SUa3zt4kYTrMPMne+yVAs5fecNOEJgWe3DTmfZRLVnUe25QPXsHV4RwN1WAzP6Rp2PTOmkaaBMK3utoHRVZ+BuI/BP8+BoytxqtfXKgexemiPlNd2B1c4R/5w5H5toqgcp6nF4zrIIwzhN8w1TI0i5qWB4hL9ZMIGuKQMerwPA0+zTKgLjUeoWHSS/qYW2Jee1L1i10Bp1Q+KRVHB6uwhufSBiQ9ie7tWozIW7NylEvAqSemQXjvXc7rCr7nJ8LkILW0QLUHRiQ== X-MS-Exchange-CrossTenant-OriginalArrivalTime: 27 Jan 2017 07:13:22.0058 (UTC) X-MS-Exchange-CrossTenant-Id: 5afe0b00-7697-4969-b663-5eab37d5f47e X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=5afe0b00-7697-4969-b663-5eab37d5f47e; Ip=[192.88.168.50]; Helo=[tx30smr01.am.freescale.net] X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: CY4PR03MB2471 Subject: Re: [dpdk-dev] Understanding of Acked-By X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 27 Jan 2017 07:13:24 -0000 On Wednesday 25 January 2017 08:28 PM, Thomas Monjalon wrote: > 2017-01-25 13:53, Van Haaren, Harry: >> There was an idea (from Thomas) to better document the Acked-by and Reviewed-By in the above thread, which I think is worth doing to make the process clearer. I'll kick off a thread*, and offer to submit a patch for the documentation when a consensus is reached. >> >> >> The question that needs to be addressed is "What is the most powerful signoff to add as somebody who checked a patch?" > > I do not see the benefit of knowing the most powerful. > Anyway, the most powerful tags are done by trusted people. > And people are trusted after delivering good reviews or patches ;) > > The question should be "How to use the tags?" > >> The documentation mentions Acked, Reviewed, and Tested by[1], as signoffs that can be commented on patches. The Review Process[2] section mentions Reviewed and Tested by, but nowhere specifically states what any of these indicate. >> >> Offered below is my current understanding of the Acked-by; Reviewed-by; and Tested-by tags, in order of least-powerful first: >> >> >> 3) Tested-by: (least powerful) >> - Indicates having passed testing of functionality, and works as expected for Tester >> - Does NOT include full code review (instead use Reviewed by) >> - Does NOT indicate that the Tester understands architecture (instead use Acked by) >> >> >> 2) Reviewed-by: >> - Indicates having passed code-review, checkpatch and compilation testing by Reviewer > > Compilation testing is done by the CI. > The reviewer must just check the results. > >> - Does NOT include full testing of functionality (instead use Tested-by) >> - Does NOT indicate that the Reviewer understands architecture (instead use Acked by) > > I disagree here. > The reviewer must understand the impacts of the patch. > That's why a Reviewed-by tag is really strong. From what I understand, 'Reviewed-by' and 'Acked-by' are the other way around. - Acked-by is intent that 'I agree with change'. - Reviewed-by is 'I vouch for the changes' either through review or testing or both. > >> 1) Acked-by: (most powerful) >> - Indicates Reviewed-by, but also: > > A maintainer may want to approve the intent without doing a full review, > especially if he trusts the author or the reviewers. > That's why I think Acked-by should not include Reviewed-by. > If a maintainer does a full review, he should use Reviewed-by instead of Acked-by. > >> - Acker understands impact to architecture (if any) and agrees with changes >> - Acker has performed runtime sanity check > > Not sure about this one. > Personnaly I give some Acks without testing sometimes. > We may add a Tested-by to indicate we made some tests. > >> - Requests "please merge" to maintainer > > Yes, "please merge" to tree maintainer (committer). > >> - Level of trust in Acked-by based on previous contributions to DPDK/networking community > > The level of trust applies to any tag or comment. > >> The above is a suggested interpretation, alternative interpretations welcomed. > > Thanks Harry >