From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id 83E22A04B7; Wed, 14 Oct 2020 00:41:53 +0200 (CEST) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id 09C3C2B91; Wed, 14 Oct 2020 00:41:51 +0200 (CEST) Received: from mga03.intel.com (mga03.intel.com [134.134.136.65]) by dpdk.org (Postfix) with ESMTP id 3EE2C1DBA2; Wed, 14 Oct 2020 00:41:48 +0200 (CEST) IronPort-SDR: nibw6sFlIFgzmyxLuAEj0rgKvbXSPV88eqPhZG7flDfUSyxZpS+biqTgo+fzOTyKbFqPLB8z7F pBYn91z+gF5w== X-IronPort-AV: E=McAfee;i="6000,8403,9773"; a="166058679" X-IronPort-AV: E=Sophos;i="5.77,372,1596524400"; d="scan'208";a="166058679" X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from orsmga005.jf.intel.com ([10.7.209.41]) by orsmga103.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 13 Oct 2020 15:41:46 -0700 IronPort-SDR: X5KZfhIgSnjHNjY+6V31cbIU7Dp2y9YIDUMTF+SVwy3YwgR16Nl6m2v8fiSygua8Y1DY+k5KfO FN9Q3JHPh9vA== X-IronPort-AV: E=Sophos;i="5.77,372,1596524400"; d="scan'208";a="530591762" Received: from fyigit-mobl1.ger.corp.intel.com (HELO [10.213.214.64]) ([10.213.214.64]) by orsmga005-auth.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 13 Oct 2020 15:41:45 -0700 To: Andrew Rybchenko , Thomas Monjalon , Stephen Hemminger Cc: dev@dpdk.org, techboard@dpdk.org, Min Hu References: <20201012164602.1965694-1-ferruh.yigit@intel.com> <3382071.xncihUvvZe@thomas> <2290585.EWI7AWl3IT@thomas> From: Ferruh Yigit Message-ID: <7fb36143-dd8a-7c52-7223-00024edda598@intel.com> Date: Tue, 13 Oct 2020 23:41:41 +0100 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: 8bit Subject: Re: [dpdk-dev] [RFC 1/2] ethdev: move queue stats to xstats X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" On 10/13/2020 10:16 AM, Andrew Rybchenko wrote: > On 10/13/20 12:05 PM, Thomas Monjalon wrote: >> 13/10/2020 10:31, Andrew Rybchenko: >>> On 10/13/20 12:53 AM, Thomas Monjalon wrote: >>>> 12/10/2020 18:46, Ferruh Yigit: >>>>> Queue stats are stored in 'struct rte_eth_stats' as array and array size >>>>> is defined by 'RTE_ETHDEV_QUEUE_STAT_CNTRS' compile time flag. >>>>> >>>>> As a result of technical board discussion, decided to remove the queue >>>>> statistics from 'struct rte_eth_stats' in the long term. >>>>> >>>>> Instead PMDs should represent the queue statistics via xstats, this >>>>> gives more flexibility on the number of the queues supported. >>>> >>>> Yes >>> >>> I like Stephen's idea to have dedicated API to get stats per >>> queue. Of course it is doable via getting xstats by IDs, >>> but IMHO it is over-complicated. From the other hand >>> it sounds like a duplication to have it in xstats and >>> dedicated API (basically the same as we have for basic >>> stats and xstats). >> >> Please read my proposal to have fixed ids for common stats >> and fixed id ranges for stats per queue: >> https://fast.dpdk.org/events/slides/DPDK-2019-09-Ethernet_Statistics.pdf >> (slide 11) >> > > Ah, yes, I forgot that point. Makes sense and LGTM. > But we don't have (and not planned for) the fixed id ranges in the xstats yes, and agree it will be complicated to parse the queue stats from xstats without it. Should we wait for the fixed id ranges change before we continue with this patch?