From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 579C4A0093; Thu, 21 Apr 2022 15:48:36 +0200 (CEST) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 2E8874067C; Thu, 21 Apr 2022 15:48:36 +0200 (CEST) Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) by mails.dpdk.org (Postfix) with ESMTP id D80DE40042 for ; Thu, 21 Apr 2022 15:48:34 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1650548914; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=WMqMW7M+nMXMu+rZvUeQN4qYkoy3l+PPVO8bf9ZhGbE=; b=McoOvTasvyoW5q2WZDPPc/85zv6F9c1LC0QXdgCAHg7lIssIRJPUFpUhzq4jYWaDJNNau/ M/eko3vqkRSKll/I3l8rs15lvoaWLlsQqu4+cIWTjX56PwzoEQdTR9lccOUYfE6LqLYhDt XxoFFbgaqvYVvuLkSR3iGTo1blipDvA= Received: from mimecast-mx02.redhat.com (mx3-rdu2.redhat.com [66.187.233.73]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id us-mta-528-3WEVnDp6Nqa-XNVxZD4U4w-1; Thu, 21 Apr 2022 09:48:33 -0400 X-MC-Unique: 3WEVnDp6Nqa-XNVxZD4U4w-1 Received: from smtp.corp.redhat.com (int-mx04.intmail.prod.int.rdu2.redhat.com [10.11.54.4]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx02.redhat.com (Postfix) with ESMTPS id B920F1C0E0E9; Thu, 21 Apr 2022 13:48:32 +0000 (UTC) Received: from [10.39.208.35] (unknown [10.39.208.35]) by smtp.corp.redhat.com (Postfix) with ESMTPS id A60142026D07; Thu, 21 Apr 2022 13:48:25 +0000 (UTC) Message-ID: <7ff5b0bc-47aa-2062-555a-c7b7dc84c3a0@redhat.com> Date: Thu, 21 Apr 2022 15:48:23 +0200 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101 Thunderbird/91.7.0 To: David Marchand , dev@dpdk.org Cc: stephen@networkplumber.org, chenbo.xia@intel.com, jiayu.hu@intel.com, yuanx.wang@intel.com, xuan.ding@intel.com, Ruifeng Wang , Jan Viktorin , David Christensen , Bruce Richardson , Konstantin Ananyev References: <20220328121758.26632-1-david.marchand@redhat.com> <20220411110013.18624-1-david.marchand@redhat.com> <20220411110013.18624-2-david.marchand@redhat.com> From: Maxime Coquelin Subject: Re: [RFC PATCH v3 1/8] eal: annotate spinlock and rwlock In-Reply-To: <20220411110013.18624-2-david.marchand@redhat.com> X-Scanned-By: MIMEDefang 2.78 on 10.11.54.4 Authentication-Results: relay.mimecast.com; auth=pass smtp.auth=CUSA124A263 smtp.mailfrom=maxime.coquelin@redhat.com X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Language: en-US Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Hi David, On 4/11/22 13:00, David Marchand wrote: > clang offers some thread safety checks, statically verifying that locks > are taken and released in the code. > To use those checks, the full code leading to taking or releasing locks > must be annotated with some attributes. > > Wrap those attributes into our own set of macros. > > rwlock and the "normal" spinlock are instrumented. > > A component may enable this check by setting annotate_locks = true > in its meson.build. > > Note: those checks might be of interest out of DPDK, but it > requires that the including application locks are annotated. > On the other hand, applications out there might have been using > those same checks. > To be on the safe side, keep this instrumentation under a > RTE_ANNOTATE_LOCKS internal build flag. > > Signed-off-by: David Marchand > --- > Changes since RFC v2: > - fixed rwlock trylock, > - instrumented _tm spinlocks, > - aligned attribute names to clang, > > --- > drivers/meson.build | 5 ++ > lib/eal/arm/include/rte_rwlock.h | 4 ++ > lib/eal/arm/include/rte_spinlock.h | 6 +++ > lib/eal/include/generic/rte_rwlock.h | 27 +++++++++-- > lib/eal/include/generic/rte_spinlock.h | 40 ++++++++++----- > lib/eal/include/meson.build | 1 + > lib/eal/include/rte_lock_annotations.h | 67 ++++++++++++++++++++++++++ > lib/eal/ppc/include/rte_rwlock.h | 4 ++ > lib/eal/ppc/include/rte_spinlock.h | 9 ++++ > lib/eal/x86/include/rte_rwlock.h | 4 ++ > lib/eal/x86/include/rte_spinlock.h | 9 ++++ > lib/meson.build | 5 ++ > 12 files changed, 164 insertions(+), 17 deletions(-) > create mode 100644 lib/eal/include/rte_lock_annotations.h > Thanks for working on this. I think this lock annotation feature is very useful, and will help to catch bugs when libs and drivers will adopt it. Acked-by: Maxime Coquelin Regards, Maxime