From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-lf0-f46.google.com (mail-lf0-f46.google.com [209.85.215.46]) by dpdk.org (Postfix) with ESMTP id 61F842946 for ; Thu, 6 Oct 2016 14:56:14 +0200 (CEST) Received: by mail-lf0-f46.google.com with SMTP id b75so15156534lfg.3 for ; Thu, 06 Oct 2016 05:56:14 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=6wind-com.20150623.gappssmtp.com; s=20150623; h=from:to:cc:subject:date:message-id:user-agent:in-reply-to :references:mime-version:content-transfer-encoding; bh=X8sCB+sQALnhaK/QUX27sbP1s0YPoh0JfYQMElBXd6w=; b=pQgVfOMJFzFFFnBsnW82voUa6O1CP0DqXTV2qd6LlIACAclehVxKk9Le2ESYcjdjbZ s6VKI9zSqaIJEAxYd1jvBoetLY7loCfF4BqktzsQplMm3sqTA8qWDglwWXzBpcq6KQeP 5Avr82l/3Xbq4WPpqNVjseSyeIa/3Jq43gUIWLX5TYOdVjv0dA3vYik2XWyZ29GiDu+a ALkJlXwvuPnYWS32HYdltf2vRQ+laSkY1YHI4jo8DaYNJD73FoqHHPvuobIdSjXVA7ju sKcfbmY3ysYHLDqYcu08dJq7QUtnzvYqHvyQGMN8VQNCtka4Qfl7YMegee29bR3KdLld KGpA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:from:to:cc:subject:date:message-id:user-agent :in-reply-to:references:mime-version:content-transfer-encoding; bh=X8sCB+sQALnhaK/QUX27sbP1s0YPoh0JfYQMElBXd6w=; b=LAH040fLkCwjL50mf/z8MEmvdvrNnAWQkylucMPXfTIeljuaDFaENJ3c9MbrAKudvu RzM1iO2cqsHY6j4oMMO00eK2eO7/A0EYb56CUFJKJUMV1Gc1TNfpkvISurPlkFwgHsfL 4tFY9L7/WH3DdNZ2w7hcHyYSPWQFXsFGpyhiBBuEwmpMrBqRvdFPs2M60Cp9MMrddOW5 QG5U2C+WZ5vrPCTZ25OtxSKwckXLHinDVLlbCCObOFlD1pJBVB8GM7oON9Sg3BZ4Cmro 4RIQ/FMJCQDi4xZVe4CaDmo8DcZy7qXDQoIglTL4j8PpMID3oK0LvC8YB33JcbTgRuU4 1FzQ== X-Gm-Message-State: AA6/9RmXKY/br9aF1sgfad6q8my22MeJRYOa2m2QzJIzfdPXS4b+/TnTVbKkxWJT+BYuVWO9 X-Received: by 10.194.179.170 with SMTP id dh10mr7664212wjc.94.1475758573893; Thu, 06 Oct 2016 05:56:13 -0700 (PDT) Received: from xps13.localnet (232.204.154.77.rev.sfr.net. [77.154.204.232]) by smtp.gmail.com with ESMTPSA id vh6sm14446288wjb.0.2016.10.06.05.56.12 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Thu, 06 Oct 2016 05:56:13 -0700 (PDT) From: Thomas Monjalon To: Bernard Iremonger Cc: dev@dpdk.org, rahul.r.shah@intel.com, wenzhuo.lu@intel.com, az5157@att.com, jerin.jacob@caviumnetworks.com Date: Thu, 06 Oct 2016 14:56:04 +0200 Message-ID: <8021250.9Wl94qBdaq@xps13> User-Agent: KMail/4.14.10 (Linux/4.5.4-1-ARCH; KDE/4.14.11; x86_64; ; ) In-Reply-To: <1475753191-17391-2-git-send-email-bernard.iremonger@intel.com> References: <1475592734-22355-1-git-send-email-bernard.iremonger@intel.com> <1475753191-17391-2-git-send-email-bernard.iremonger@intel.com> MIME-Version: 1.0 Content-Transfer-Encoding: 7Bit Content-Type: text/plain; charset="us-ascii" Subject: Re: [dpdk-dev] [PATCH v5 01/13] librte_ether: modify internal callback function X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: patches and discussions about DPDK List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 06 Oct 2016 12:56:14 -0000 2016-10-06 12:26, Bernard Iremonger: > void > _rte_eth_dev_callback_process(struct rte_eth_dev *dev, > - enum rte_eth_event_type event) > + enum rte_eth_event_type event, void *param) You need to squash the patches updating the calls to this function. Otherwise, this patch does not compile. [...] > + if (param != NULL) > + dev_cb.cb_arg = (void *) param; You are overriding the user parameter. As it is only for a new event, it can be described in the register API that the user param won't be returned for this event. But a better design would be to add a new parameter to the callback. However it will be an API breakage. > + RTE_ETH_EVENT_VF_MBOX, /**< PF mailbox processing callback */ Sorry I do not parse well this line. The event name is VF_MBOX and the comment is about the callback processing this event on PF side? I would suggest this kind of comment: "message from VF received by PF" [...] > * Pointer to struct rte_eth_dev. > * @param event > * Eth device interrupt event type. > + * @param param > + * Parameter to pass back to user application. > + * Allows the user application to decide if a particular function > + * is permitted. In a more generic case, the parameter gives some details about the event.