From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id C47AF41CE4; Mon, 20 Feb 2023 01:30:17 +0100 (CET) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id B9AF742D8D; Mon, 20 Feb 2023 01:30:17 +0100 (CET) Received: from wout1-smtp.messagingengine.com (wout1-smtp.messagingengine.com [64.147.123.24]) by mails.dpdk.org (Postfix) with ESMTP id 51C5D40691 for ; Mon, 20 Feb 2023 01:30:16 +0100 (CET) Received: from compute5.internal (compute5.nyi.internal [10.202.2.45]) by mailout.west.internal (Postfix) with ESMTP id DEC9C3200124; Sun, 19 Feb 2023 19:30:14 -0500 (EST) Received: from mailfrontend2 ([10.202.2.163]) by compute5.internal (MEProxy); Sun, 19 Feb 2023 19:30:15 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=monjalon.net; h= cc:cc:content-transfer-encoding:content-type:date:date:from:from :in-reply-to:in-reply-to:message-id:mime-version:references :reply-to:sender:subject:subject:to:to; s=fm1; t=1676853014; x= 1676939414; bh=iytzsgSHpReXmvMjt4Wh6T3aI4EU5ajIUzz+fyFzjg0=; b=H ABZvQjJwB6dZW+NxWVdiOvGO/JGlUELUiUmu89RiywYXzreYOgsd3BZq7+xuwCEh TjxZ17n7VFRNXPfKLcHBlssllSl9ojyuPtLELXDH+1uWi4qCyEB8PNxoFBze6sHo Mr2I2riALtE8EAVqNNjF+qzsHMpLi3qABVEkaQYXWEO9urhg6SQXofy9iIePz7XU XJ/DPFCPS5Ev0EeHCZSQqJol8gE8qlWHpKeIXdtUBv2GTUo6IkVO2G40AJNtPn8U djCv/Zm63CKtve3SWNGfKobnUQdy/MgigCeALTNqekx4KHKMwCw+jDLZ0PAr6WZp UpcGmUt9KGbtXoNLhxqKg== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:cc:content-transfer-encoding :content-type:date:date:feedback-id:feedback-id:from:from :in-reply-to:in-reply-to:message-id:mime-version:references :reply-to:sender:subject:subject:to:to:x-me-proxy:x-me-proxy :x-me-sender:x-me-sender:x-sasl-enc; s=fm1; t=1676853014; x= 1676939414; bh=iytzsgSHpReXmvMjt4Wh6T3aI4EU5ajIUzz+fyFzjg0=; b=l 5YMnNEdJ+m+T+GLg2oB4+Z5Jkf2BzAwXG7srBRlMwQrWdYOO9EpQNjWK4JhB5aYI LJk7Vt0O3JrAnORXflj9oz1FuVR9d/6uYgXKKHGdXOkTMIQzq3AtKv2zQR2KUQAu XJKcVeGbZLGGNiuxXdKV86jardYx97msIwoXp5RLma+3DGAAwu1LWn48G21wCqMt DXRFI2cz0bvQF0DPwSnE5IrywGqkdImJGngPlqCWBhvo/nfOMM8Z1cLlZ8YZLyOj HvyiFbGZcaGJpH06Klal6Abp0RCGfGm3GyE+VzX2cHuDeRrJjB8e4dybKRXs4ZEQ sFSHzHtRIP94sgthNQL0A== X-ME-Sender: X-ME-Received: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgedvhedrudejgedgvddtucetufdoteggodetrfdotf fvucfrrhhofhhilhgvmecuhfgrshhtofgrihhlpdfqfgfvpdfurfetoffkrfgpnffqhgen uceurghilhhouhhtmecufedttdenucesvcftvggtihhpihgvnhhtshculddquddttddmne cujfgurhephffvvefufffkjghfggfgtgesthfuredttddtvdenucfhrhhomhepvfhhohhm rghsucfoohhnjhgrlhhonhcuoehthhhomhgrshesmhhonhhjrghlohhnrdhnvghtqeenuc ggtffrrghtthgvrhhnpedtjeeiieefhedtfffgvdelteeufeefheeujefgueetfedttdei kefgkeduhedtgfenucevlhhushhtvghrufhiiigvpedtnecurfgrrhgrmhepmhgrihhlfh hrohhmpehthhhomhgrshesmhhonhhjrghlohhnrdhnvght X-ME-Proxy: Feedback-ID: i47234305:Fastmail Received: by mail.messagingengine.com (Postfix) with ESMTPA; Sun, 19 Feb 2023 19:30:13 -0500 (EST) From: Thomas Monjalon To: Tyler Retzlaff , "Zhang, Ke1X" Cc: dev@dpdk.org, "Zhang, Qi Z" , "Yang, Qiming" , "dev@dpdk.org" , david.marchand@redhat.com Subject: Re: [PATCH v2] net/ice: fix ice dcf control thread crash Date: Mon, 20 Feb 2023 01:30:12 +0100 Message-ID: <8025144.eFmWaWnqpD@thomas> In-Reply-To: References: <20230208083005.290571-1-ke1x.zhang@intel.com> <3820540.fW5hKsROvD@thomas> MIME-Version: 1.0 Content-Transfer-Encoding: 7Bit Content-Type: text/plain; charset="us-ascii" X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org 16/02/2023 08:53, Zhang, Ke1X: > From: Thomas Monjalon > > 13/02/2023 08:16, Ke Zhang: > > > --- a/lib/eal/windows/include/pthread.h > > > +++ b/lib/eal/windows/include/pthread.h > > > +static inline void > > > +pthread_exit(__rte_unused void *__retval) { } > > > > Please don't add more shim layer. > > There is a new layer rte_thread_* in lib/eal/include/rte_thread.h > > > Thanks for your comments. > Do I need add a function like rte_thread_exit() in in lib/eal/include/rte_thread.h? I guess yes. > There is no function for supporting pthread_exit. Tyler, how would you achieve the equivalent of pthread_exit?